* feat(go): make go fmt git-aware by default - By default, only check changed Go files (modified, staged, untracked) - Add --all flag to check all files (previous behaviour) - Reduces noise when running fmt on large codebases Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(build): minimal output by default, add missing i18n - Default output now shows single line: "Success Built N artifacts (dir)" - Add --verbose/-v flag to show full detailed output - Add all missing i18n translations for build commands - Errors still show failure reason in minimal mode Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat: add root-level `core git` command - Create pkg/gitcmd with git workflow commands as root menu - Export command builders from pkg/dev (AddCommitCommand, etc.) - Commands available under both `core git` and `core dev` for compatibility - Git commands: health, commit, push, pull, work, sync, apply - GitHub orchestration stays in dev: issues, reviews, ci, impact Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(qa): add docblock coverage checking Implement docblock/docstring coverage analysis for Go code: - New `core qa docblock` command to check coverage - Shows compact file:line list when under threshold - Integrate with `core go qa` as a default check - Add --docblock-threshold flag (default 80%) The checker uses Go AST parsing to find exported symbols (functions, types, consts, vars) without documentation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: address CodeRabbit review feedback - Fix doc comment: "status" → "health" in gitcmd package - Implement --check flag for `core go fmt` (exits non-zero if files need formatting) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * docs: add docstrings for 100% coverage Add documentation comments to all exported symbols: - pkg/build: ProjectType constants - pkg/cli: LogLevel, RenderStyle, TableStyle - pkg/framework: ServiceFor, MustServiceFor, Core.Core - pkg/git: GitError.Error, GitError.Unwrap - pkg/i18n: Handler Match/Handle methods - pkg/log: Level constants - pkg/mcp: Tool input/output types - pkg/php: Service constants, QA types, service methods - pkg/process: ServiceError.Error - pkg/repos: RepoType constants - pkg/setup: ChangeType, ChangeCategory constants - pkg/workspace: AddWorkspaceCommands Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * chore: standardize line endings to LF Add .gitattributes to enforce LF line endings for all text files. Normalize all existing files to use Unix-style line endings. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: address CodeRabbit review feedback - cmd_format.go: validate --check/--fix mutual exclusivity, capture stderr - cmd_docblock.go: return error instead of os.Exit(1) for proper error handling Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: address CodeRabbit review feedback (round 2) - linuxkit.go: propagate state update errors, handle cmd.Wait() errors in waitForExit - mcp.go: guard against empty old_string in editDiff to prevent runaway edits - cmd_docblock.go: log parse errors instead of silently skipping Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
305 lines
7.9 KiB
Go
305 lines
7.9 KiB
Go
package sources
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestCDNSource_Good_Available(t *testing.T) {
|
|
src := NewCDNSource(SourceConfig{
|
|
CDNURL: "https://images.example.com",
|
|
ImageName: "core-devops-darwin-arm64.qcow2",
|
|
})
|
|
|
|
assert.Equal(t, "cdn", src.Name())
|
|
assert.True(t, src.Available())
|
|
}
|
|
|
|
func TestCDNSource_Bad_NoURL(t *testing.T) {
|
|
src := NewCDNSource(SourceConfig{
|
|
ImageName: "core-devops-darwin-arm64.qcow2",
|
|
})
|
|
|
|
assert.False(t, src.Available())
|
|
}
|
|
|
|
func TestCDNSource_LatestVersion_Good(t *testing.T) {
|
|
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
if r.URL.Path == "/manifest.json" {
|
|
w.WriteHeader(http.StatusOK)
|
|
_, _ = fmt.Fprint(w, `{"version": "1.2.3"}`)
|
|
} else {
|
|
w.WriteHeader(http.StatusNotFound)
|
|
}
|
|
}))
|
|
defer server.Close()
|
|
|
|
src := NewCDNSource(SourceConfig{
|
|
CDNURL: server.URL,
|
|
ImageName: "test.img",
|
|
})
|
|
|
|
version, err := src.LatestVersion(context.Background())
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "latest", version) // Current impl always returns "latest"
|
|
}
|
|
|
|
func TestCDNSource_Download_Good(t *testing.T) {
|
|
content := "fake image data"
|
|
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
if r.URL.Path == "/test.img" {
|
|
w.WriteHeader(http.StatusOK)
|
|
_, _ = fmt.Fprint(w, content)
|
|
} else {
|
|
w.WriteHeader(http.StatusNotFound)
|
|
}
|
|
}))
|
|
defer server.Close()
|
|
|
|
dest := t.TempDir()
|
|
imageName := "test.img"
|
|
src := NewCDNSource(SourceConfig{
|
|
CDNURL: server.URL,
|
|
ImageName: imageName,
|
|
})
|
|
|
|
var progressCalled bool
|
|
err := src.Download(context.Background(), dest, func(downloaded, total int64) {
|
|
progressCalled = true
|
|
})
|
|
|
|
assert.NoError(t, err)
|
|
assert.True(t, progressCalled)
|
|
|
|
// Verify file content
|
|
data, err := os.ReadFile(filepath.Join(dest, imageName))
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, content, string(data))
|
|
}
|
|
|
|
func TestCDNSource_Download_Bad(t *testing.T) {
|
|
t.Run("HTTP error", func(t *testing.T) {
|
|
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
w.WriteHeader(http.StatusInternalServerError)
|
|
}))
|
|
defer server.Close()
|
|
|
|
dest := t.TempDir()
|
|
src := NewCDNSource(SourceConfig{
|
|
CDNURL: server.URL,
|
|
ImageName: "test.img",
|
|
})
|
|
|
|
err := src.Download(context.Background(), dest, nil)
|
|
assert.Error(t, err)
|
|
assert.Contains(t, err.Error(), "HTTP 500")
|
|
})
|
|
|
|
t.Run("Invalid URL", func(t *testing.T) {
|
|
dest := t.TempDir()
|
|
src := NewCDNSource(SourceConfig{
|
|
CDNURL: "http://invalid-url-that-should-fail",
|
|
ImageName: "test.img",
|
|
})
|
|
|
|
err := src.Download(context.Background(), dest, nil)
|
|
assert.Error(t, err)
|
|
})
|
|
}
|
|
|
|
func TestCDNSource_LatestVersion_Bad_NoManifest(t *testing.T) {
|
|
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
w.WriteHeader(http.StatusNotFound)
|
|
}))
|
|
defer server.Close()
|
|
|
|
src := NewCDNSource(SourceConfig{
|
|
CDNURL: server.URL,
|
|
ImageName: "test.img",
|
|
})
|
|
|
|
version, err := src.LatestVersion(context.Background())
|
|
assert.NoError(t, err) // Should not error, just return "latest"
|
|
assert.Equal(t, "latest", version)
|
|
}
|
|
|
|
func TestCDNSource_LatestVersion_Bad_ServerError(t *testing.T) {
|
|
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
w.WriteHeader(http.StatusInternalServerError)
|
|
}))
|
|
defer server.Close()
|
|
|
|
src := NewCDNSource(SourceConfig{
|
|
CDNURL: server.URL,
|
|
ImageName: "test.img",
|
|
})
|
|
|
|
version, err := src.LatestVersion(context.Background())
|
|
assert.NoError(t, err) // Falls back to "latest"
|
|
assert.Equal(t, "latest", version)
|
|
}
|
|
|
|
func TestCDNSource_Download_Good_NoProgress(t *testing.T) {
|
|
content := "test content"
|
|
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
w.Header().Set("Content-Length", fmt.Sprintf("%d", len(content)))
|
|
w.WriteHeader(http.StatusOK)
|
|
_, _ = fmt.Fprint(w, content)
|
|
}))
|
|
defer server.Close()
|
|
|
|
dest := t.TempDir()
|
|
src := NewCDNSource(SourceConfig{
|
|
CDNURL: server.URL,
|
|
ImageName: "test.img",
|
|
})
|
|
|
|
// nil progress callback should be handled gracefully
|
|
err := src.Download(context.Background(), dest, nil)
|
|
assert.NoError(t, err)
|
|
|
|
data, err := os.ReadFile(filepath.Join(dest, "test.img"))
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, content, string(data))
|
|
}
|
|
|
|
func TestCDNSource_Download_Good_LargeFile(t *testing.T) {
|
|
// Create content larger than buffer size (32KB)
|
|
content := make([]byte, 64*1024) // 64KB
|
|
for i := range content {
|
|
content[i] = byte(i % 256)
|
|
}
|
|
|
|
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
w.Header().Set("Content-Length", fmt.Sprintf("%d", len(content)))
|
|
w.WriteHeader(http.StatusOK)
|
|
_, _ = w.Write(content)
|
|
}))
|
|
defer server.Close()
|
|
|
|
dest := t.TempDir()
|
|
src := NewCDNSource(SourceConfig{
|
|
CDNURL: server.URL,
|
|
ImageName: "large.img",
|
|
})
|
|
|
|
var progressCalls int
|
|
var lastDownloaded int64
|
|
err := src.Download(context.Background(), dest, func(downloaded, total int64) {
|
|
progressCalls++
|
|
lastDownloaded = downloaded
|
|
})
|
|
|
|
assert.NoError(t, err)
|
|
assert.Greater(t, progressCalls, 1) // Should be called multiple times for large file
|
|
assert.Equal(t, int64(len(content)), lastDownloaded)
|
|
}
|
|
|
|
func TestCDNSource_Download_Bad_HTTPErrorCodes(t *testing.T) {
|
|
testCases := []struct {
|
|
name string
|
|
statusCode int
|
|
}{
|
|
{"Bad Request", http.StatusBadRequest},
|
|
{"Unauthorized", http.StatusUnauthorized},
|
|
{"Forbidden", http.StatusForbidden},
|
|
{"Not Found", http.StatusNotFound},
|
|
{"Service Unavailable", http.StatusServiceUnavailable},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
w.WriteHeader(tc.statusCode)
|
|
}))
|
|
defer server.Close()
|
|
|
|
dest := t.TempDir()
|
|
src := NewCDNSource(SourceConfig{
|
|
CDNURL: server.URL,
|
|
ImageName: "test.img",
|
|
})
|
|
|
|
err := src.Download(context.Background(), dest, nil)
|
|
assert.Error(t, err)
|
|
assert.Contains(t, err.Error(), fmt.Sprintf("HTTP %d", tc.statusCode))
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestCDNSource_InterfaceCompliance(t *testing.T) {
|
|
// Verify CDNSource implements ImageSource
|
|
var _ ImageSource = (*CDNSource)(nil)
|
|
}
|
|
|
|
func TestCDNSource_Config(t *testing.T) {
|
|
cfg := SourceConfig{
|
|
CDNURL: "https://cdn.example.com",
|
|
ImageName: "my-image.qcow2",
|
|
}
|
|
src := NewCDNSource(cfg)
|
|
|
|
assert.Equal(t, "https://cdn.example.com", src.config.CDNURL)
|
|
assert.Equal(t, "my-image.qcow2", src.config.ImageName)
|
|
}
|
|
|
|
func TestNewCDNSource_Good(t *testing.T) {
|
|
cfg := SourceConfig{
|
|
GitHubRepo: "host-uk/core-images",
|
|
RegistryImage: "ghcr.io/host-uk/core-devops",
|
|
CDNURL: "https://cdn.example.com",
|
|
ImageName: "core-devops-darwin-arm64.qcow2",
|
|
}
|
|
|
|
src := NewCDNSource(cfg)
|
|
assert.NotNil(t, src)
|
|
assert.Equal(t, "cdn", src.Name())
|
|
assert.Equal(t, cfg.CDNURL, src.config.CDNURL)
|
|
}
|
|
|
|
func TestCDNSource_Download_Good_CreatesDestDir(t *testing.T) {
|
|
content := "test content"
|
|
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
w.WriteHeader(http.StatusOK)
|
|
_, _ = fmt.Fprint(w, content)
|
|
}))
|
|
defer server.Close()
|
|
|
|
tmpDir := t.TempDir()
|
|
dest := filepath.Join(tmpDir, "nested", "dir")
|
|
// dest doesn't exist yet
|
|
|
|
src := NewCDNSource(SourceConfig{
|
|
CDNURL: server.URL,
|
|
ImageName: "test.img",
|
|
})
|
|
|
|
err := src.Download(context.Background(), dest, nil)
|
|
assert.NoError(t, err)
|
|
|
|
// Verify nested dir was created
|
|
info, err := os.Stat(dest)
|
|
assert.NoError(t, err)
|
|
assert.True(t, info.IsDir())
|
|
}
|
|
|
|
func TestSourceConfig_Struct(t *testing.T) {
|
|
cfg := SourceConfig{
|
|
GitHubRepo: "owner/repo",
|
|
RegistryImage: "ghcr.io/owner/image",
|
|
CDNURL: "https://cdn.example.com",
|
|
ImageName: "image.qcow2",
|
|
}
|
|
|
|
assert.Equal(t, "owner/repo", cfg.GitHubRepo)
|
|
assert.Equal(t, "ghcr.io/owner/image", cfg.RegistryImage)
|
|
assert.Equal(t, "https://cdn.example.com", cfg.CDNURL)
|
|
assert.Equal(t, "image.qcow2", cfg.ImageName)
|
|
}
|