From 0697d43aba64ef2819d6cea6d6bbeb003b771b2e Mon Sep 17 00:00:00 2001 From: Michael Bolin Date: Wed, 11 Feb 2026 10:19:29 -0800 Subject: [PATCH] feat: remove "cargo check individual crates" from CI (#11475) I think this check has outlived its usefulness. It is often one of the last CI jobs to finish when we put up a PR, so this should save us some time. --- .github/workflows/rust-ci.yml | 23 ----------------------- 1 file changed, 23 deletions(-) diff --git a/.github/workflows/rust-ci.yml b/.github/workflows/rust-ci.yml index b6a3c50e1..72ce00522 100644 --- a/.github/workflows/rust-ci.yml +++ b/.github/workflows/rust-ci.yml @@ -379,22 +379,8 @@ jobs: cargo chef cook --recipe-path "$RECIPE" --target ${{ matrix.target }} --release --all-features - name: cargo clippy - id: clippy run: cargo clippy --target ${{ matrix.target }} --all-features --tests --profile ${{ matrix.profile }} -- -D warnings - # Running `cargo build` from the workspace root builds the workspace using - # the union of all features from third-party crates. This can mask errors - # where individual crates have underspecified features. To avoid this, we - # run `cargo check` for each crate individually, though because this is - # slower, we only do this for the x86_64-unknown-linux-gnu target. - - name: cargo check individual crates - id: cargo_check_all_crates - if: ${{ matrix.target == 'x86_64-unknown-linux-gnu' && matrix.profile != 'release' }} - continue-on-error: true - run: | - find . -name Cargo.toml -mindepth 2 -maxdepth 2 -print0 \ - | xargs -0 -n1 -I{} bash -c 'cd "$(dirname "{}")" && cargo check --profile ${{ matrix.profile }}' - # Save caches explicitly; make non-fatal so cache packaging # never fails the overall job. Only save when key wasn't hit. - name: Save cargo home cache @@ -447,15 +433,6 @@ jobs: /var/cache/apt key: apt-${{ matrix.runner }}-${{ matrix.target }}-v1 - # Fail the job if any of the previous steps failed. - - name: verify all steps passed - if: | - steps.clippy.outcome == 'failure' || - steps.cargo_check_all_crates.outcome == 'failure' - run: | - echo "One or more checks failed (clippy or cargo_check_all_crates). See logs for details." - exit 1 - tests: name: Tests — ${{ matrix.runner }} - ${{ matrix.target }} runs-on: ${{ matrix.runs_on || matrix.runner }}