core/core-agent-ide
8
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

nit: drop dead branch with unified_exec tool (#8182)

Browse source
This commit is contained in:
jif-oai 2025-12-17 13:55:13 +00:00 • committed by GitHub
parent 0abaf1b57c
commit 2e7e4f6ea6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 7 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
codex-rs/core/src/tools/context.rs
View file

@ -37,9 +37,6 @@ pub enum ToolPayload {
LocalShell {
params: ShellToolCallParams,
},
UnifiedExec {
arguments: String,
},
Mcp {
server: String,
tool: String,
@ -53,7 +50,6 @@ impl ToolPayload {
ToolPayload::Function { arguments } => Cow::Borrowed(arguments),
ToolPayload::Custom { input } => Cow::Borrowed(input),
ToolPayload::LocalShell { params } => Cow::Owned(params.command.join(" ")),
ToolPayload::UnifiedExec { arguments } => Cow::Borrowed(arguments),
ToolPayload::Mcp { raw_arguments, .. } => Cow::Borrowed(raw_arguments),
}
}

14
codex-rs/core/src/tools/handlers/unified_exec.rs
View file

@ -77,16 +77,15 @@ impl ToolHandler for UnifiedExecHandler {
}
fn matches_kind(&self, payload: &ToolPayload) -> bool {
matches!(
payload,
ToolPayload::Function { .. } | ToolPayload::UnifiedExec { .. }
)
matches!(payload, ToolPayload::Function { .. })
}
async fn is_mutating(&self, invocation: &ToolInvocation) -> bool {
let (ToolPayload::Function { arguments } | ToolPayload::UnifiedExec { arguments }) =
&invocation.payload
else {
let ToolPayload::Function { arguments } = &invocation.payload else {
tracing::error!(
"This should never happen, invocation payload is wrong: {:?}",
invocation.payload
);
return true;
};
@ -110,7 +109,6 @@ impl ToolHandler for UnifiedExecHandler {
let arguments = match payload {
ToolPayload::Function { arguments } => arguments,
ToolPayload::UnifiedExec { arguments } => arguments,
_ => {
return Err(FunctionCallError::RespondToModel(
"unified_exec handler received unsupported payload".to_string(),

7
codex-rs/core/src/tools/router.rs
View file

@ -78,15 +78,10 @@ impl ToolRouter {
},
}))
} else {
let payload = if name == "unified_exec" {
ToolPayload::UnifiedExec { arguments }
} else {
ToolPayload::Function { arguments }
};
Ok(Some(ToolCall {
tool_name: name,
call_id,
payload,
payload: ToolPayload::Function { arguments },
}))
}
}