core/core-agent-ide
8
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat: panic if Constrained<WebSearchMode> does not support Disabled (#11470)

Browse source 
If this happens, this is a logical error on our part and we should fix
it.
This commit is contained in:
Michael Bolin 2026-02-11 10:18:58 -08:00 • committed by GitHub
parent 7053aa5457
commit 3a9324707d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
codex-rs/core/src/tasks/review.rs
View file

@ -17,7 +17,6 @@ use tokio_util::sync::CancellationToken;
use crate::codex::Session;
use crate::codex::TurnContext;
use crate::codex_delegate::run_codex_thread_one_shot;
use crate::config::Constrained;
use crate::review_format::format_review_findings_block;
use crate::review_format::render_review_output_text;
use crate::state::TaskKind;
@ -91,15 +90,7 @@ async fn start_review_conversation(
.web_search_mode
.set(WebSearchMode::Disabled)
{
tracing::warn!(
"failed to force review web_search_mode=disabled; falling back to a normalizer: {err}"
);
sub_agent_config.web_search_mode =
Constrained::normalized(WebSearchMode::Disabled, |_| WebSearchMode::Disabled)
.unwrap_or_else(|err| {
tracing::warn!("failed to build normalizer for review web_search_mode: {err}");
Constrained::allow_any(WebSearchMode::Disabled)
});
panic!("by construction Constrained<WebSearchMode> must always support Disabled: {err}");
}
// Set explicit review rubric for the sub-agent