From 412dd379562fefdf59ae80d66581c317d291e647 Mon Sep 17 00:00:00 2001 From: Owen Lin Date: Mon, 15 Dec 2025 17:11:01 -0800 Subject: [PATCH] chore(app-server): remove stubbed thread/compact API (#8086) We want to rely on server-side auto-compaction instead of having the client trigger context compaction manually. This API was stubbed as a placeholder and never implemented. --- .../app-server-protocol/src/protocol/common.rs | 4 ---- codex-rs/app-server-protocol/src/protocol/v2.rs | 12 ------------ .../app-server/src/codex_message_processor.rs | 16 ---------------- 3 files changed, 32 deletions(-) diff --git a/codex-rs/app-server-protocol/src/protocol/common.rs b/codex-rs/app-server-protocol/src/protocol/common.rs index 6e5f46930..dca9f03e7 100644 --- a/codex-rs/app-server-protocol/src/protocol/common.rs +++ b/codex-rs/app-server-protocol/src/protocol/common.rs @@ -117,10 +117,6 @@ client_request_definitions! { params: v2::ThreadListParams, response: v2::ThreadListResponse, }, - ThreadCompact => "thread/compact" { - params: v2::ThreadCompactParams, - response: v2::ThreadCompactResponse, - }, SkillsList => "skills/list" { params: v2::SkillsListParams, response: v2::SkillsListResponse, diff --git a/codex-rs/app-server-protocol/src/protocol/v2.rs b/codex-rs/app-server-protocol/src/protocol/v2.rs index 23dceae13..05362b204 100644 --- a/codex-rs/app-server-protocol/src/protocol/v2.rs +++ b/codex-rs/app-server-protocol/src/protocol/v2.rs @@ -958,18 +958,6 @@ pub struct ThreadListResponse { pub next_cursor: Option, } -#[derive(Serialize, Deserialize, Debug, Clone, PartialEq, JsonSchema, TS)] -#[serde(rename_all = "camelCase")] -#[ts(export_to = "v2/")] -pub struct ThreadCompactParams { - pub thread_id: String, -} - -#[derive(Serialize, Deserialize, Debug, Clone, PartialEq, JsonSchema, TS)] -#[serde(rename_all = "camelCase")] -#[ts(export_to = "v2/")] -pub struct ThreadCompactResponse {} - #[derive(Serialize, Deserialize, Debug, Clone, PartialEq, JsonSchema, TS)] #[serde(rename_all = "camelCase")] #[ts(export_to = "v2/")] diff --git a/codex-rs/app-server/src/codex_message_processor.rs b/codex-rs/app-server/src/codex_message_processor.rs index 627b84b09..d017d2294 100644 --- a/codex-rs/app-server/src/codex_message_processor.rs +++ b/codex-rs/app-server/src/codex_message_processor.rs @@ -368,13 +368,6 @@ impl CodexMessageProcessor { ClientRequest::ThreadList { request_id, params } => { self.thread_list(request_id, params).await; } - ClientRequest::ThreadCompact { - request_id, - params: _, - } => { - self.send_unimplemented_error(request_id, "thread/compact") - .await; - } ClientRequest::SkillsList { request_id, params } => { self.skills_list(request_id, params).await; } @@ -515,15 +508,6 @@ impl CodexMessageProcessor { } } - async fn send_unimplemented_error(&self, request_id: RequestId, method: &str) { - let error = JSONRPCErrorError { - code: INTERNAL_ERROR_CODE, - message: format!("{method} is not implemented yet"), - data: None, - }; - self.outgoing.send_error(request_id, error).await; - } - async fn login_v2(&mut self, request_id: RequestId, params: LoginAccountParams) { match params { LoginAccountParams::ApiKey { api_key } => {