From 5571a022ebcc060a0da855028df3374997e498a9 Mon Sep 17 00:00:00 2001 From: pakrym-oai Date: Tue, 24 Feb 2026 14:45:50 -0800 Subject: [PATCH] Add app-server event tracing (#12695) To help with debugging --- codex-rs/app-server/src/codex_message_processor.rs | 7 ++++++- codex-rs/app-server/src/message_processor.rs | 6 ++++++ codex-rs/app-server/src/outgoing_message.rs | 4 ++++ 3 files changed, 16 insertions(+), 1 deletion(-) diff --git a/codex-rs/app-server/src/codex_message_processor.rs b/codex-rs/app-server/src/codex_message_processor.rs index a868b2d41..2d18ff7a5 100644 --- a/codex-rs/app-server/src/codex_message_processor.rs +++ b/codex-rs/app-server/src/codex_message_processor.rs @@ -5899,6 +5899,11 @@ impl CodexMessageProcessor { EventMsg::TurnComplete(_) => "task_complete", _ => &event.msg.to_string(), }; + let request_event_name = format!("codex/event/{event_formatted}"); + tracing::trace!( + conversation_id = %conversation_id, + "app-server event: {request_event_name}" + ); let mut params = match serde_json::to_value(event.clone()) { Ok(serde_json::Value::Object(map)) => map, Ok(_) => { @@ -5933,7 +5938,7 @@ impl CodexMessageProcessor { .send_notification_to_connections( &subscribed_connection_ids, OutgoingNotification { - method: format!("codex/event/{event_formatted}"), + method: request_event_name, params: Some(params.into()), }, ) diff --git a/codex-rs/app-server/src/message_processor.rs b/codex-rs/app-server/src/message_processor.rs index de4418f0e..18d6a121e 100644 --- a/codex-rs/app-server/src/message_processor.rs +++ b/codex-rs/app-server/src/message_processor.rs @@ -213,6 +213,12 @@ impl MessageProcessor { session: &mut ConnectionSessionState, outbound_initialized: &AtomicBool, ) { + let request_method = request.method.as_str(); + tracing::trace!( + ?connection_id, + request_id = ?request.id, + "app-server request: {request_method}" + ); let request_id = ConnectionRequestId { connection_id, request_id: request.id.clone(), diff --git a/codex-rs/app-server/src/outgoing_message.rs b/codex-rs/app-server/src/outgoing_message.rs index 810182db0..fe8f75588 100644 --- a/codex-rs/app-server/src/outgoing_message.rs +++ b/codex-rs/app-server/src/outgoing_message.rs @@ -275,6 +275,10 @@ impl OutgoingMessageSender { connection_ids: &[ConnectionId], notification: ServerNotification, ) { + tracing::trace!( + targeted_connections = connection_ids.len(), + "app-server event: {notification}" + ); let outgoing_message = OutgoingMessage::AppServerNotification(notification); if connection_ids.is_empty() { if let Err(err) = self