core/core-agent-ide
8
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove unused conversation_id header (#9107)

Browse source 
It's an exact copy of session_id
This commit is contained in:
pakrym-oai 2026-01-12 13:01:07 -08:00 • committed by GitHub
parent 3e91a95ce1
commit 5dfa780f3d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 7 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
codex-rs/codex-api/src/requests/chat.rs
View file

@ -393,10 +393,6 @@ mod tests {
.build(&provider())
.expect("request");
assert_eq!(
req.headers.get("conversation_id"),
Some(&HeaderValue::from_static("conv-1"))
);
assert_eq!(
req.headers.get("session_id"),
Some(&HeaderValue::from_static("conv-1"))

1
codex-rs/codex-api/src/requests/headers.rs
View file

@ -5,7 +5,6 @@ use http::HeaderValue;
pub(crate) fn build_conversation_headers(conversation_id: Option<String>) -> HeaderMap {
let mut headers = HeaderMap::new();
if let Some(id) = conversation_id {
insert_header(&mut headers, "conversation_id", &id);
insert_header(&mut headers, "session_id", &id);
}
headers

4
codex-rs/codex-api/src/requests/responses.rs
View file

@ -249,10 +249,6 @@ mod tests {
.collect();
assert_eq!(ids, vec![Some("m1".to_string()), None]);
assert_eq!(
request.headers.get("conversation_id"),
Some(&HeaderValue::from_static("conv-1"))
);
assert_eq!(
request.headers.get("session_id"),
Some(&HeaderValue::from_static("conv-1"))

17
codex-rs/core/tests/suite/client.rs
View file

@ -344,7 +344,7 @@ async fn includes_conversation_id_and_model_headers_in_request() {
);
let NewThread {
thread: codex,
thread_id: conversation_id,
thread_id: session_id,
session_configured: _,
..
} = thread_manager
@ -366,15 +366,13 @@ async fn includes_conversation_id_and_model_headers_in_request() {
let request = resp_mock.single_request();
assert_eq!(request.path(), "/v1/responses");
let request_conversation_id = request
.header("conversation_id")
.expect("conversation_id header");
let request_session_id = request.header("session_id").expect("session_id header");
let request_authorization = request
.header("authorization")
.expect("authorization header");
let request_originator = request.header("originator").expect("originator header");
assert_eq!(request_conversation_id, conversation_id.to_string());
assert_eq!(request_session_id, session_id.to_string());
assert_eq!(request_originator, "codex_cli_rs");
assert_eq!(request_authorization, "Bearer Test API Key");
}
@ -455,7 +453,7 @@ async fn chatgpt_auth_sends_correct_request() {
);
let NewThread {
thread: codex,
thread_id: conversation_id,
thread_id,
session_configured: _,
..
} = thread_manager
@ -477,9 +475,6 @@ async fn chatgpt_auth_sends_correct_request() {
let request = resp_mock.single_request();
assert_eq!(request.path(), "/api/codex/responses");
let request_conversation_id = request
.header("conversation_id")
.expect("conversation_id header");
let request_authorization = request
.header("authorization")
.expect("authorization header");
@ -489,7 +484,9 @@ async fn chatgpt_auth_sends_correct_request() {
.expect("chatgpt-account-id header");
let request_body = request.body_json();
assert_eq!(request_conversation_id, conversation_id.to_string());
let session_id = request.header("session_id").expect("session_id header");
assert_eq!(session_id, thread_id.to_string());
assert_eq!(request_originator, "codex_cli_rs");
assert_eq!(request_authorization, "Bearer Access Token");
assert_eq!(request_chatgpt_account_id, "account_id");