fix: more stable notify script (#13011)
This commit is contained in:
parent
fe439afb81
commit
8cf5b00aef
2 changed files with 8 additions and 6 deletions
|
|
@ -197,7 +197,10 @@ async fn turn_start_notify_payload_includes_initialize_client_name() -> Result<(
|
|||
r#"from pathlib import Path
|
||||
import sys
|
||||
|
||||
Path(__file__).with_name("notify.json").write_text(sys.argv[-1], encoding="utf-8")
|
||||
payload_path = Path(__file__).with_name("notify.json")
|
||||
tmp_path = payload_path.with_suffix(".json.tmp")
|
||||
tmp_path.write_text(sys.argv[-1], encoding="utf-8")
|
||||
tmp_path.replace(payload_path)
|
||||
"#,
|
||||
)?;
|
||||
let notify_file = codex_home.path().join("notify.json");
|
||||
|
|
|
|||
|
|
@ -23,10 +23,6 @@ use responses::start_mock_server;
|
|||
use std::time::Duration;
|
||||
|
||||
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
|
||||
#[ignore = "flaky on ubuntu-24.04-arm - aarch64-unknown-linux-gnu"]
|
||||
// The notify script gets far enough to create (and therefore surface) the file,
|
||||
// but hasn’t flushed the JSON yet. Reading an empty file produces EOF while parsing
|
||||
// a value at line 1 column 0. May be caused by a slow runner.
|
||||
async fn summarize_context_three_requests_and_instructions() -> anyhow::Result<()> {
|
||||
skip_if_no_network!(Ok(()));
|
||||
|
||||
|
|
@ -43,7 +39,10 @@ async fn summarize_context_three_requests_and_instructions() -> anyhow::Result<(
|
|||
¬ify_script,
|
||||
r#"#!/bin/bash
|
||||
set -e
|
||||
echo -n "${@: -1}" > $(dirname "${0}")/notify.txt"#,
|
||||
payload_path="$(dirname "${0}")/notify.txt"
|
||||
tmp_path="${payload_path}.tmp"
|
||||
echo -n "${@: -1}" > "${tmp_path}"
|
||||
mv "${tmp_path}" "${payload_path}""#,
|
||||
)?;
|
||||
std::fs::set_permissions(¬ify_script, std::fs::Permissions::from_mode(0o755))?;
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Reference in a new issue