From 95f7d37ec68bb54cc6bae29566dca8103b788699 Mon Sep 17 00:00:00 2001 From: Victor Vannara Date: Thu, 11 Dec 2025 16:38:52 -0800 Subject: [PATCH] Fix misleading 'maximize' high effort description on xhigh models (#7874) ## Notes - switch misleading High reasoning effort descriptions from "Maximizes reasoning depth" to "Higher reasoning depth" across models with xhigh reasoning. Affects GPT-5.1 Codex Max and Robin - refresh model list fixtures and chatwidget snapshots to match new copy ## Revision - R2: Change 'Higher' to 'Greater' - R1: Initial ## Testing image image --- codex-rs/app-server/tests/suite/v2/model_list.rs | 4 ++-- codex-rs/core/src/openai_models/model_presets.rs | 4 ++-- codex-rs/core/tests/suite/list_models.rs | 4 ++-- ...i__chatwidget__tests__model_reasoning_selection_popup.snap | 2 +- ...s__model_reasoning_selection_popup_extra_high_warning.snap | 2 +- codex-rs/tui/src/chatwidget/tests.rs | 2 +- ...2__chatwidget__tests__model_reasoning_selection_popup.snap | 2 +- ...s__model_reasoning_selection_popup_extra_high_warning.snap | 2 +- ...i__chatwidget__tests__model_reasoning_selection_popup.snap | 2 +- ...s__model_reasoning_selection_popup_extra_high_warning.snap | 2 +- 10 files changed, 13 insertions(+), 13 deletions(-) diff --git a/codex-rs/app-server/tests/suite/v2/model_list.rs b/codex-rs/app-server/tests/suite/v2/model_list.rs index eb9d0c32c..b406eda3f 100644 --- a/codex-rs/app-server/tests/suite/v2/model_list.rs +++ b/codex-rs/app-server/tests/suite/v2/model_list.rs @@ -64,7 +64,7 @@ async fn list_models_returns_all_models_with_large_limit() -> Result<()> { }, ReasoningEffortOption { reasoning_effort: ReasoningEffort::High, - description: "Maximizes reasoning depth for complex problems".to_string(), + description: "Greater reasoning depth for complex problems".to_string(), }, ReasoningEffortOption { reasoning_effort: ReasoningEffort::XHigh, @@ -138,7 +138,7 @@ async fn list_models_returns_all_models_with_large_limit() -> Result<()> { }, ReasoningEffortOption { reasoning_effort: ReasoningEffort::High, - description: "Maximizes reasoning depth for complex or ambiguous problems" + description: "Greater reasoning depth for complex or ambiguous problems" .to_string(), }, ReasoningEffortOption { diff --git a/codex-rs/core/src/openai_models/model_presets.rs b/codex-rs/core/src/openai_models/model_presets.rs index 42a5557f4..cf635e8da 100644 --- a/codex-rs/core/src/openai_models/model_presets.rs +++ b/codex-rs/core/src/openai_models/model_presets.rs @@ -28,7 +28,7 @@ static PRESETS: Lazy> = Lazy::new(|| { }, ReasoningEffortPreset { effort: ReasoningEffort::High, - description: "Maximizes reasoning depth for complex problems".to_string(), + description: "Greater reasoning depth for complex problems".to_string(), }, ReasoningEffortPreset { effort: ReasoningEffort::XHigh, @@ -110,7 +110,7 @@ static PRESETS: Lazy> = Lazy::new(|| { }, ReasoningEffortPreset { effort: ReasoningEffort::High, - description: "Maximizes reasoning depth for complex or ambiguous problems".to_string(), + description: "Greater reasoning depth for complex or ambiguous problems".to_string(), }, ReasoningEffortPreset { effort: ReasoningEffort::XHigh, diff --git a/codex-rs/core/tests/suite/list_models.rs b/codex-rs/core/tests/suite/list_models.rs index 9cfd9b267..b62fdfe9a 100644 --- a/codex-rs/core/tests/suite/list_models.rs +++ b/codex-rs/core/tests/suite/list_models.rs @@ -79,7 +79,7 @@ fn gpt_5_1_codex_max() -> ModelPreset { ), effort( ReasoningEffort::High, - "Maximizes reasoning depth for complex problems", + "Greater reasoning depth for complex problems", ), effort( ReasoningEffort::XHigh, @@ -162,7 +162,7 @@ fn gpt_5_2() -> ModelPreset { ), effort( ReasoningEffort::High, - "Maximizes reasoning depth for complex or ambiguous problems", + "Greater reasoning depth for complex or ambiguous problems", ), effort( ReasoningEffort::XHigh, diff --git a/codex-rs/tui/src/chatwidget/snapshots/codex_tui__chatwidget__tests__model_reasoning_selection_popup.snap b/codex-rs/tui/src/chatwidget/snapshots/codex_tui__chatwidget__tests__model_reasoning_selection_popup.snap index b4b89736a..a4a86a41b 100644 --- a/codex-rs/tui/src/chatwidget/snapshots/codex_tui__chatwidget__tests__model_reasoning_selection_popup.snap +++ b/codex-rs/tui/src/chatwidget/snapshots/codex_tui__chatwidget__tests__model_reasoning_selection_popup.snap @@ -6,7 +6,7 @@ expression: popup 1. Low Fast responses with lighter reasoning 2. Medium (default) Balances speed and reasoning depth for everyday tasks -› 3. High (current) Maximizes reasoning depth for complex problems +› 3. High (current) Greater reasoning depth for complex problems 4. Extra high Extra high reasoning depth for complex problems Press enter to confirm or esc to go back diff --git a/codex-rs/tui/src/chatwidget/snapshots/codex_tui__chatwidget__tests__model_reasoning_selection_popup_extra_high_warning.snap b/codex-rs/tui/src/chatwidget/snapshots/codex_tui__chatwidget__tests__model_reasoning_selection_popup_extra_high_warning.snap index c5332ff59..3eb172c10 100644 --- a/codex-rs/tui/src/chatwidget/snapshots/codex_tui__chatwidget__tests__model_reasoning_selection_popup_extra_high_warning.snap +++ b/codex-rs/tui/src/chatwidget/snapshots/codex_tui__chatwidget__tests__model_reasoning_selection_popup_extra_high_warning.snap @@ -8,7 +8,7 @@ expression: popup 1. Low Fast responses with lighter reasoning 2. Medium (default) Balances speed and reasoning depth for everyday tasks - 3. High Maximizes reasoning depth for complex problems + 3. High Greater reasoning depth for complex problems › 4. Extra high (current) Extra high reasoning depth for complex problems ⚠ Extra high reasoning effort can quickly consume Plus plan rate limits. diff --git a/codex-rs/tui/src/chatwidget/tests.rs b/codex-rs/tui/src/chatwidget/tests.rs index bd85a9edc..65f6708c9 100644 --- a/codex-rs/tui/src/chatwidget/tests.rs +++ b/codex-rs/tui/src/chatwidget/tests.rs @@ -1930,7 +1930,7 @@ fn single_reasoning_option_skips_selection() { let single_effort = vec![ReasoningEffortPreset { effort: ReasoningEffortConfig::High, - description: "Maximizes reasoning depth for complex or ambiguous problems".to_string(), + description: "Greater reasoning depth for complex or ambiguous problems".to_string(), }]; let preset = ModelPreset { id: "model-with-single-reasoning".to_string(), diff --git a/codex-rs/tui2/src/chatwidget/snapshots/codex_tui2__chatwidget__tests__model_reasoning_selection_popup.snap b/codex-rs/tui2/src/chatwidget/snapshots/codex_tui2__chatwidget__tests__model_reasoning_selection_popup.snap index cbf5f0fb5..86c748d59 100644 --- a/codex-rs/tui2/src/chatwidget/snapshots/codex_tui2__chatwidget__tests__model_reasoning_selection_popup.snap +++ b/codex-rs/tui2/src/chatwidget/snapshots/codex_tui2__chatwidget__tests__model_reasoning_selection_popup.snap @@ -6,7 +6,7 @@ expression: popup 1. Low Fast responses with lighter reasoning 2. Medium (default) Balances speed and reasoning depth for everyday tasks -› 3. High (current) Maximizes reasoning depth for complex problems +› 3. High (current) Greater reasoning depth for complex problems 4. Extra high Extra high reasoning depth for complex problems Press enter to confirm or esc to go back diff --git a/codex-rs/tui2/src/chatwidget/snapshots/codex_tui2__chatwidget__tests__model_reasoning_selection_popup_extra_high_warning.snap b/codex-rs/tui2/src/chatwidget/snapshots/codex_tui2__chatwidget__tests__model_reasoning_selection_popup_extra_high_warning.snap index ed6c6fee1..4d1d62d93 100644 --- a/codex-rs/tui2/src/chatwidget/snapshots/codex_tui2__chatwidget__tests__model_reasoning_selection_popup_extra_high_warning.snap +++ b/codex-rs/tui2/src/chatwidget/snapshots/codex_tui2__chatwidget__tests__model_reasoning_selection_popup_extra_high_warning.snap @@ -7,7 +7,7 @@ expression: popup 1. Low Fast responses with lighter reasoning 2. Medium (default) Balances speed and reasoning depth for everyday tasks - 3. High Maximizes reasoning depth for complex problems + 3. High Greater reasoning depth for complex problems › 4. Extra high (current) Extra high reasoning depth for complex problems ⚠ Extra high reasoning effort can quickly consume Plus plan rate limits. diff --git a/codex-rs/tui2/src/chatwidget/snapshots/codex_tui__chatwidget__tests__model_reasoning_selection_popup.snap b/codex-rs/tui2/src/chatwidget/snapshots/codex_tui__chatwidget__tests__model_reasoning_selection_popup.snap index b4b89736a..a4a86a41b 100644 --- a/codex-rs/tui2/src/chatwidget/snapshots/codex_tui__chatwidget__tests__model_reasoning_selection_popup.snap +++ b/codex-rs/tui2/src/chatwidget/snapshots/codex_tui__chatwidget__tests__model_reasoning_selection_popup.snap @@ -6,7 +6,7 @@ expression: popup 1. Low Fast responses with lighter reasoning 2. Medium (default) Balances speed and reasoning depth for everyday tasks -› 3. High (current) Maximizes reasoning depth for complex problems +› 3. High (current) Greater reasoning depth for complex problems 4. Extra high Extra high reasoning depth for complex problems Press enter to confirm or esc to go back diff --git a/codex-rs/tui2/src/chatwidget/snapshots/codex_tui__chatwidget__tests__model_reasoning_selection_popup_extra_high_warning.snap b/codex-rs/tui2/src/chatwidget/snapshots/codex_tui__chatwidget__tests__model_reasoning_selection_popup_extra_high_warning.snap index c5332ff59..3eb172c10 100644 --- a/codex-rs/tui2/src/chatwidget/snapshots/codex_tui__chatwidget__tests__model_reasoning_selection_popup_extra_high_warning.snap +++ b/codex-rs/tui2/src/chatwidget/snapshots/codex_tui__chatwidget__tests__model_reasoning_selection_popup_extra_high_warning.snap @@ -8,7 +8,7 @@ expression: popup 1. Low Fast responses with lighter reasoning 2. Medium (default) Balances speed and reasoning depth for everyday tasks - 3. High Maximizes reasoning depth for complex problems + 3. High Greater reasoning depth for complex problems › 4. Extra high (current) Extra high reasoning depth for complex problems ⚠ Extra high reasoning effort can quickly consume Plus plan rate limits.