core/core-agent-ide
8
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

better name for windows sandbox features (#8077)

Browse source 
`--enable enable...` is a bad look
This commit is contained in:
iceweasel-oai 2025-12-15 10:15:40 -08:00 • committed by GitHub
parent 017a4a06b2
commit b4635ccc07
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
codex-rs/app-server/src/codex_message_processor.rs
View file

@ -1270,7 +1270,7 @@ impl CodexMessageProcessor {
let mut cli_overrides = cli_overrides.unwrap_or_default();
if cfg!(windows) && self.config.features.enabled(Feature::WindowsSandbox) {
cli_overrides.insert(
"features.enable_experimental_windows_sandbox".to_string(),
"features.experimental_windows_sandbox".to_string(),
serde_json::json!(true),
);
}
@ -2187,7 +2187,7 @@ impl CodexMessageProcessor {
let mut cli_overrides = cli_overrides.unwrap_or_default();
if cfg!(windows) && self.config.features.enabled(Feature::WindowsSandbox) {
cli_overrides.insert(
"features.enable_experimental_windows_sandbox".to_string(),
"features.experimental_windows_sandbox".to_string(),
serde_json::json!(true),
);
}

4
codex-rs/core/src/features.rs
View file

@ -325,13 +325,13 @@ pub const FEATURES: &[FeatureSpec] = &[
},
FeatureSpec {
id: Feature::WindowsSandbox,
key: "enable_experimental_windows_sandbox",
key: "experimental_windows_sandbox",
stage: Stage::Experimental,
default_enabled: false,
},
FeatureSpec {
id: Feature::WindowsSandboxElevated,
key: "enable_elevated_windows_sandbox",
key: "elevated_windows_sandbox",
stage: Stage::Experimental,
default_enabled: false,
},

4
codex-rs/core/src/features/legacy.rs
View file

@ -9,6 +9,10 @@ struct Alias {
}
const ALIASES: &[Alias] = &[
Alias {
legacy_key: "enable_experimental_windows_sandbox",
feature: Feature::WindowsSandbox,
},
Alias {
legacy_key: "experimental_use_unified_exec_tool",
feature: Feature::UnifiedExec,

2
codex-rs/core/src/sandboxing/mod.rs
View file

@ -81,7 +81,7 @@ impl SandboxManager {
SandboxablePreference::Forbid => SandboxType::None,
SandboxablePreference::Require => {
// Require a platform sandbox when available; on Windows this
// respects the enable_experimental_windows_sandbox feature.
// respects the experimental_windows_sandbox feature.
crate::safety::get_platform_sandbox().unwrap_or(SandboxType::None)
}
SandboxablePreference::Auto => match policy {