From cea76b85af2dc752189cdc961339486bd1d99fe4 Mon Sep 17 00:00:00 2001 From: jif-oai Date: Thu, 18 Dec 2025 10:34:10 +0000 Subject: [PATCH] nit: ui background terminals (#8255) --- ...c_footer__tests__render_more_sessions.snap | 24 +++++++++++-------- ...ec_footer__tests__render_two_sessions.snap | 19 ++++++++------- .../src/bottom_pane/unified_exec_footer.rs | 2 +- 3 files changed, 25 insertions(+), 20 deletions(-) diff --git a/codex-rs/tui/src/bottom_pane/snapshots/codex_tui__bottom_pane__unified_exec_footer__tests__render_more_sessions.snap b/codex-rs/tui/src/bottom_pane/snapshots/codex_tui__bottom_pane__unified_exec_footer__tests__render_more_sessions.snap index 90bfa7600..1a58ed921 100644 --- a/codex-rs/tui/src/bottom_pane/snapshots/codex_tui__bottom_pane__unified_exec_footer__tests__render_more_sessions.snap +++ b/codex-rs/tui/src/bottom_pane/snapshots/codex_tui__bottom_pane__unified_exec_footer__tests__render_more_sessions.snap @@ -1,22 +1,26 @@ --- source: tui/src/bottom_pane/unified_exec_footer.rs +assertion_line: 123 expression: "format!(\"{buf:?}\")" --- Buffer { - area: Rect { x: 0, y: 0, width: 50, height: 2 }, + area: Rect { x: 0, y: 0, width: 50, height: 3 }, content: [ - "Background terminal running: echo hello · rg "foo"", - " src · 1 more running ", + " Background terminal running: echo hello · rg ", + " "foo" src · 1 more ", + " running ", ], styles: [ x: 0, y: 0, fg: Reset, bg: Reset, underline: Reset, modifier: DIM, - x: 28, y: 0, fg: Reset, bg: Reset, underline: Reset, modifier: NONE, - x: 29, y: 0, fg: Cyan, bg: Reset, underline: Reset, modifier: NONE, - x: 39, y: 0, fg: Reset, bg: Reset, underline: Reset, modifier: DIM, - x: 42, y: 0, fg: Cyan, bg: Reset, underline: Reset, modifier: NONE, - x: 0, y: 1, fg: Reset, bg: Reset, underline: Reset, modifier: NONE, - x: 29, y: 1, fg: Cyan, bg: Reset, underline: Reset, modifier: NONE, - x: 32, y: 1, fg: Reset, bg: Reset, underline: Reset, modifier: DIM, + x: 30, y: 0, fg: Reset, bg: Reset, underline: Reset, modifier: NONE, + x: 31, y: 0, fg: Cyan, bg: Reset, underline: Reset, modifier: NONE, + x: 41, y: 0, fg: Reset, bg: Reset, underline: Reset, modifier: DIM, + x: 44, y: 0, fg: Cyan, bg: Reset, underline: Reset, modifier: NONE, + x: 46, y: 0, fg: Reset, bg: Reset, underline: Reset, modifier: NONE, + x: 31, y: 1, fg: Cyan, bg: Reset, underline: Reset, modifier: NONE, + x: 40, y: 1, fg: Reset, bg: Reset, underline: Reset, modifier: DIM, x: 49, y: 1, fg: Reset, bg: Reset, underline: Reset, modifier: NONE, + x: 31, y: 2, fg: Reset, bg: Reset, underline: Reset, modifier: DIM, + x: 38, y: 2, fg: Reset, bg: Reset, underline: Reset, modifier: NONE, ] } diff --git a/codex-rs/tui/src/bottom_pane/snapshots/codex_tui__bottom_pane__unified_exec_footer__tests__render_two_sessions.snap b/codex-rs/tui/src/bottom_pane/snapshots/codex_tui__bottom_pane__unified_exec_footer__tests__render_two_sessions.snap index 0828a62ef..f3a4855bb 100644 --- a/codex-rs/tui/src/bottom_pane/snapshots/codex_tui__bottom_pane__unified_exec_footer__tests__render_two_sessions.snap +++ b/codex-rs/tui/src/bottom_pane/snapshots/codex_tui__bottom_pane__unified_exec_footer__tests__render_two_sessions.snap @@ -1,21 +1,22 @@ --- source: tui/src/bottom_pane/unified_exec_footer.rs +assertion_line: 108 expression: "format!(\"{buf:?}\")" --- Buffer { area: Rect { x: 0, y: 0, width: 50, height: 2 }, content: [ - "Background terminal running: echo hello · rg "foo"", - " src ", + " Background terminal running: echo hello · rg ", + " "foo" src ", ], styles: [ x: 0, y: 0, fg: Reset, bg: Reset, underline: Reset, modifier: DIM, - x: 28, y: 0, fg: Reset, bg: Reset, underline: Reset, modifier: NONE, - x: 29, y: 0, fg: Cyan, bg: Reset, underline: Reset, modifier: NONE, - x: 39, y: 0, fg: Reset, bg: Reset, underline: Reset, modifier: DIM, - x: 42, y: 0, fg: Cyan, bg: Reset, underline: Reset, modifier: NONE, - x: 0, y: 1, fg: Reset, bg: Reset, underline: Reset, modifier: NONE, - x: 29, y: 1, fg: Cyan, bg: Reset, underline: Reset, modifier: NONE, - x: 32, y: 1, fg: Reset, bg: Reset, underline: Reset, modifier: NONE, + x: 30, y: 0, fg: Reset, bg: Reset, underline: Reset, modifier: NONE, + x: 31, y: 0, fg: Cyan, bg: Reset, underline: Reset, modifier: NONE, + x: 41, y: 0, fg: Reset, bg: Reset, underline: Reset, modifier: DIM, + x: 44, y: 0, fg: Cyan, bg: Reset, underline: Reset, modifier: NONE, + x: 46, y: 0, fg: Reset, bg: Reset, underline: Reset, modifier: NONE, + x: 31, y: 1, fg: Cyan, bg: Reset, underline: Reset, modifier: NONE, + x: 40, y: 1, fg: Reset, bg: Reset, underline: Reset, modifier: NONE, ] } diff --git a/codex-rs/tui/src/bottom_pane/unified_exec_footer.rs b/codex-rs/tui/src/bottom_pane/unified_exec_footer.rs index 80ec1fb62..848e17553 100644 --- a/codex-rs/tui/src/bottom_pane/unified_exec_footer.rs +++ b/codex-rs/tui/src/bottom_pane/unified_exec_footer.rs @@ -40,7 +40,7 @@ impl UnifiedExecFooter { return Vec::new(); } - let label = "Background terminal running:"; + let label = " Background terminal running:"; let mut spans = Vec::new(); spans.push(label.dim()); spans.push(" ".into());