Fix CLI feedback link (#13086)
Addresses #12967 About a month ago, I updated the Github bug report templates to accommodate the (at the time) new Codex app. The `/feedback` code path in the CLI was referencing one of the old templates, and I didn't realize it at the time. This PR updates the link so users don't get an empty bug template when using `/feedback`.
This commit is contained in:
parent
033ef9cb9d
commit
e6032eb0b7
1 changed files with 5 additions and 8 deletions
|
|
@ -27,8 +27,8 @@ use super::popup_consts::standard_popup_hint_line;
|
|||
use super::textarea::TextArea;
|
||||
use super::textarea::TextAreaState;
|
||||
|
||||
const BASE_BUG_ISSUE_URL: &str =
|
||||
"https://github.com/openai/codex/issues/new?template=2-bug-report.yml";
|
||||
const BASE_CLI_BUG_ISSUE_URL: &str =
|
||||
"https://github.com/openai/codex/issues/new?template=3-cli.yml";
|
||||
/// Internal routing link for employee feedback follow-ups. This must not be shown to external users.
|
||||
const CODEX_FEEDBACK_INTERNAL_URL: &str = "http://go/codex-feedback-internal";
|
||||
|
||||
|
|
@ -389,7 +389,7 @@ fn issue_url_for_category(
|
|||
| FeedbackCategory::Other => Some(match feedback_audience {
|
||||
FeedbackAudience::OpenAiEmployee => slack_feedback_url(thread_id),
|
||||
FeedbackAudience::External => {
|
||||
format!("{BASE_BUG_ISSUE_URL}&steps=Uploaded%20thread:%20{thread_id}")
|
||||
format!("{BASE_CLI_BUG_ISSUE_URL}&steps=Uploaded%20thread:%20{thread_id}")
|
||||
}
|
||||
}),
|
||||
FeedbackCategory::GoodResult => None,
|
||||
|
|
@ -675,10 +675,7 @@ mod tests {
|
|||
);
|
||||
let bug_url_non_employee =
|
||||
issue_url_for_category(FeedbackCategory::Bug, "t", FeedbackAudience::External);
|
||||
let expected_external_url = format!("{BASE_BUG_ISSUE_URL}&steps=Uploaded%20thread:%20t");
|
||||
assert_eq!(
|
||||
bug_url_non_employee.as_deref(),
|
||||
Some(expected_external_url.as_str())
|
||||
);
|
||||
let expected_external_url = "https://github.com/openai/codex/issues/new?template=3-cli.yml&steps=Uploaded%20thread:%20t";
|
||||
assert_eq!(bug_url_non_employee.as_deref(), Some(expected_external_url));
|
||||
}
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Reference in a new issue