From f4bc03d7c049aaec020d431498949dfb6523f32e Mon Sep 17 00:00:00 2001 From: Jeremy Rose <172423086+nornagon-openai@users.noreply.github.com> Date: Wed, 8 Oct 2025 14:57:32 -0700 Subject: [PATCH] tui: fix off-by-16 in terminal_palette (#4967) caught by a bad refactor in #4957 --- codex-rs/tui/src/terminal_palette.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/codex-rs/tui/src/terminal_palette.rs b/codex-rs/tui/src/terminal_palette.rs index 3f2748eb8..05d842d5f 100644 --- a/codex-rs/tui/src/terminal_palette.rs +++ b/codex-rs/tui/src/terminal_palette.rs @@ -11,7 +11,7 @@ pub fn best_color(target: (u8, u8, u8)) -> Color { #[allow(clippy::disallowed_methods)] Color::Rgb(r, g, b) } else if color_level.has_256 - && let Some((i, _)) = xterm_fixed_colors().enumerate().min_by(|(_, a), (_, b)| { + && let Some((i, _)) = xterm_fixed_colors().min_by(|(_, a), (_, b)| { perceptual_distance(*a, target) .partial_cmp(&perceptual_distance(*b, target)) .unwrap_or(std::cmp::Ordering::Equal) @@ -236,8 +236,8 @@ mod imp { } /// The subset of Xterm colors that are usually consistent across terminals. -pub fn xterm_fixed_colors() -> impl Iterator { - XTERM_COLORS.into_iter().skip(16) +fn xterm_fixed_colors() -> impl Iterator { + XTERM_COLORS.into_iter().enumerate().skip(16) } // Xterm colors; derived from https://ss64.com/bash/syntax-colors.html