b87ba0a3cc
## Why To date, the argument-comment linter introduced in https://github.com/openai/codex/pull/14651 had to be built from source to run, which can be a bit slow (both for local dev and when it is run in CI). Because of the potential slowness, I did not wire it up to run as part of `just clippy` or anything like that. As a result, I have seen a number of occasions where folks put up PRs that violate the lint, see it fail in CI, and then have to put up their PR again. The goal of this PR is to pre-build a runnable version of the linter and then make it available via a DotSlash file. Once it is available, I will update `just clippy` and other touchpoints to make it a natural part of the dev cycle so lint violations should get flagged _before_ putting up a PR for review. To get things started, we will build the DotSlash file as part of an alpha release. Though I don't expect the linter to change often, so I'll probably change this to only build as part of mainline releases once we have a working DotSlash file. (Ultimately, we should probably move the linter into its own repo so it can have its own release cycle.) ## What Changed - add a reusable `rust-release-argument-comment-lint.yml` workflow that builds host-specific archives for macOS arm64, Linux arm64/x64, and Windows x64 - wire `rust-release.yml` to publish the `argument-comment-lint` DotSlash manifest on all releases for now, including alpha tags - package a runnable layout instead of a bare library The Unix archive layout is: ```text argument-comment-lint/ bin/ argument-comment-lint cargo-dylint lib/ libargument_comment_lint@nightly-2025-09-18-<target>.dylib|so ``` On Windows the same layout is published as a `.zip`, with `.exe` and `.dll` filenames instead. DotSlash resolves the package entrypoint to `argument-comment-lint/bin/argument-comment-lint`. That runner finds the sibling bundled `cargo-dylint` binary plus the single packaged Dylint library under `lib/`, then invokes `cargo-dylint dylint --lib-path <that-library>` with the repo's default lint settings.
24 lines
834 B
JSON
24 lines
834 B
JSON
{
|
|
"outputs": {
|
|
"argument-comment-lint": {
|
|
"platforms": {
|
|
"macos-aarch64": {
|
|
"regex": "^argument-comment-lint-aarch64-apple-darwin\\.tar\\.gz$",
|
|
"path": "argument-comment-lint/bin/argument-comment-lint"
|
|
},
|
|
"linux-x86_64": {
|
|
"regex": "^argument-comment-lint-x86_64-unknown-linux-gnu\\.tar\\.gz$",
|
|
"path": "argument-comment-lint/bin/argument-comment-lint"
|
|
},
|
|
"linux-aarch64": {
|
|
"regex": "^argument-comment-lint-aarch64-unknown-linux-gnu\\.tar\\.gz$",
|
|
"path": "argument-comment-lint/bin/argument-comment-lint"
|
|
},
|
|
"windows-x86_64": {
|
|
"regex": "^argument-comment-lint-x86_64-pc-windows-msvc\\.zip$",
|
|
"path": "argument-comment-lint/bin/argument-comment-lint.exe"
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|