fd719d3828
## Why `codex features list` currently prints features in declaration order from `codex_core::features::FEATURES`. That makes the output harder to scan when looking for a specific flag, and the order can change for reasons unrelated to the CLI. ## What changed - Sort the `codex features list` rows by feature key before printing them in `codex-rs/cli/src/main.rs`. - Add an integration test in `codex-rs/cli/tests/features.rs` that runs `codex features list` and asserts the feature-name column is alphabetized. ## Verification - Added `features_list_is_sorted_alphabetically_by_feature_name`. - Ran `cargo test -p codex-cli`.
91 lines
2.6 KiB
Rust
91 lines
2.6 KiB
Rust
use std::path::Path;
|
|
|
|
use anyhow::Result;
|
|
use predicates::str::contains;
|
|
use pretty_assertions::assert_eq;
|
|
use tempfile::TempDir;
|
|
|
|
fn codex_command(codex_home: &Path) -> Result<assert_cmd::Command> {
|
|
let mut cmd = assert_cmd::Command::new(codex_utils_cargo_bin::cargo_bin("codex")?);
|
|
cmd.env("CODEX_HOME", codex_home);
|
|
Ok(cmd)
|
|
}
|
|
|
|
#[tokio::test]
|
|
async fn features_enable_writes_feature_flag_to_config() -> Result<()> {
|
|
let codex_home = TempDir::new()?;
|
|
|
|
let mut cmd = codex_command(codex_home.path())?;
|
|
cmd.args(["features", "enable", "unified_exec"])
|
|
.assert()
|
|
.success()
|
|
.stdout(contains("Enabled feature `unified_exec` in config.toml."));
|
|
|
|
let config = std::fs::read_to_string(codex_home.path().join("config.toml"))?;
|
|
assert!(config.contains("[features]"));
|
|
assert!(config.contains("unified_exec = true"));
|
|
|
|
Ok(())
|
|
}
|
|
|
|
#[tokio::test]
|
|
async fn features_disable_writes_feature_flag_to_config() -> Result<()> {
|
|
let codex_home = TempDir::new()?;
|
|
|
|
let mut cmd = codex_command(codex_home.path())?;
|
|
cmd.args(["features", "disable", "shell_tool"])
|
|
.assert()
|
|
.success()
|
|
.stdout(contains("Disabled feature `shell_tool` in config.toml."));
|
|
|
|
let config = std::fs::read_to_string(codex_home.path().join("config.toml"))?;
|
|
assert!(config.contains("[features]"));
|
|
assert!(config.contains("shell_tool = false"));
|
|
|
|
Ok(())
|
|
}
|
|
|
|
#[tokio::test]
|
|
async fn features_enable_under_development_feature_prints_warning() -> Result<()> {
|
|
let codex_home = TempDir::new()?;
|
|
|
|
let mut cmd = codex_command(codex_home.path())?;
|
|
cmd.args(["features", "enable", "runtime_metrics"])
|
|
.assert()
|
|
.success()
|
|
.stderr(contains(
|
|
"Under-development features enabled: runtime_metrics.",
|
|
));
|
|
|
|
Ok(())
|
|
}
|
|
|
|
#[tokio::test]
|
|
async fn features_list_is_sorted_alphabetically_by_feature_name() -> Result<()> {
|
|
let codex_home = TempDir::new()?;
|
|
|
|
let mut cmd = codex_command(codex_home.path())?;
|
|
let output = cmd
|
|
.args(["features", "list"])
|
|
.assert()
|
|
.success()
|
|
.get_output()
|
|
.stdout
|
|
.clone();
|
|
let stdout = String::from_utf8(output)?;
|
|
|
|
let actual_names = stdout
|
|
.lines()
|
|
.map(|line| {
|
|
line.split_once(" ")
|
|
.map(|(name, _)| name.trim_end().to_string())
|
|
.expect("feature list output should contain aligned columns")
|
|
})
|
|
.collect::<Vec<_>>();
|
|
let mut expected_names = actual_names.clone();
|
|
expected_names.sort();
|
|
|
|
assert_eq!(actual_names, expected_names);
|
|
|
|
Ok(())
|
|
}
|