we see windows test failures like this: https://github.com/openai/codex/actions/runs/20930055601/job/60138344260. The issue is that SSE connections sometimes remain open after the completion event esp. for windows. We should emit the completion event and return immediately. this is consistent with the protocol: > The Model streams responses back in an SSE, which are collected until "completed" message and the SSE terminates from https://github.com/openai/codex/blob/dev/cc/fix-windows-test/codex-rs/docs/protocol_v1.md#L37. this helps us achieve parity with responses websocket logic here: https://github.com/openai/codex/blob/dev/cc/fix-windows-test/codex-rs/codex-api/src/endpoint/responses_websocket.rs#L220-L227. |
||
|---|---|---|
| .. | ||
| chat.rs | ||
| mod.rs | ||
| responses.rs | ||