a6597a9958
This closes #6748 by implementing fallback to `model_family.default_reasoning_effort` in `reasoning_effort` display of `/status` when no `model_reasoning_effort` is set in the configuration. ## common/src/config_summary.rs - `create_config_summary_entries` now fills the "reasoning effort" entry with the explicit `config.model_reasoning_effort` when present and falls back to `config.model_family.default_reasoning_effort` when it is `None`, instead of emitting the literal string `none`. - This ensures downstream consumers such as `tui/src/status/helpers.rs` continue to work unchanged while automatically picking up model-family defaults when the user has not selected a reasoning effort. ## tui/src/status/helpers.rs / core/src/model_family.rs `ModelFamily::default_reasoning_effort` metadata is set to `medium` for both `gpt-5*-codex` and `gpt-5` models following the default behaviour of the API and recommendation of the codebase: - per https://platform.openai.com/docs/api-reference/responses/create `gpt-5` defaults to `medium` reasoning when no preset is passed - there is no mention of the preset for `gpt-5.1-codex` in the API docs but `medium` is the default setting for `gpt-5.1-codex` as per `codex-rs/tui/src/chatwidget/snapshots/codex_tui__chatwidget__tests__model_reasoning_selection_popup.snap` --------- Signed-off-by: lionelchg <lionel.cheng@hotmail.fr> Co-authored-by: Eric Traut <etraut@openai.com> |
||
|---|---|---|
| .. | ||
| approval_mode_cli_arg.rs | ||
| approval_presets.rs | ||
| config_override.rs | ||
| config_summary.rs | ||
| elapsed.rs | ||
| format_env_display.rs | ||
| fuzzy_match.rs | ||
| lib.rs | ||
| model_presets.rs | ||
| oss.rs | ||
| sandbox_mode_cli_arg.rs | ||
| sandbox_summary.rs | ||