## Summary - restore the guardian review request snapshot test and its tracked snapshot after it was dropped from `main` - make Bazel Rust unit-test wrappers resolve runfiles correctly on manifest-only platforms like macOS and point Insta at the real workspace root - harden the shell-escalation socket-closure assertion so the musl Bazel test no longer depends on fd reuse behavior ## Verification - cargo test -p codex-core guardian_review_request_layout_matches_model_visible_request_snapshot - cargo test -p codex-shell-escalation - bazel test //codex-rs/exec:exec-unit-tests //codex-rs/shell-escalation:shell-escalation-unit-tests Supersedes #13894. --------- Co-authored-by: Ahmed Ibrahim <aibrahim@openai.com> Co-authored-by: viyatb-oai <viyatb@openai.com> Co-authored-by: Codex <noreply@openai.com> |
||
|---|---|---|
| .. | ||
| src | ||
| BUILD.bazel | ||
| Cargo.toml | ||
| README.md | ||
| repo_root.marker | ||
codex-utils-cargo-bin runfiles strategy
We disable the directory-based runfiles strategy and rely on the manifest
strategy across all platforms. This avoids Windows path length issues and keeps
behavior consistent in local and remote builds on all platforms. Bazel sets
RUNFILES_MANIFEST_FILE, and the codex-utils-cargo-bin helpers use the
runfiles crate to resolve runfiles via that manifest.
Function behavior:
cargo_bin: readsCARGO_BIN_EXE_*environment variables (set by Cargo or Bazel) and resolves them via the runfiles manifest whenRUNFILES_MANIFEST_FILEis present. When not under runfiles, it only accepts absolute paths fromCARGO_BIN_EXE_*and returns an error otherwise.find_resource!: used by tests to locate fixtures. It chooses the Bazel runfiles resolution path whenRUNFILES_MANIFEST_FILEis set, otherwise it falls back to aCARGO_MANIFEST_DIR-relative path for Cargo runs.
Background: