core-agent-ide/.github/workflows
Michael Bolin b77fe8fefe
Apply argument comment lint across codex-rs (#14652)
## Why

Once the repo-local lint exists, `codex-rs` needs to follow the
checked-in convention and CI needs to keep it from drifting. This commit
applies the fallback `/*param*/` style consistently across existing
positional literal call sites without changing those APIs.

The longer-term preference is still to avoid APIs that require comments
by choosing clearer parameter types and call shapes. This PR is
intentionally the mechanical follow-through for the places where the
existing signatures stay in place.

After rebasing onto newer `main`, the rollout also had to cover newly
introduced `tui_app_server` call sites. That made it clear the first cut
of the CI job was too expensive for the common path: it was spending
almost as much time installing `cargo-dylint` and re-testing the lint
crate as a representative test job spends running product tests. The CI
update keeps the full workspace enforcement but trims that extra
overhead from ordinary `codex-rs` PRs.

## What changed

- keep a dedicated `argument_comment_lint` job in `rust-ci`
- mechanically annotate remaining opaque positional literals across
`codex-rs` with exact `/*param*/` comments, including the rebased
`tui_app_server` call sites that now fall under the lint
- keep the checked-in style aligned with the lint policy by using
`/*param*/` and leaving string and char literals uncommented
- cache `cargo-dylint`, `dylint-link`, and the relevant Cargo
registry/git metadata in the lint job
- split changed-path detection so the lint crate's own `cargo test` step
runs only when `tools/argument-comment-lint/*` or `rust-ci.yml` changes
- continue to run the repo wrapper over the `codex-rs` workspace, so
product-code enforcement is unchanged

Most of the code changes in this commit are intentionally mechanical
comment rewrites or insertions driven by the lint itself.

## Verification

- `./tools/argument-comment-lint/run.sh --workspace`
- `cargo test -p codex-tui-app-server -p codex-tui`
- parsed `.github/workflows/rust-ci.yml` locally with PyYAML

---

* -> #14652
* #14651
2026-03-16 16:48:15 -07:00
..
bazel.yml fix: disable Bazel builds in CI on ubuntu-24.04-arm until we can stabilize them (#13055) 2026-02-27 12:49:13 -08:00
blob-size-policy.yml check for large binaries in CI (#14382) 2026-03-11 22:39:08 +00:00
cargo-deny.yml bump cargo-deny-action ver (#8345) 2025-12-19 15:23:02 -08:00
ci.bazelrc [bazel] Upgrade some rulesets in preparation for enabling windows, part 2 (#11197) 2026-02-09 20:08:10 +00:00
ci.yml chore(deps): bump actions/upload-artifact from 6 to 7 (#13207) 2026-03-04 18:32:35 -07:00
cla.yml Fixed CLA action to properly exempt dependabot (#7429) 2025-11-30 20:45:17 -08:00
close-stale-contributor-prs.yml ci: prevent workflows from running on forks (#8629) 2026-01-03 13:12:16 -07:00
codespell.yml chore(deps): bump actions/checkout from 5 to 6 (#7230) 2025-11-24 11:45:57 -08:00
Dockerfile.bazel ci(bazel): install Node from node-version.txt in remote image (#12205) 2026-02-20 11:51:17 -08:00
issue-deduplicator.yml Require deduplicator success before commenting (#13399) 2026-03-03 15:32:47 -07:00
issue-labeler.yml Updated issue labeler script to include safety-check label (#12096) 2026-02-17 22:44:42 -08:00
rust-ci.yml Apply argument comment lint across codex-rs (#14652) 2026-03-16 16:48:15 -07:00
rust-release-prepare.yml ci: prevent workflows from running on forks (#8629) 2026-01-03 13:12:16 -07:00
rust-release-windows.yml chore(deps): bump actions/upload-artifact from 6 to 7 (#13207) 2026-03-04 18:32:35 -07:00
rust-release.yml Codex/winget auto update (#12943) 2026-03-06 14:04:30 -08:00
sdk.yml Increase sdk workflow timeout to 15 minutes (#14252) 2026-03-11 12:33:08 -07:00
shell-tool-mcp-ci.yml fix: remove references to corepack (#10138) 2026-01-28 23:31:25 -08:00
shell-tool-mcp.yml chore(deps): bump actions/upload-artifact from 6 to 7 (#13207) 2026-03-04 18:32:35 -07:00
zstd ci(windows): use DotSlash for zstd in rust-release-windows (#11542) 2026-02-11 20:57:11 -08:00