core-agent-ide/.github/workflows
Michael Bolin fa2a2f0be9
Use released DotSlash package for argument-comment lint (#15199)
## Why
The argument-comment lint now has a packaged DotSlash artifact from
[#15198](https://github.com/openai/codex/pull/15198), so the normal repo
lint path should use that released payload instead of rebuilding the
lint from source every time.

That keeps `just clippy` and CI aligned with the shipped artifact while
preserving a separate source-build path for people actively hacking on
the lint crate.

The current alpha package also exposed two integration wrinkles that the
repo-side prebuilt wrapper needs to smooth over:
- the bundled Dylint library filename includes the host triple, for
example `@nightly-2025-09-18-aarch64-apple-darwin`, and Dylint derives
`RUSTUP_TOOLCHAIN` from that filename
- on Windows, Dylint's driver path also expects `RUSTUP_HOME` to be
present in the environment

Without those adjustments, the prebuilt CI jobs fail during `cargo
metadata` or driver setup. This change makes the checked-in prebuilt
wrapper normalize the packaged library name to the plain
`nightly-2025-09-18` channel before invoking `cargo-dylint`, and it
teaches both the wrapper and the packaged runner source to infer
`RUSTUP_HOME` from `rustup show home` when the environment does not
already provide it.

After the prebuilt Windows lint job started running successfully, it
also surfaced a handful of existing anonymous literal callsites in
`windows-sandbox-rs`. This PR now annotates those callsites so the new
cross-platform lint job is green on the current tree.

## What Changed
- checked in the current
`tools/argument-comment-lint/argument-comment-lint` DotSlash manifest
- kept `tools/argument-comment-lint/run.sh` as the source-build wrapper
for lint development
- added `tools/argument-comment-lint/run-prebuilt-linter.sh` as the
normal enforcement path, using the checked-in DotSlash package and
bundled `cargo-dylint`
- updated `just clippy` and `just argument-comment-lint` to use the
prebuilt wrapper
- split `.github/workflows/rust-ci.yml` so source-package checks live in
a dedicated `argument_comment_lint_package` job, while the released lint
runs in an `argument_comment_lint_prebuilt` matrix on Linux, macOS, and
Windows
- kept the pinned `nightly-2025-09-18` toolchain install in the prebuilt
CI matrix, since the prebuilt package still relies on rustup-provided
toolchain components
- updated `tools/argument-comment-lint/run-prebuilt-linter.sh` to
normalize host-qualified nightly library filenames, keep the `rustup`
shim directory ahead of direct toolchain `cargo` binaries, and export
`RUSTUP_HOME` when needed for Windows Dylint driver setup
- updated `tools/argument-comment-lint/src/bin/argument-comment-lint.rs`
so future published DotSlash artifacts apply the same nightly-filename
normalization and `RUSTUP_HOME` inference internally
- fixed the remaining Windows lint violations in
`codex-rs/windows-sandbox-rs` by adding the required `/*param*/`
comments at the reported callsites
- documented the checked-in DotSlash file, wrapper split, archive
layout, nightly prerequisite, and Windows `RUSTUP_HOME` requirement in
`tools/argument-comment-lint/README.md`
2026-03-20 03:19:22 +00:00
..
bazel.yml V8 Bazel Build (#15021) 2026-03-19 18:05:23 -07:00
blob-size-policy.yml fix: tighten up shell arg quoting in GitHub workflows (#14864) 2026-03-16 22:01:16 -07:00
cargo-deny.yml bump cargo-deny-action ver (#8345) 2025-12-19 15:23:02 -08:00
ci.bazelrc [bazel] Upgrade some rulesets in preparation for enabling windows, part 2 (#11197) 2026-02-09 20:08:10 +00:00
ci.yml fix: try to fix "Stage npm package" step in ci.yml (#15092) 2026-03-18 13:52:33 -07:00
cla.yml Fixed CLA action to properly exempt dependabot (#7429) 2025-11-30 20:45:17 -08:00
close-stale-contributor-prs.yml ci: prevent workflows from running on forks (#8629) 2026-01-03 13:12:16 -07:00
codespell.yml chore(deps): bump actions/checkout from 5 to 6 (#7230) 2025-11-24 11:45:57 -08:00
Dockerfile.bazel ci(bazel): install Node from node-version.txt in remote image (#12205) 2026-02-20 11:51:17 -08:00
issue-deduplicator.yml fix: tighten up shell arg quoting in GitHub workflows (#14864) 2026-03-16 22:01:16 -07:00
issue-labeler.yml Updated issue labeler script to include safety-check label (#12096) 2026-02-17 22:44:42 -08:00
rust-ci.yml Use released DotSlash package for argument-comment lint (#15199) 2026-03-20 03:19:22 +00:00
rust-release-argument-comment-lint.yml Publish runnable DotSlash package for argument-comment lint (#15198) 2026-03-19 18:59:02 +00:00
rust-release-prepare.yml ci: prevent workflows from running on forks (#8629) 2026-01-03 13:12:16 -07:00
rust-release-windows.yml chore(deps): bump actions/upload-artifact from 6 to 7 (#13207) 2026-03-04 18:32:35 -07:00
rust-release.yml Publish runnable DotSlash package for argument-comment lint (#15198) 2026-03-19 18:59:02 +00:00
rusty-v8-release.yml V8 Bazel Build (#15021) 2026-03-19 18:05:23 -07:00
sdk.yml Increase sdk workflow timeout to 15 minutes (#14252) 2026-03-11 12:33:08 -07:00
shell-tool-mcp-ci.yml fix: remove references to corepack (#10138) 2026-01-28 23:31:25 -08:00
shell-tool-mcp.yml fix: tighten up shell arg quoting in GitHub workflows (#14864) 2026-03-16 22:01:16 -07:00
v8-canary.yml V8 Bazel Build (#15021) 2026-03-19 18:05:23 -07:00
v8-ci.bazelrc V8 Bazel Build (#15021) 2026-03-19 18:05:23 -07:00
zstd ci(windows): use DotSlash for zstd in rust-release-windows (#11542) 2026-02-11 20:57:11 -08:00