core-agent-ide/codex-rs/otel/src
Michael Bolin b77fe8fefe
Apply argument comment lint across codex-rs (#14652)
## Why

Once the repo-local lint exists, `codex-rs` needs to follow the
checked-in convention and CI needs to keep it from drifting. This commit
applies the fallback `/*param*/` style consistently across existing
positional literal call sites without changing those APIs.

The longer-term preference is still to avoid APIs that require comments
by choosing clearer parameter types and call shapes. This PR is
intentionally the mechanical follow-through for the places where the
existing signatures stay in place.

After rebasing onto newer `main`, the rollout also had to cover newly
introduced `tui_app_server` call sites. That made it clear the first cut
of the CI job was too expensive for the common path: it was spending
almost as much time installing `cargo-dylint` and re-testing the lint
crate as a representative test job spends running product tests. The CI
update keeps the full workspace enforcement but trims that extra
overhead from ordinary `codex-rs` PRs.

## What changed

- keep a dedicated `argument_comment_lint` job in `rust-ci`
- mechanically annotate remaining opaque positional literals across
`codex-rs` with exact `/*param*/` comments, including the rebased
`tui_app_server` call sites that now fall under the lint
- keep the checked-in style aligned with the lint policy by using
`/*param*/` and leaving string and char literals uncommented
- cache `cargo-dylint`, `dylint-link`, and the relevant Cargo
registry/git metadata in the lint job
- split changed-path detection so the lint crate's own `cargo test` step
runs only when `tools/argument-comment-lint/*` or `rust-ci.yml` changes
- continue to run the repo wrapper over the `codex-rs` workspace, so
product-code enforcement is unchanged

Most of the code changes in this commit are intentionally mechanical
comment rewrites or insertions driven by the lint itself.

## Verification

- `./tools/argument-comment-lint/run.sh --workspace`
- `cargo test -p codex-tui-app-server -p codex-tui`
- parsed `.github/workflows/rust-ci.yml` locally with PyYAML

---

* -> #14652
* #14651
2026-03-16 16:48:15 -07:00
..
events Apply argument comment lint across codex-rs (#14652) 2026-03-16 16:48:15 -07:00
metrics feat(core): emit turn metric for network proxy state (#14250) 2026-03-11 12:33:10 -07:00
config.rs feat: show runtime metrics in console (#10278) 2026-01-30 22:20:02 -08:00
lib.rs fix(otel): make HTTP trace export survive app-server runtimes (#14300) 2026-03-11 12:33:10 -07:00
otlp.rs fix(otel): make HTTP trace export survive app-server runtimes (#14300) 2026-03-11 12:33:10 -07:00
provider.rs fix(otel): make HTTP trace export survive app-server runtimes (#14300) 2026-03-11 12:33:10 -07:00
targets.rs chore(otel): reorganize codex-otel crate (#13800) 2026-03-06 14:58:18 -08:00
trace_context.rs fix(otel): make HTTP trace export survive app-server runtimes (#14300) 2026-03-11 12:33:10 -07:00