core/core-agent-ide
8
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
core-agent-ide/codex-cli/tests
History
Jordan Docherty f6b12aa994
refactor(history-overlay): split into modular functions & add tests (fixes #402) (#403) 
## What
This PR targets #402 and refactors the `history-overlay.tsx`component to
reduce cognitive complexity by splitting the `buildLists` function into
smaller, focused helper functions. It also adds comprehensive test
coverage to ensure the functionality remains intact.

## Why
The original `buildLists` function had high cognitive complexity due to
multiple nested conditionals, complex string manipulation, and mixed
responsibilities. This refactor makes the code more maintainable and
easier to understand while preserving all existing functionality.

## How
- Split `buildLists` into focused helper functions
- Added comprehensive test coverage for all functionality
- Maintained existing behavior and keyboard interactions
- Improved code organization and readability

## Testing
All tests pass, including:
- Command mode functionality
- File mode functionality
- Keyboard interactions
- Error handling
2025-04-20 22:27:06 -07:00
..
__fixtures__ Initial commit 2025-04-16 12:56:08 -04:00
__snapshots__ feat: notify when a newer version is available (#333) 2025-04-18 17:00:45 -07:00
agent-cancel-early.test.ts feat: add notifications for MacOS using Applescript (#160) 2025-04-17 16:19:26 -07:00
agent-cancel-prev-response.test.ts feat: add notifications for MacOS using Applescript (#160) 2025-04-17 16:19:26 -07:00
agent-cancel-race.test.ts feat: add notifications for MacOS using Applescript (#160) 2025-04-17 16:19:26 -07:00
agent-cancel.test.ts feat: add notifications for MacOS using Applescript (#160) 2025-04-17 16:19:26 -07:00
agent-function-call-id.test.ts add support for -w,--writable-root to add more writable roots for sandbox (#263) 2025-04-17 15:39:26 -07:00
agent-generic-network-error.test.ts add support for -w,--writable-root to add more writable roots for sandbox (#263) 2025-04-17 15:39:26 -07:00
agent-interrupt-continue.test.ts feat: add notifications for MacOS using Applescript (#160) 2025-04-17 16:19:26 -07:00
agent-invalid-request-error.test.ts add support for -w,--writable-root to add more writable roots for sandbox (#263) 2025-04-17 15:39:26 -07:00
agent-max-tokens-error.test.ts add support for -w,--writable-root to add more writable roots for sandbox (#263) 2025-04-17 15:39:26 -07:00
agent-network-errors.test.ts add support for -w,--writable-root to add more writable roots for sandbox (#263) 2025-04-17 15:39:26 -07:00
agent-project-doc.test.ts add support for -w,--writable-root to add more writable roots for sandbox (#263) 2025-04-17 15:39:26 -07:00
agent-rate-limit-error.test.ts add support for -w,--writable-root to add more writable roots for sandbox (#263) 2025-04-17 15:39:26 -07:00
agent-server-retry.test.ts add support for -w,--writable-root to add more writable roots for sandbox (#263) 2025-04-17 15:39:26 -07:00
agent-terminate.test.ts feat: add notifications for MacOS using Applescript (#160) 2025-04-17 16:19:26 -07:00
agent-thinking-time.test.ts add support for -w,--writable-root to add more writable roots for sandbox (#263) 2025-04-17 15:39:26 -07:00
api-key.test.ts Initial commit 2025-04-16 12:56:08 -04:00
apply-patch.test.ts Initial commit 2025-04-16 12:56:08 -04:00
approvals.test.ts feat: add user-defined safe commands configuration and approval logic #380 (#386) 2025-04-18 22:35:32 -07:00
cancel-exec.test.ts Initial commit 2025-04-16 12:56:08 -04:00
check-updates.test.ts feat: notify when a newer version is available (#333) 2025-04-18 17:00:45 -07:00
config.test.tsx feat: read approvalMode from config file (#298) 2025-04-19 07:25:25 -07:00
dummy.test.ts Initial commit 2025-04-16 12:56:08 -04:00
external-editor.test.ts Back out @lib indirection in tsconfig.json (#111) 2025-04-16 14:16:53 -07:00
fixed-requires-shell.test.ts fix: command pipe execution by improving shell detection (#437) 2025-04-20 21:11:19 -07:00
format-command.test.ts Back out @lib indirection in tsconfig.json (#111) 2025-04-16 14:16:53 -07:00
history-overlay.test.tsx refactor(history-overlay): split into modular functions & add tests (fixes #402) (#403) 2025-04-20 22:27:06 -07:00
input-utils.test.ts re-enable Prettier check for codex-cli in CI (#417) 2025-04-19 11:22:45 -07:00
invalid-command-handling.test.ts add support for -w,--writable-root to add more writable roots for sandbox (#263) 2025-04-17 15:39:26 -07:00
markdown.test.tsx Initial commit 2025-04-16 12:56:08 -04:00
model-utils-network-error.test.ts Initial commit 2025-04-16 12:56:08 -04:00
multiline-ctrl-enter-submit.test.tsx Initial commit 2025-04-16 12:56:08 -04:00
multiline-dynamic-width.test.tsx Initial commit 2025-04-16 12:56:08 -04:00
multiline-enter-submit-cr.test.tsx Initial commit 2025-04-16 12:56:08 -04:00
multiline-external-editor-shortcut.test.tsx Back out @lib indirection in tsconfig.json (#111) 2025-04-16 14:16:53 -07:00
multiline-history-behavior.test.tsx Back out @lib indirection in tsconfig.json (#111) 2025-04-16 14:16:53 -07:00
multiline-input-test.ts Initial commit 2025-04-16 12:56:08 -04:00
multiline-newline.test.tsx Initial commit 2025-04-16 12:56:08 -04:00
multiline-shift-enter-crlf.test.tsx Initial commit 2025-04-16 12:56:08 -04:00
multiline-shift-enter-mod1.test.tsx Fix handling of Shift+Enter in e.g. Ghostty (#338) 2025-04-18 09:19:06 -07:00
multiline-shift-enter.test.tsx Initial commit 2025-04-16 12:56:08 -04:00
parse-apply-patch.test.ts Back out @lib indirection in tsconfig.json (#111) 2025-04-16 14:16:53 -07:00
pipe-command.test.ts fix: command pipe execution by improving shell detection (#437) 2025-04-20 21:11:19 -07:00
project-doc.test.ts Initial commit 2025-04-16 12:56:08 -04:00
raw-exec-process-group.test.ts fix(raw-exec-process-group): improve test reliability (#434) 2025-04-20 12:21:02 -07:00
requires-shell.test.ts fix: command pipe execution by improving shell detection (#437) 2025-04-20 21:11:19 -07:00
responses-chat-completions.test.ts feat: support multiple providers via Responses-Completion transformation (#247) 2025-04-20 20:59:34 -07:00
slash-commands.test.ts feat: /diff command to view git diff (#426) 2025-04-19 16:23:27 -07:00
terminal-chat-input-compact.test.tsx feat: /diff command to view git diff (#426) 2025-04-19 16:23:27 -07:00
terminal-chat-input-multiline.test.tsx feat: allow multi-line input (#438) 2025-04-20 08:51:38 -07:00
terminal-chat-response-item.test.tsx Initial commit 2025-04-16 12:56:08 -04:00
text-buffer-copy-paste.test.ts Back out @lib indirection in tsconfig.json (#111) 2025-04-16 14:16:53 -07:00
text-buffer-crlf.test.ts Back out @lib indirection in tsconfig.json (#111) 2025-04-16 14:16:53 -07:00
text-buffer-gaps.test.ts Back out @lib indirection in tsconfig.json (#111) 2025-04-16 14:16:53 -07:00
text-buffer-word.test.ts fix(text-buffer): correct word deletion logic for trailing spaces (Ctrl+Backspace) (#131) 2025-04-16 16:25:08 -07:00
text-buffer.test.ts Back out @lib indirection in tsconfig.json (#111) 2025-04-16 14:16:53 -07:00
typeahead-scroll.test.tsx (fix) do not transitively rely on deprecated lodash deps (#175) 2025-04-16 20:52:35 -07:00
ui-test-helpers.tsx Initial commit 2025-04-16 12:56:08 -04:00