core-agent-ide/codex-rs/utils
Eric Traut 069a38a06c
Add missing "nullable" macro to protocol structs that contain optional fields (#5901)
This PR addresses a current hole in the TypeScript code generation for
the API server protocol. Fields that are marked as "Optional<>" in the
Rust code are serialized such that the value is omitted when it is
deserialized — appearing as `undefined`, but the TS type indicates
(incorrectly) that it is always defined but possibly `null`. This can
lead to subtle errors that the TypeScript compiler doesn't catch. The
fix is to include the `#[ts(optional_fields = nullable)]` macro for all
protocol structs that contain one or more `Optional<>` fields.

This PR also includes a new test that validates that all TS protocol
code containing "| null" in its type is marked optional ("?") to catch
cases where `#[ts(optional_fields = nullable)]` is omitted.
2025-10-29 12:09:47 -07:00
..
cache feat: image resizing (#5446) 2025-10-27 16:58:10 +00:00
git Add missing "nullable" macro to protocol structs that contain optional fields (#5901) 2025-10-29 12:09:47 -07:00
image feat: image resizing (#5446) 2025-10-27 16:58:10 +00:00
json-to-toml fix: separate codex mcp into codex mcp-server and codex app-server (#4471) 2025-09-30 07:06:18 +00:00
pty chore: rework tools execution workflow (#5278) 2025-10-20 20:57:37 +01:00
readiness feat: async ghost commit (#5618) 2025-10-27 10:09:10 +00:00
string chore: refactor tool handling (#4510) 2025-10-03 13:21:06 +01:00
tokenizer feat: use actual tokenizer for unified_exec truncation (#5514) 2025-10-23 17:08:06 +01:00