core/go-ansible
8
0
Fork 0
Code Issues 4 Pull requests Projects Releases Packages Wiki Activity Actions

Add script module creates and chdir support

Browse source
This commit is contained in:
Virgil 2026-04-01 22:59:12 +00:00
parent e793321e1e
commit 134ea64e92
2 changed files with 53 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
modules.go
View file

@ -391,6 +391,14 @@ func (e *Executor) moduleScript(ctx context.Context, client sshExecutorClient, a
return nil, coreerr.E("Executor.moduleScript", "no script specified", nil)
}
skip, err := shouldSkipCommandModule(ctx, client, args)
if err != nil {
return nil, err
}
if skip {
return &TaskResult{Changed: false}, nil
}
// Read local script
script = e.resolveLocalPath(script)
data, err := coreio.Local.Read(script)
@ -398,6 +406,10 @@ func (e *Executor) moduleScript(ctx context.Context, client sshExecutorClient, a
return nil, coreerr.E("Executor.moduleScript", "read script", err)
}
if chdir := getStringArg(args, "chdir", ""); chdir != "" {
data = sprintf("cd %q && %s", chdir, data)
}
stdout, stderr, rc, err := client.RunScript(ctx, data)
if err != nil {
return &TaskResult{Failed: true, Msg: err.Error()}, nil

41
modules_cmd_test.go
View file

@ -562,6 +562,47 @@ func TestModulesCmd_ModuleScript_Good_BasicScript(t *testing.T) {
assert.Equal(t, scriptContent, last.Cmd)
}
func TestModulesCmd_ModuleScript_Good_CreatesSkipsExecution(t *testing.T) {
tmpDir := t.TempDir()
scriptPath := joinPath(tmpDir, "setup.sh")
require.NoError(t, writeTestFile(scriptPath, []byte("echo should-not-run"), 0755))
e, mock := newTestExecutorWithMock("host1")
mock.addFile("/tmp/already-there", []byte("present"))
result, err := e.moduleScript(context.Background(), mock, map[string]any{
"_raw_params": scriptPath,
"creates": "/tmp/already-there",
})
require.NoError(t, err)
require.NotNil(t, result)
assert.False(t, result.Changed)
assert.Equal(t, 0, mock.commandCount())
}
func TestModulesCmd_ModuleScript_Good_ChdirPrefixesScript(t *testing.T) {
tmpDir := t.TempDir()
scriptPath := joinPath(tmpDir, "work.sh")
require.NoError(t, writeTestFile(scriptPath, []byte("pwd"), 0755))
e, mock := newTestExecutorWithMock("host1")
result, err := e.moduleScript(context.Background(), mock, map[string]any{
"_raw_params": scriptPath,
"chdir": "/opt/app",
})
require.NoError(t, err)
require.NotNil(t, result)
assert.True(t, result.Changed)
last := mock.lastCommand()
require.NotNil(t, last)
assert.Equal(t, "RunScript", last.Method)
assert.Equal(t, `cd "/opt/app" && pwd`, last.Cmd)
}
func TestModulesCmd_ModuleScript_Bad_NoScript(t *testing.T) {
e, _ := newTestExecutorWithMock("host1")
mock := NewMockSSHClient()