core/go-ansible
8
0
Fork 0
Code Issues 4 Pull requests Projects Releases Packages Wiki Activity Actions

feat(ansible): add uri timeout and cert controls

Browse source 
Co-Authored-By: Virgil <virgil@lethean.io>
This commit is contained in:
Virgil 2026-04-02 02:32:49 +00:00
parent fbfc2a6c7e
commit 8c1f4af11e
3 changed files with 37 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
mock_ssh_test.go
View file

@ -1658,6 +1658,8 @@ func moduleURIWithClient(_ *Executor, client sshRunner, args map[string]any) (*T
method := getStringArg(args, "method", "GET")
bodyFormat := lower(getStringArg(args, "body_format", ""))
returnContent := getBoolArg(args, "return_content", false)
timeout := getIntArg(args, "timeout", 0)
validateCerts := getBoolArg(args, "validate_certs", true)
if url == "" {
return nil, mockError("moduleURIWithClient", "uri: url required")
@ -1674,6 +1676,10 @@ func moduleURIWithClient(_ *Executor, client sshRunner, args map[string]any) (*T
}
}
if !validateCerts {
curlOpts = append(curlOpts, "-k")
}
// Body
if body := args["body"]; body != nil {
bodyText, err := renderURIBody(body, bodyFormat)
@ -1693,6 +1699,10 @@ func moduleURIWithClient(_ *Executor, client sshRunner, args map[string]any) (*T
}
}
if timeout > 0 {
curlOpts = append(curlOpts, "--max-time", strconv.Itoa(timeout))
}
// Status code
curlOpts = append(curlOpts, "-w", "\\n%{http_code}")

10
modules.go
View file

@ -1277,6 +1277,8 @@ func (e *Executor) moduleURI(ctx context.Context, client sshExecutorClient, args
method := getStringArg(args, "method", "GET")
bodyFormat := lower(getStringArg(args, "body_format", ""))
returnContent := getBoolArg(args, "return_content", false)
timeout := getIntArg(args, "timeout", 0)
validateCerts := getBoolArg(args, "validate_certs", true)
if url == "" {
return nil, coreerr.E("Executor.moduleURI", "url required", nil)
@ -1293,6 +1295,10 @@ func (e *Executor) moduleURI(ctx context.Context, client sshExecutorClient, args
}
}
if !validateCerts {
curlOpts = append(curlOpts, "-k")
}
// Body
if body := args["body"]; body != nil {
bodyText, err := renderURIBody(body, bodyFormat)
@ -1312,6 +1318,10 @@ func (e *Executor) moduleURI(ctx context.Context, client sshExecutorClient, args
}
}
if timeout > 0 {
curlOpts = append(curlOpts, "--max-time", strconv.Itoa(timeout))
}
// Status code
curlOpts = append(curlOpts, "-w", "\\n%{http_code}")

17
modules_adv_test.go
View file

@ -1370,6 +1370,23 @@ func TestModulesAdv_ModuleURI_Good_JSONBodyFormat(t *testing.T) {
assert.True(t, mock.containsSubstring("Content-Type: application/json"))
}
func TestModulesAdv_ModuleURI_Good_TimeoutAndInsecureSkipVerify(t *testing.T) {
e, mock := newTestExecutorWithMock("host1")
mock.expectCommand(`curl`, "OK\n200", "", 0)
result, err := moduleURIWithClient(e, mock, map[string]any{
"url": "https://insecure.example.com/health",
"timeout": 15,
"validate_certs": false,
})
require.NoError(t, err)
assert.False(t, result.Failed)
assert.Equal(t, 200, result.RC)
assert.True(t, mock.containsSubstring("-k"))
assert.True(t, mock.containsSubstring("--max-time 15"))
}
func TestModulesAdv_ModuleURI_Good_MultipleExpectedStatuses(t *testing.T) {
e, mock := newTestExecutorWithMock("host1")
mock.expectCommand(`curl`, "\n202", "", 0)