package ansible import ( "context" "testing" "github.com/stretchr/testify/assert" "github.com/stretchr/testify/require" ) // ============================================================ // Tests for non-SSH module handlers (0% coverage) // ============================================================ // --- moduleDebug --- func TestExecutorExtra_ModuleDebug_Good_Message(t *testing.T) { e := NewExecutor("/tmp") result, err := e.moduleDebug(map[string]any{"msg": "Hello world"}) require.NoError(t, err) assert.False(t, result.Changed) assert.Equal(t, "Hello world", result.Msg) } func TestExecutorExtra_ModuleDebug_Good_Var(t *testing.T) { e := NewExecutor("/tmp") e.vars["my_version"] = "1.2.3" result, err := e.moduleDebug(map[string]any{"var": "my_version"}) require.NoError(t, err) assert.Contains(t, result.Msg, "1.2.3") } func TestExecutorExtra_ModuleDebug_Good_EmptyArgs(t *testing.T) { e := NewExecutor("/tmp") result, err := e.moduleDebug(map[string]any{}) require.NoError(t, err) assert.Equal(t, "", result.Msg) } // --- moduleFail --- func TestExecutorExtra_ModuleFail_Good_DefaultMessage(t *testing.T) { e := NewExecutor("/tmp") result, err := e.moduleFail(map[string]any{}) require.NoError(t, err) assert.True(t, result.Failed) assert.Equal(t, "Failed as requested", result.Msg) } func TestExecutorExtra_ModuleFail_Good_CustomMessage(t *testing.T) { e := NewExecutor("/tmp") result, err := e.moduleFail(map[string]any{"msg": "deployment blocked"}) require.NoError(t, err) assert.True(t, result.Failed) assert.Equal(t, "deployment blocked", result.Msg) } // --- moduleAssert --- func TestExecutorExtra_ModuleAssert_Good_PassingAssertion(t *testing.T) { e := NewExecutor("/tmp") e.vars["enabled"] = true result, err := e.moduleAssert(map[string]any{"that": "enabled"}, "host1") require.NoError(t, err) assert.False(t, result.Failed) assert.Equal(t, "All assertions passed", result.Msg) } func TestExecutorExtra_ModuleAssert_Bad_FailingAssertion(t *testing.T) { e := NewExecutor("/tmp") e.vars["enabled"] = false result, err := e.moduleAssert(map[string]any{"that": "enabled"}, "host1") require.NoError(t, err) assert.True(t, result.Failed) assert.Contains(t, result.Msg, "Assertion failed") } func TestExecutorExtra_ModuleAssert_Bad_MissingThat(t *testing.T) { e := NewExecutor("/tmp") _, err := e.moduleAssert(map[string]any{}, "host1") assert.Error(t, err) } func TestExecutorExtra_ModuleAssert_Good_CustomFailMsg(t *testing.T) { e := NewExecutor("/tmp") e.vars["ready"] = false result, err := e.moduleAssert(map[string]any{ "that": "ready", "fail_msg": "Service not ready", }, "host1") require.NoError(t, err) assert.True(t, result.Failed) assert.Equal(t, "Service not ready", result.Msg) } func TestExecutorExtra_ModuleAssert_Good_MultipleConditions(t *testing.T) { e := NewExecutor("/tmp") e.vars["enabled"] = true e.vars["count"] = 5 result, err := e.moduleAssert(map[string]any{ "that": []any{"enabled", "count"}, }, "host1") require.NoError(t, err) assert.False(t, result.Failed) } // --- moduleSetFact --- func TestExecutorExtra_ModuleSetFact_Good(t *testing.T) { e := NewExecutor("/tmp") result, err := e.moduleSetFact(map[string]any{ "app_version": "2.0.0", "deploy_env": "production", }) require.NoError(t, err) assert.True(t, result.Changed) assert.Equal(t, "2.0.0", e.vars["app_version"]) assert.Equal(t, "production", e.vars["deploy_env"]) } func TestExecutorExtra_ModuleSetFact_Good_SkipsCacheable(t *testing.T) { e := NewExecutor("/tmp") e.moduleSetFact(map[string]any{ "my_fact": "value", "cacheable": true, }) assert.Equal(t, "value", e.vars["my_fact"]) _, hasCacheable := e.vars["cacheable"] assert.False(t, hasCacheable) } // --- moduleAddHost --- func TestExecutorExtra_ModuleAddHost_Good_AddsHostAndGroups(t *testing.T) { e := NewExecutor("/tmp") result, err := e.moduleAddHost(map[string]any{ "name": "db1", "groups": "databases,production", "ansible_host": "10.0.0.5", "ansible_port": "2222", "ansible_user": "deploy", "ansible_connection": "ssh", "ansible_become_password": "secret", "environment": "prod", "custom_var": "custom-value", }) require.NoError(t, err) assert.True(t, result.Changed) assert.Equal(t, "db1", result.Data["host"]) assert.Contains(t, result.Msg, "db1") require.NotNil(t, e.inventory) require.NotNil(t, e.inventory.All) require.NotNil(t, e.inventory.All.Hosts["db1"]) host := e.inventory.All.Hosts["db1"] assert.Equal(t, "10.0.0.5", host.AnsibleHost) assert.Equal(t, 2222, host.AnsiblePort) assert.Equal(t, "deploy", host.AnsibleUser) assert.Equal(t, "ssh", host.AnsibleConnection) assert.Equal(t, "secret", host.AnsibleBecomePassword) assert.Equal(t, "custom-value", host.Vars["custom_var"]) require.NotNil(t, e.inventory.All.Children["databases"]) require.NotNil(t, e.inventory.All.Children["production"]) assert.Same(t, host, e.inventory.All.Children["databases"].Hosts["db1"]) assert.Same(t, host, e.inventory.All.Children["production"].Hosts["db1"]) assert.Equal(t, []string{"db1"}, GetHosts(e.inventory, "all")) assert.Equal(t, []string{"db1"}, GetHosts(e.inventory, "databases")) assert.Equal(t, []string{"db1"}, GetHosts(e.inventory, "production")) } func TestExecutorExtra_ModuleAddHost_Good_ThroughDispatcher(t *testing.T) { e := NewExecutor("/tmp") task := &Task{ Module: "add_host", Args: map[string]any{ "name": "cache1", "group": "caches", "role": "redis", }, } result, err := e.executeModule(context.Background(), "host1", &SSHClient{}, task, &Play{}) require.NoError(t, err) assert.True(t, result.Changed) assert.Equal(t, "cache1", result.Data["host"]) assert.Equal(t, []string{"caches"}, result.Data["groups"]) assert.Equal(t, []string{"cache1"}, GetHosts(e.inventory, "all")) assert.Equal(t, []string{"cache1"}, GetHosts(e.inventory, "caches")) assert.Equal(t, "redis", e.inventory.All.Hosts["cache1"].Vars["role"]) } // --- moduleGroupBy --- func TestExecutorExtra_ModuleGroupBy_Good(t *testing.T) { e := NewExecutor("/tmp") e.SetInventoryDirect(&Inventory{ All: &InventoryGroup{ Hosts: map[string]*Host{ "web1": &Host{AnsibleHost: "10.0.0.10"}, }, }, }) result, err := e.moduleGroupBy("web1", map[string]any{"key": "debian"}) require.NoError(t, err) assert.True(t, result.Changed) assert.Equal(t, "web1", result.Data["host"]) assert.Equal(t, "debian", result.Data["group"]) assert.Contains(t, result.Msg, "web1") assert.Contains(t, result.Msg, "debian") assert.Equal(t, []string{"web1"}, GetHosts(e.inventory, "debian")) } func TestExecutorExtra_ModuleGroupBy_Good_ThroughDispatcher(t *testing.T) { e, mock := newTestExecutorWithMock("host1") task := &Task{ Module: "group_by", Args: map[string]any{ "key": "linux", }, } result, err := executeModuleWithMock(e, mock, "host1", task) require.NoError(t, err) assert.True(t, result.Changed) assert.Equal(t, []string{"host1"}, GetHosts(e.inventory, "linux")) } func TestExecutorExtra_ModuleGroupBy_Bad_MissingKey(t *testing.T) { e := NewExecutor("/tmp") _, err := e.moduleGroupBy("host1", map[string]any{}) assert.Error(t, err) assert.Contains(t, err.Error(), "key required") } // --- moduleIncludeVars --- func TestExecutorExtra_ModuleIncludeVars_Good_WithFile(t *testing.T) { dir := t.TempDir() path := joinPath(dir, "main.yml") require.NoError(t, writeTestFile(path, []byte("app_name: demo\n"), 0644)) e := NewExecutor("/tmp") result, err := e.moduleIncludeVars(map[string]any{"file": path}) require.NoError(t, err) assert.True(t, result.Changed) assert.Contains(t, result.Msg, path) assert.Equal(t, "demo", e.vars["app_name"]) } func TestExecutorExtra_ModuleIncludeVars_Good_WithRawParams(t *testing.T) { dir := t.TempDir() path := joinPath(dir, "defaults.yml") require.NoError(t, writeTestFile(path, []byte("app_port: 8080\n"), 0644)) e := NewExecutor("/tmp") result, err := e.moduleIncludeVars(map[string]any{"_raw_params": path}) require.NoError(t, err) assert.True(t, result.Changed) assert.Contains(t, result.Msg, path) assert.Equal(t, 8080, e.vars["app_port"]) } func TestExecutorExtra_ModuleIncludeVars_Good_Empty(t *testing.T) { e := NewExecutor("/tmp") result, err := e.moduleIncludeVars(map[string]any{}) require.NoError(t, err) assert.False(t, result.Changed) } // --- moduleMeta --- func TestExecutorExtra_ModuleMeta_Good(t *testing.T) { e := NewExecutor("/tmp") result, err := e.moduleMeta(map[string]any{"_raw_params": "flush_handlers"}) require.NoError(t, err) assert.False(t, result.Changed) require.NotNil(t, result.Data) assert.Equal(t, "flush_handlers", result.Data["action"]) } func TestExecutorExtra_ModuleMeta_Good_ClearFacts(t *testing.T) { e := NewExecutor("/tmp") e.facts["host1"] = &Facts{Hostname: "web01"} result, err := e.moduleMeta(map[string]any{"_raw_params": "clear_facts"}) require.NoError(t, err) assert.True(t, result.Changed) require.NotNil(t, result.Data) assert.Equal(t, "clear_facts", result.Data["action"]) } func TestExecutorExtra_ModuleMeta_Good_ResetConnection(t *testing.T) { e := NewExecutor("/tmp") result, err := e.moduleMeta(map[string]any{"_raw_params": "reset_connection"}) require.NoError(t, err) assert.False(t, result.Changed) require.NotNil(t, result.Data) assert.Equal(t, "reset_connection", result.Data["action"]) } func TestExecutorExtra_ModuleMeta_Good_EndHost(t *testing.T) { e := NewExecutor("/tmp") result, err := e.moduleMeta(map[string]any{"_raw_params": "end_host"}) require.NoError(t, err) assert.False(t, result.Changed) require.NotNil(t, result.Data) assert.Equal(t, "end_host", result.Data["action"]) } func TestExecutorExtra_HandleMetaAction_Good_ClearFacts(t *testing.T) { e := NewExecutor("/tmp") e.facts["host1"] = &Facts{Hostname: "web01"} e.facts["host2"] = &Facts{Hostname: "web02"} result := &TaskResult{Data: map[string]any{"action": "clear_facts"}} require.NoError(t, e.handleMetaAction(context.Background(), "host1", []string{"host1"}, nil, result)) _, ok := e.facts["host1"] assert.False(t, ok) require.NotNil(t, e.facts["host2"]) assert.Equal(t, "web02", e.facts["host2"].Hostname) } func TestExecutorExtra_HandleMetaAction_Good_EndHost(t *testing.T) { e := NewExecutor("/tmp") result := &TaskResult{Data: map[string]any{"action": "end_host"}} err := e.handleMetaAction(context.Background(), "host1", []string{"host1", "host2"}, nil, result) require.ErrorIs(t, err, errEndHost) assert.True(t, e.isHostEnded("host1")) assert.False(t, e.isHostEnded("host2")) } func TestExecutorExtra_HandleMetaAction_Good_ResetConnection(t *testing.T) { e := NewExecutor("/tmp") mock := NewMockSSHClient() e.clients["host1"] = mock e.clients["host2"] = NewMockSSHClient() result := &TaskResult{Data: map[string]any{"action": "reset_connection"}} require.NoError(t, e.handleMetaAction(context.Background(), "host1", []string{"host1", "host2"}, nil, result)) _, ok := e.clients["host1"] assert.False(t, ok) _, ok = e.clients["host2"] assert.True(t, ok) assert.True(t, mock.closed) } func TestExecutorExtra_RunTaskOnHosts_Good_EndHostSkipsFutureTasks(t *testing.T) { e := NewExecutor("/tmp") e.SetInventoryDirect(&Inventory{ All: &InventoryGroup{ Hosts: map[string]*Host{ "host1": {Vars: map[string]any{"retire_host": true}}, "host2": {Vars: map[string]any{"retire_host": false}}, }, }, }) e.clients["host1"] = NewMockSSHClient() e.clients["host2"] = NewMockSSHClient() var started []string e.OnTaskStart = func(host string, task *Task) { started = append(started, host+":"+task.Name) } play := &Play{} first := &Task{ Name: "Retire host", Module: "meta", Args: map[string]any{"_raw_params": "end_host"}, When: "retire_host", } require.NoError(t, e.runTaskOnHosts(context.Background(), []string{"host1", "host2"}, first, play)) assert.True(t, e.isHostEnded("host1")) assert.False(t, e.isHostEnded("host2")) second := &Task{ Name: "Follow-up", Module: "debug", Args: map[string]any{"msg": "still running"}, } require.NoError(t, e.runTaskOnHosts(context.Background(), []string{"host1", "host2"}, second, play)) assert.Contains(t, started, "host1:Retire host") assert.Contains(t, started, "host2:Follow-up") assert.NotContains(t, started, "host1:Follow-up") } // ============================================================ // Tests for handleLookup (0% coverage) // ============================================================ func TestExecutorExtra_HandleLookup_Good_EnvVar(t *testing.T) { e := NewExecutor("/tmp") t.Setenv("TEST_ANSIBLE_LOOKUP", "found_it") result := e.handleLookup("lookup('env', 'TEST_ANSIBLE_LOOKUP')") assert.Equal(t, "found_it", result) } func TestExecutorExtra_HandleLookup_Good_EnvVarMissing(t *testing.T) { e := NewExecutor("/tmp") result := e.handleLookup("lookup('env', 'NONEXISTENT_VAR_12345')") assert.Equal(t, "", result) } func TestExecutorExtra_HandleLookup_Bad_InvalidSyntax(t *testing.T) { e := NewExecutor("/tmp") result := e.handleLookup("lookup(invalid)") assert.Equal(t, "", result) } // ============================================================ // Tests for SetInventory (0% coverage) // ============================================================ func TestExecutorExtra_SetInventory_Good(t *testing.T) { dir := t.TempDir() invPath := joinPath(dir, "inventory.yml") yaml := `all: hosts: web1: ansible_host: 10.0.0.1 web2: ansible_host: 10.0.0.2 ` require.NoError(t, writeTestFile(invPath, []byte(yaml), 0644)) e := NewExecutor(dir) err := e.SetInventory(invPath) require.NoError(t, err) assert.NotNil(t, e.inventory) assert.Len(t, e.inventory.All.Hosts, 2) } func TestExecutorExtra_SetInventory_Bad_FileNotFound(t *testing.T) { e := NewExecutor("/tmp") err := e.SetInventory("/nonexistent/inventory.yml") assert.Error(t, err) } // ============================================================ // Tests for iterator functions (0% coverage) // ============================================================ func TestExecutorExtra_ParsePlaybookIter_Good(t *testing.T) { dir := t.TempDir() path := joinPath(dir, "playbook.yml") yaml := `- name: First play hosts: all tasks: - debug: msg: hello - name: Second play hosts: localhost tasks: - debug: msg: world ` require.NoError(t, writeTestFile(path, []byte(yaml), 0644)) p := NewParser(dir) iter, err := p.ParsePlaybookIter(path) require.NoError(t, err) var plays []Play for play := range iter { plays = append(plays, play) } assert.Len(t, plays, 2) assert.Equal(t, "First play", plays[0].Name) assert.Equal(t, "Second play", plays[1].Name) } func TestExecutorExtra_ParsePlaybookIter_Bad_InvalidFile(t *testing.T) { _, err := NewParser("/tmp").ParsePlaybookIter("/nonexistent.yml") assert.Error(t, err) } func TestExecutorExtra_ParseTasksIter_Good(t *testing.T) { dir := t.TempDir() path := joinPath(dir, "tasks.yml") yaml := `- name: Task one debug: msg: first - name: Task two debug: msg: second ` require.NoError(t, writeTestFile(path, []byte(yaml), 0644)) p := NewParser(dir) iter, err := p.ParseTasksIter(path) require.NoError(t, err) var tasks []Task for task := range iter { tasks = append(tasks, task) } assert.Len(t, tasks, 2) assert.Equal(t, "Task one", tasks[0].Name) } func TestExecutorExtra_ParseTasksIter_Bad_InvalidFile(t *testing.T) { _, err := NewParser("/tmp").ParseTasksIter("/nonexistent.yml") assert.Error(t, err) } func TestExecutorExtra_GetHostsIter_Good(t *testing.T) { inv := &Inventory{ All: &InventoryGroup{ Hosts: map[string]*Host{ "web1": {}, "web2": {}, "db1": {}, }, }, } var hosts []string for host := range GetHostsIter(inv, "all") { hosts = append(hosts, host) } assert.Len(t, hosts, 3) } func TestExecutorExtra_AllHostsIter_Good(t *testing.T) { group := &InventoryGroup{ Hosts: map[string]*Host{ "alpha": {}, "beta": {}, }, Children: map[string]*InventoryGroup{ "db": { Hosts: map[string]*Host{ "gamma": {}, }, }, }, } var hosts []string for host := range AllHostsIter(group) { hosts = append(hosts, host) } assert.Len(t, hosts, 3) // AllHostsIter sorts keys assert.Equal(t, "alpha", hosts[0]) assert.Equal(t, "beta", hosts[1]) assert.Equal(t, "gamma", hosts[2]) } func TestExecutorExtra_AllHostsIter_Good_NilGroup(t *testing.T) { var count int for range AllHostsIter(nil) { count++ } assert.Equal(t, 0, count) } // ============================================================ // Tests for resolveExpr with registered vars (additional coverage) // ============================================================ func TestExecutorExtra_ResolveExpr_Good_RegisteredVarFields(t *testing.T) { e := NewExecutor("/tmp") e.results["host1"] = map[string]*TaskResult{ "cmd_result": { Stdout: "output text", Stderr: "error text", RC: 0, Changed: true, Failed: false, }, } assert.Equal(t, "output text", e.resolveExpr("cmd_result.stdout", "host1", nil)) assert.Equal(t, "error text", e.resolveExpr("cmd_result.stderr", "host1", nil)) assert.Equal(t, "0", e.resolveExpr("cmd_result.rc", "host1", nil)) assert.Equal(t, "true", e.resolveExpr("cmd_result.changed", "host1", nil)) assert.Equal(t, "false", e.resolveExpr("cmd_result.failed", "host1", nil)) } func TestExecutorExtra_ResolveExpr_Good_TaskVars(t *testing.T) { e := NewExecutor("/tmp") task := &Task{ Vars: map[string]any{"local_var": "local_value"}, } result := e.resolveExpr("local_var", "host1", task) assert.Equal(t, "local_value", result) } func TestExecutorExtra_ResolveExpr_Good_HostVars(t *testing.T) { e := NewExecutor("/tmp") e.SetInventoryDirect(&Inventory{ All: &InventoryGroup{ Hosts: map[string]*Host{ "host1": {AnsibleHost: "10.0.0.1"}, }, }, }) result := e.resolveExpr("ansible_host", "host1", nil) assert.Equal(t, "10.0.0.1", result) } func TestExecutorExtra_ResolveExpr_Good_Facts(t *testing.T) { e := NewExecutor("/tmp") e.facts["host1"] = &Facts{ Hostname: "web01", FQDN: "web01.example.com", Distribution: "ubuntu", Version: "22.04", Architecture: "x86_64", Kernel: "5.15.0", } assert.Equal(t, "web01", e.resolveExpr("ansible_hostname", "host1", nil)) assert.Equal(t, "web01.example.com", e.resolveExpr("ansible_fqdn", "host1", nil)) assert.Equal(t, "ubuntu", e.resolveExpr("ansible_distribution", "host1", nil)) assert.Equal(t, "22.04", e.resolveExpr("ansible_distribution_version", "host1", nil)) assert.Equal(t, "x86_64", e.resolveExpr("ansible_architecture", "host1", nil)) assert.Equal(t, "5.15.0", e.resolveExpr("ansible_kernel", "host1", nil)) } // --- applyFilter additional coverage --- func TestExecutorExtra_ApplyFilter_Good_B64Decode(t *testing.T) { e := NewExecutor("/tmp") assert.Equal(t, "hello", e.applyFilter("aGVsbG8=", "b64decode")) } func TestExecutorExtra_ApplyFilter_Good_UnknownFilter(t *testing.T) { e := NewExecutor("/tmp") assert.Equal(t, "value", e.applyFilter("value", "unknown_filter")) } // --- evalCondition with default filter --- func TestExecutorExtra_EvalCondition_Good_DefaultFilter(t *testing.T) { e := NewExecutor("/tmp") assert.True(t, e.evalCondition("myvar | default('fallback')", "host1")) } func TestExecutorExtra_EvalCondition_Good_UndefinedCheck(t *testing.T) { e := NewExecutor("/tmp") assert.True(t, e.evalCondition("missing_var is not defined", "host1")) assert.True(t, e.evalCondition("missing_var is undefined", "host1")) } // --- resolveExpr with filter pipe --- func TestExecutorExtra_ResolveExpr_Good_WithFilter(t *testing.T) { e := NewExecutor("/tmp") e.vars["raw_value"] = " trimmed " result := e.resolveExpr("raw_value | trim", "host1", nil) assert.Equal(t, "trimmed", result) }