From b7428496bd55134decd56230e728d2e2e693e82a Mon Sep 17 00:00:00 2001 From: Virgil Date: Sat, 4 Apr 2026 22:35:02 +0000 Subject: [PATCH] refactor(p2p): reuse build-version helper in handshake validation Co-Authored-By: Charon --- p2p/handshake.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/p2p/handshake.go b/p2p/handshake.go index 33b9da0..c6b3a97 100644 --- a/p2p/handshake.go +++ b/p2p/handshake.go @@ -192,8 +192,8 @@ func ValidateHandshakeResponse(resp *HandshakeResponse, expectedNetworkID [16]by return fmt.Errorf("p2p: peer build %q is malformed", resp.PayloadData.ClientVersion) } - minBuild := MinimumRequiredBuildVersion(isTestnet) - if buildVersion < minBuild { + if !MeetsMinimumBuildVersion(resp.PayloadData.ClientVersion, isTestnet) { + minBuild := MinimumRequiredBuildVersion(isTestnet) return fmt.Errorf("p2p: peer build %q parsed as %d below minimum %d", resp.PayloadData.ClientVersion, buildVersion, minBuild) }