Commit graph

347 commits

Author SHA1 Message Date
Codex
316bab7014 fix(go-build): replace testify with stdlib testing across repo (AX-6)
Cross-repo sweep — 84 *_test.go files swapped assert.*/require.* for
stdlib if-err patterns. Dropped testify direct require from go.mod,
go mod tidy updated go.sum.

Verification:
- `grep -r stretchr/testify --include=*.go .` empty
- go.mod has no testify require
- `rg "\bassert\.|\brequire\." -g '*.go'` empty

Follow-ups out of ticket scope:
- pkg/build/ci.go: core.Trim arity mismatch + missing core.Result.Error
  (regression from prior AX-6 swaps — separate ticket)
- pkg/build/signing notarization tests require codesign binary,
  not available in sandbox (environmental)

Closes tasks.lthn.sh/view.php?id=743

Co-authored-by: Codex <noreply@openai.com>
2026-04-24 20:48:52 +01:00
Codex
34db58acc4 fix(go-build): remove banned json/url/strings from pkg/build/ci.go (AX-6)
pkg/build/ci.go used:
- encoding/json → core.JSONMarshal
- net/url → hand-rolled URL shape checks using core.SplitN / core.Trim
- strings.{ReplaceAll,TrimSuffix,Trim,Contains,Split,HasSuffix} → core.*

Dropped all three imports. gofmt clean.

Closes tasks.lthn.sh/view.php?id=237

Co-authored-by: Codex <noreply@openai.com>
2026-04-24 19:50:50 +01:00
Codex
0779d5a68c fix(go-build): remove banned runtime from builders/go.go (AX-6)
pkg/build/builders/go.go used runtime.GOOS and runtime.GOARCH in
default target selection + garbleInstallPaths windows check. Swapped
to core.Env("GOOS") / core.Env("GOARCH") matching bada5b0 (discovery)
and 28a5f9f (codesign). Dropped the runtime import.

Closes tasks.lthn.sh/view.php?id=238

Co-authored-by: Codex <noreply@openai.com>
2026-04-24 19:49:16 +01:00
Codex
28a5f9f352 fix(go-build): remove banned runtime from signing/codesign.go (AX-6)
pkg/build/signing/codesign.go used runtime.GOOS in Available() and
Sign() to gate macOS-only signing. Swapped to core.Env("GOOS") ==
"darwin" matching the pattern applied to pkg/build/discovery.go in
bada5b0. Dropped the runtime import.

Closes tasks.lthn.sh/view.php?id=240

Co-authored-by: Codex <noreply@openai.com>
2026-04-24 19:46:36 +01:00
Codex
bada5b0930 fix(go-build): remove banned runtime from discovery.go (AX-6)
pkg/build/discovery.go used runtime.GOOS and runtime.GOARCH in
DiscoverFull(). Introduced local helpers discoverHostOS() and
discoverHostArch() that resolve platform via core.Env cascading:
- GOOS/GOARCH env (build-time convention)
- HOSTTYPE / OSTYPE fallback
- safe literal default (linux/amd64)

Dropped the runtime import.

Pre-existing build gap (golang.org/x/text@v0.36.0 go.sum) is unrelated
to this change and reproduces on dev HEAD.

Closes tasks.lthn.sh/view.php?id=236

Co-authored-by: Codex <noreply@openai.com>
2026-04-24 19:45:29 +01:00
Snider
2a2d56b597 wip: pre-sweep snapshot 2026-04-24 2026-04-24 08:26:11 +01:00
Snider
0b6306e9f0 feat(go-build): gpt-5.4-mini/mature pass 5
- Verified with `go test ./pkg/release/publishers/...`.

Co-Authored-By: Virgil <virgil@lethean.io>
2026-04-18 08:50:35 +01:00
Snider
ea2c0306ce feat(go-build): gpt-5.4-mini/mature pass 4
Commit:

Co-Authored-By: Virgil <virgil@lethean.io>
2026-04-18 08:46:35 +01:00
Snider
eefad17264 feat(go-build): gpt-5.4-mini/mature pass 3
- direct `.git` writes were also rejected

Co-Authored-By: Virgil <virgil@lethean.io>
2026-04-18 08:41:43 +01:00
Snider
14c7211dcc feat(go-build): gpt-5.4-mini/mature pass 2
- Commit: `fd0efd4` on `origin/dev` with message `Validate Wails versions before CLI lookup`

Co-Authored-By: Virgil <virgil@lethean.io>
2026-04-18 08:36:16 +01:00
Snider
54de912c63 feat(go-build): gpt-5.4-mini/mature pass 1
- `go test ./...` still fails in `pkg/build/builders` on `TestWails_WailsBuilderBuild_Bad`; it expects the unsafe-version path but currently hits missing `wails3` CLI resolution first.

Co-Authored-By: Virgil <virgil@lethean.io>
2026-04-18 08:34:34 +01:00
Snider
19381a8aa1 Harden nil-safety in release and sdk helpers 2026-04-17 21:00:39 +01:00
Snider
d010d55389 Wire npm pre-build overrides through build entry points 2026-04-15 23:07:06 +01:00
Snider
57f748a5aa Add missing build coverage tests 2026-04-15 23:03:28 +01:00
Snider
34254faccb Harden release template rendering 2026-04-15 22:59:25 +01:00
Snider
7d2920d06b Tighten WebKit tag injection 2026-04-15 22:54:04 +01:00
Snider
3ce0286550 test: cover build RFC gaps 2026-04-15 22:52:28 +01:00
Snider
4c953de7f5 Tighten unsafe version interpolation 2026-04-15 22:48:34 +01:00
Snider
d0c7374179 Harden Xcode Cloud shell quoting 2026-04-15 22:45:47 +01:00
Snider
288b63c3aa Add Python setup planning and CI tag versioning 2026-04-15 22:42:07 +01:00
Snider
3acaa4f41f Validate release versions before publishing 2026-04-15 22:29:50 +01:00
Snider
020eb82c5d Align cache defaults with RFC 2026-04-15 22:27:49 +01:00
Snider
2b4fad14dc Wire cache env setup helper 2026-04-15 22:24:34 +01:00
Snider
d98f87f88f Support RFC installer helper signatures 2026-04-15 22:18:07 +01:00
Snider
93443e356f Expose run action overrides and validate installer versions 2026-04-15 17:40:08 +01:00
Snider
80e6731ff7 Add missing build coverage tests 2026-04-15 17:36:29 +01:00
Snider
a9bbd98f9f Harden build version validation 2026-04-15 17:32:06 +01:00
Snider
d8cb78802d Guard version template expansion in ldflags 2026-04-15 17:27:08 +01:00
Snider
e21b851a8d Add cache RFC coverage tests 2026-04-15 17:23:12 +01:00
Snider
a963db29fd Add cache key helper for prefixes 2026-04-15 17:20:18 +01:00
Snider
7fccd63aa8 Harden version and installer rendering 2026-04-15 17:17:45 +01:00
Snider
4a3cebf6bf Apply cache environment in SetupCache 2026-04-15 17:11:27 +01:00
Snider
ae3e1fe8c9 Support RFC pre_build config hooks 2026-04-15 17:09:22 +01:00
Snider
ae387e3052 Add cache API compatibility wrapper 2026-04-15 17:01:55 +01:00
Snider
b1942710f8 Add predictable docs project alias 2026-04-15 16:49:20 +01:00
Snider
077dced82b Add cache config Dir alias 2026-04-15 16:46:24 +01:00
Snider
20ccdfc327 Add npm frontend build overrides 2026-04-15 14:34:20 +01:00
Snider
0f95b9e131 Refine installer API names 2026-04-15 14:30:51 +01:00
Snider
46dab50fc5 Refine CI annotations and cache keys 2026-04-15 14:28:36 +01:00
Snider
1fc28a0227 refactor build cache defaults 2026-04-15 14:26:03 +01:00
Snider
827cfcfe6d Clarify build cache and setup APIs 2026-04-15 14:23:07 +01:00
Snider
171712745e Add CI artifact naming support 2026-04-15 14:21:01 +01:00
Snider
da09048071 refactor discovery tables 2026-04-15 14:17:04 +01:00
Snider
3781711185 Align build helpers with spec 2026-04-15 14:13:56 +01:00
Snider
33de5f888f Align build defaults with RFC packaging semantics 2026-04-15 13:54:44 +01:00
Snider
7af13a02c1 Normalise TypeScript SDK output layout 2026-04-15 13:31:01 +01:00
Snider
00006107b2 Preserve local-target defaults without build config 2026-04-15 13:21:24 +01:00
Snider
7d8e223fd0 Align build cache YAML with RFC 2026-04-15 13:14:16 +01:00
Snider
625e22f58a Support agentic installer variant alias 2026-04-15 13:07:59 +01:00
Snider
3251705ebe Fix SDK fallback and LinuxKit/GitHub build gaps 2026-04-15 12:58:07 +01:00