316bab7014
Cross-repo sweep — 84 *_test.go files swapped assert.*/require.* for stdlib if-err patterns. Dropped testify direct require from go.mod, go mod tidy updated go.sum. Verification: - `grep -r stretchr/testify --include=*.go .` empty - go.mod has no testify require - `rg "\bassert\.|\brequire\." -g '*.go'` empty Follow-ups out of ticket scope: - pkg/build/ci.go: core.Trim arity mismatch + missing core.Result.Error (regression from prior AX-6 swaps — separate ticket) - pkg/build/signing notarization tests require codesign binary, not available in sandbox (environmental) Closes tasks.lthn.sh/view.php?id=743 Co-authored-by: Codex <noreply@openai.com>
481 lines
14 KiB
Go
481 lines
14 KiB
Go
package build
|
|
|
|
import (
|
|
"os"
|
|
"testing"
|
|
|
|
"dappco.re/go/core/io"
|
|
)
|
|
|
|
func TestCache_SetupCache_Good(t *testing.T) {
|
|
fs := io.NewMemoryMedium()
|
|
cfg := &CacheConfig{
|
|
Enabled: true,
|
|
Paths: []string{
|
|
"cache/go-build",
|
|
"cache/go-mod",
|
|
},
|
|
}
|
|
|
|
err := SetupCache(fs, "/workspace/project", cfg)
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
if stdlibAssertNil(cfg) {
|
|
t.Fatal("expected non-nil")
|
|
}
|
|
if !stdlibAssertEqual("/workspace/project/.core/cache", cfg.Directory) {
|
|
t.Fatalf("want %v, got %v", "/workspace/project/.core/cache", cfg.Directory)
|
|
}
|
|
if !stdlibAssertEqual([]string{"/workspace/project/cache/go-build", "/workspace/project/cache/go-mod"}, cfg.Paths) {
|
|
t.Fatalf("want %v, got %v", []string{"/workspace/project/cache/go-build", "/workspace/project/cache/go-mod"}, cfg.Paths)
|
|
}
|
|
if !(fs.Exists("/workspace/project/.core/cache")) {
|
|
t.Fatal("expected true")
|
|
}
|
|
if !(fs.Exists("/workspace/project/cache/go-build")) {
|
|
t.Fatal("expected true")
|
|
}
|
|
if !(fs.Exists("/workspace/project/cache/go-mod")) {
|
|
t.Fatal("expected true")
|
|
}
|
|
|
|
}
|
|
|
|
func TestCache_SetupBuildCache_Good(t *testing.T) {
|
|
fs := io.NewMemoryMedium()
|
|
cfg := &BuildConfig{
|
|
Build: Build{
|
|
Cache: CacheConfig{
|
|
Enabled: true,
|
|
Paths: []string{
|
|
"cache/go-build",
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
err := SetupBuildCache(fs, "/workspace/project", cfg)
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
if stdlibAssertNil(cfg) {
|
|
t.Fatal("expected non-nil")
|
|
}
|
|
if !stdlibAssertEqual("/workspace/project/.core/cache", cfg.Build.Cache.Directory) {
|
|
t.Fatalf("want %v, got %v", "/workspace/project/.core/cache", cfg.Build.Cache.Directory)
|
|
}
|
|
if !stdlibAssertEqual([]string{"/workspace/project/cache/go-build"}, cfg.Build.Cache.Paths) {
|
|
t.Fatalf("want %v, got %v", []string{"/workspace/project/cache/go-build"}, cfg.Build.Cache.Paths)
|
|
}
|
|
if !(fs.Exists("/workspace/project/.core/cache")) {
|
|
t.Fatal("expected true")
|
|
}
|
|
if !(fs.Exists("/workspace/project/cache/go-build")) {
|
|
t.Fatal("expected true")
|
|
}
|
|
|
|
}
|
|
|
|
func TestCache_SetupCache_Good_DefaultPathsWhenEnabled(t *testing.T) {
|
|
fs := io.NewMemoryMedium()
|
|
cfg := &CacheConfig{
|
|
Enabled: true,
|
|
}
|
|
|
|
err := SetupCache(fs, "/workspace/project", cfg)
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
if stdlibAssertNil(cfg) {
|
|
t.Fatal("expected non-nil")
|
|
}
|
|
if !stdlibAssertEqual("/workspace/project/.core/cache", cfg.Directory) {
|
|
t.Fatalf("want %v, got %v", "/workspace/project/.core/cache", cfg.Directory)
|
|
}
|
|
if !stdlibAssertEqual([]string{"/workspace/project/cache/go-build", "/workspace/project/cache/go-mod"}, cfg.Paths) {
|
|
t.Fatalf("want %v, got %v", []string{"/workspace/project/cache/go-build", "/workspace/project/cache/go-mod"}, cfg.Paths)
|
|
}
|
|
if !(fs.Exists("/workspace/project/.core/cache")) {
|
|
t.Fatal("expected true")
|
|
}
|
|
if !(fs.Exists("/workspace/project/cache/go-build")) {
|
|
t.Fatal("expected true")
|
|
}
|
|
if !(fs.Exists("/workspace/project/cache/go-mod")) {
|
|
t.Fatal("expected true")
|
|
}
|
|
|
|
}
|
|
|
|
func TestCache_SetupBuildCache_Good_DefaultPathsWhenEnabled(t *testing.T) {
|
|
fs := io.NewMemoryMedium()
|
|
cfg := &BuildConfig{
|
|
Build: Build{
|
|
Cache: CacheConfig{
|
|
Enabled: true,
|
|
},
|
|
},
|
|
}
|
|
|
|
err := SetupBuildCache(fs, "/workspace/project", cfg)
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
if stdlibAssertNil(cfg) {
|
|
t.Fatal("expected non-nil")
|
|
}
|
|
if !stdlibAssertEqual("/workspace/project/.core/cache", cfg.Build.Cache.Directory) {
|
|
t.Fatalf("want %v, got %v", "/workspace/project/.core/cache", cfg.Build.Cache.Directory)
|
|
}
|
|
if !stdlibAssertEqual([]string{"/workspace/project/cache/go-build", "/workspace/project/cache/go-mod"}, cfg.Build.Cache.Paths) {
|
|
t.Fatalf("want %v, got %v", []string{"/workspace/project/cache/go-build", "/workspace/project/cache/go-mod"}, cfg.Build.Cache.Paths)
|
|
}
|
|
if !(fs.Exists("/workspace/project/.core/cache")) {
|
|
t.Fatal("expected true")
|
|
}
|
|
if !(fs.Exists("/workspace/project/cache/go-build")) {
|
|
t.Fatal("expected true")
|
|
}
|
|
if !(fs.Exists("/workspace/project/cache/go-mod")) {
|
|
t.Fatal("expected true")
|
|
}
|
|
|
|
}
|
|
|
|
func TestCache_SetupCache_Good_Disabled(t *testing.T) {
|
|
fs := io.NewMemoryMedium()
|
|
cfg := &CacheConfig{
|
|
Enabled: false,
|
|
Paths: []string{"cache/go-build"},
|
|
}
|
|
|
|
err := SetupCache(fs, "/workspace/project", cfg)
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
if fs.Exists("/workspace/project/.core/cache") {
|
|
t.Fatal("expected false")
|
|
}
|
|
if fs.Exists("/workspace/project/cache/go-build") {
|
|
t.Fatal("expected false")
|
|
}
|
|
if !stdlibAssertEmpty(cfg.Directory) {
|
|
t.Fatalf("expected empty, got %v", cfg.Directory)
|
|
}
|
|
if !stdlibAssertEqual([]string{"cache/go-build"}, cfg.Paths) {
|
|
t.Fatalf("want %v, got %v", []string{"cache/go-build"}, cfg.Paths)
|
|
}
|
|
|
|
}
|
|
|
|
func TestCache_SetupCache_Bad(t *testing.T) {
|
|
t.Run("rejects invalid arity", func(t *testing.T) {
|
|
err := SetupCache()
|
|
if err == nil {
|
|
t.Fatal("expected error")
|
|
}
|
|
if !stdlibAssertContains(err.Error(), "expected 1 or 3 arguments") {
|
|
t.Fatalf("expected %v to contain %v", err.Error(), "expected 1 or 3 arguments")
|
|
}
|
|
|
|
})
|
|
|
|
t.Run("rejects a non-cache third argument", func(t *testing.T) {
|
|
fs := io.NewMemoryMedium()
|
|
err := SetupCache(fs, "/workspace/project", CacheConfig{})
|
|
if err == nil {
|
|
t.Fatal("expected error")
|
|
}
|
|
if !stdlibAssertContains(err.Error(), "third argument must be *CacheConfig") {
|
|
t.Fatalf("expected %v to contain %v", err.Error(), "third argument must be *CacheConfig")
|
|
}
|
|
|
|
})
|
|
}
|
|
|
|
func TestCache_SetupCache_Ugly(t *testing.T) {
|
|
t.Run("normalises home and absolute cache paths", func(t *testing.T) {
|
|
t.Setenv("HOME", "/home/tester")
|
|
|
|
fs := io.NewMemoryMedium()
|
|
cfg := &CacheConfig{
|
|
Enabled: true,
|
|
Paths: []string{
|
|
"~/cache/go-build",
|
|
"~",
|
|
"/var/cache/go-mod",
|
|
"/var/cache/go-mod",
|
|
"",
|
|
},
|
|
}
|
|
|
|
err := SetupCache(fs, "/workspace/project", cfg)
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
if !stdlibAssertEqual("/workspace/project/.core/cache", cfg.Directory) {
|
|
t.Fatalf("want %v, got %v", "/workspace/project/.core/cache", cfg.Directory)
|
|
}
|
|
if !stdlibAssertEqual([]string{"/home/tester/cache/go-build", "/home/tester", "/var/cache/go-mod"}, cfg.Paths) {
|
|
t.Fatalf("want %v, got %v", []string{"/home/tester/cache/go-build", "/home/tester", "/var/cache/go-mod"}, cfg.Paths)
|
|
}
|
|
if !(fs.Exists("/workspace/project/.core/cache")) {
|
|
t.Fatal("expected true")
|
|
}
|
|
if !(fs.Exists("/home/tester/cache/go-build")) {
|
|
t.Fatal("expected true")
|
|
}
|
|
if !(fs.Exists("/home/tester")) {
|
|
t.Fatal("expected true")
|
|
}
|
|
if !(fs.Exists("/var/cache/go-mod")) {
|
|
t.Fatal("expected true")
|
|
}
|
|
|
|
})
|
|
|
|
t.Run("1-argument form wires process cache environment", func(t *testing.T) {
|
|
t.Setenv("GOCACHE", "before")
|
|
t.Setenv("GOMODCACHE", "before")
|
|
|
|
err := SetupCache(CacheConfig{
|
|
Enabled: true,
|
|
Paths: []string{
|
|
"/tmp/cache/go-build",
|
|
"/tmp/cache/go-mod",
|
|
},
|
|
})
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
if !stdlibAssertEqual("/tmp/cache/go-build", os.Getenv("GOCACHE")) {
|
|
t.Fatalf("want %v, got %v", "/tmp/cache/go-build", os.Getenv("GOCACHE"))
|
|
}
|
|
if !stdlibAssertEqual("/tmp/cache/go-mod", os.Getenv("GOMODCACHE")) {
|
|
t.Fatalf("want %v, got %v", "/tmp/cache/go-mod", os.Getenv("GOMODCACHE"))
|
|
}
|
|
|
|
})
|
|
}
|
|
|
|
func TestCache_SetupBuildCache_Good_Disabled(t *testing.T) {
|
|
fs := io.NewMemoryMedium()
|
|
cfg := &BuildConfig{
|
|
Build: Build{
|
|
Cache: CacheConfig{
|
|
Enabled: false,
|
|
Paths: []string{"cache/go-build"},
|
|
},
|
|
},
|
|
}
|
|
|
|
err := SetupBuildCache(fs, "/workspace/project", cfg)
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
if fs.Exists("/workspace/project/.core/cache") {
|
|
t.Fatal("expected false")
|
|
}
|
|
if !stdlibAssertEmpty(cfg.Build.Cache.Directory) {
|
|
t.Fatalf("expected empty, got %v", cfg.Build.Cache.Directory)
|
|
}
|
|
if !stdlibAssertEqual([]string{"cache/go-build"}, cfg.Build.Cache.Paths) {
|
|
t.Fatalf("want %v, got %v", []string{"cache/go-build"}, cfg.Build.Cache.Paths)
|
|
}
|
|
|
|
}
|
|
|
|
func TestCache_SetupBuildCache_Bad(t *testing.T) {
|
|
t.Run("nil filesystem is a no-op", func(t *testing.T) {
|
|
cfg := &BuildConfig{
|
|
Build: Build{
|
|
Cache: CacheConfig{Enabled: true},
|
|
},
|
|
}
|
|
|
|
err := SetupBuildCache(nil, "/workspace/project", cfg)
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
if !stdlibAssertEmpty(cfg.Build.Cache.Directory) {
|
|
t.Fatalf("expected empty, got %v", cfg.Build.Cache.Directory)
|
|
}
|
|
if !stdlibAssertEmpty(cfg.Build.Cache.Paths) {
|
|
t.Fatalf("expected empty, got %v", cfg.Build.Cache.Paths)
|
|
}
|
|
|
|
})
|
|
|
|
t.Run("nil config is a no-op", func(t *testing.T) {
|
|
fs := io.NewMemoryMedium()
|
|
|
|
err := SetupBuildCache(fs, "/workspace/project", nil)
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
|
|
})
|
|
}
|
|
|
|
func TestCache_CacheKey_Good(t *testing.T) {
|
|
fs := io.NewMemoryMedium()
|
|
if err := fs.Write("/workspace/project/go.sum", "module.example v1.0.0 h1:abc123"); err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
if err := fs.Write("/workspace/project/go.work.sum", "workspace.example v1.0.0 h1:def456"); err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
|
|
first := CacheKey(fs, "/workspace/project", "linux", "amd64")
|
|
second := CacheKey(fs, "/workspace/project", "linux", "amd64")
|
|
third := CacheKey(fs, "/workspace/project", "darwin", "arm64")
|
|
if !stdlibAssertEqual(first, second) {
|
|
t.Fatalf("want %v, got %v", first, second)
|
|
}
|
|
if stdlibAssertEqual(first, third) {
|
|
t.Fatalf("did not want %v", third)
|
|
}
|
|
if !stdlibAssertContains(first, "go-linux-amd64-") {
|
|
t.Fatalf("expected %v to contain %v", first, "go-linux-amd64-")
|
|
}
|
|
|
|
}
|
|
|
|
func TestCache_CacheKey_Good_GoWorkSumChangesKey(t *testing.T) {
|
|
fs := io.NewMemoryMedium()
|
|
if err := fs.Write("/workspace/project/go.sum", "module.example v1.0.0 h1:abc123"); err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
|
|
baseline := CacheKey(fs, "/workspace/project", "linux", "amd64")
|
|
if err := fs.Write("/workspace/project/go.work.sum", "workspace.example v1.0.0 h1:def456"); err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
|
|
updated := CacheKey(fs, "/workspace/project", "linux", "amd64")
|
|
if stdlibAssertEqual(baseline, updated) {
|
|
t.Fatalf("did not want %v", updated)
|
|
}
|
|
|
|
}
|
|
|
|
func TestCache_CacheEnvironment_Good(t *testing.T) {
|
|
t.Run("maps cache directory and Go cache paths to env vars", func(t *testing.T) {
|
|
env := CacheEnvironment(&CacheConfig{
|
|
Enabled: true,
|
|
Paths: []string{
|
|
"/workspace/project/cache/go-build",
|
|
"/workspace/project/cache/go-mod",
|
|
"/workspace/project/cache/go-build",
|
|
},
|
|
})
|
|
if !stdlibAssertEqual([]string{"GOCACHE=/workspace/project/cache/go-build", "GOMODCACHE=/workspace/project/cache/go-mod"}, env) {
|
|
t.Fatalf("want %v, got %v", []string{"GOCACHE=/workspace/project/cache/go-build", "GOMODCACHE=/workspace/project/cache/go-mod"}, env)
|
|
}
|
|
|
|
})
|
|
|
|
t.Run("disabled cache returns no env vars", func(t *testing.T) {
|
|
if !stdlibAssertNil(CacheEnvironment(&CacheConfig{Enabled: false})) {
|
|
t.Fatalf("expected nil, got %v", CacheEnvironment(&CacheConfig{Enabled: false}))
|
|
}
|
|
|
|
})
|
|
}
|
|
|
|
func TestCache_CacheKeyWithConfig_Good(t *testing.T) {
|
|
fs := io.NewMemoryMedium()
|
|
if err := fs.Write("/workspace/project/go.sum", "module.example v1.0.0 h1:abc123"); err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
|
|
base := CacheKey(fs, "/workspace/project", "linux", "amd64")
|
|
key := CacheKeyWithConfig(fs, "/workspace/project", "linux", "amd64", &CacheConfig{
|
|
KeyPrefix: "demo",
|
|
})
|
|
if !stdlibAssertEqual("demo-"+base, key) {
|
|
t.Fatalf("want %v, got %v", "demo-"+base, key)
|
|
}
|
|
|
|
}
|
|
|
|
func TestCache_CacheKeyWithConfig_Bad(t *testing.T) {
|
|
fs := io.NewMemoryMedium()
|
|
if err := fs.Write("/workspace/project/go.sum", "module.example v1.0.0 h1:abc123"); err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
|
|
base := CacheKey(fs, "/workspace/project", "linux", "amd64")
|
|
|
|
t.Run("nil config leaves key unchanged", func(t *testing.T) {
|
|
if !stdlibAssertEqual(base, CacheKeyWithConfig(fs, "/workspace/project", "linux", "amd64", nil)) {
|
|
t.Fatalf("want %v, got %v", base, CacheKeyWithConfig(fs, "/workspace/project", "linux", "amd64", nil))
|
|
}
|
|
|
|
})
|
|
|
|
t.Run("blank prefix leaves key unchanged", func(t *testing.T) {
|
|
if !stdlibAssertEqual(base, CacheKeyWithConfig(fs, "/workspace/project", "linux", "amd64", &CacheConfig{})) {
|
|
t.Fatalf("want %v, got %v", base, CacheKeyWithConfig(fs, "/workspace/project", "linux", "amd64", &CacheConfig{}))
|
|
}
|
|
|
|
})
|
|
}
|
|
|
|
func TestCache_CacheKeyWithConfig_Ugly(t *testing.T) {
|
|
fs := io.NewMemoryMedium()
|
|
if err := fs.Write("/workspace/project/go.sum", "module.example v1.0.0 h1:abc123"); err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
|
|
base := CacheKey(fs, "/workspace/project", "linux", "amd64")
|
|
key := CacheKeyWithConfig(fs, "/workspace/project", "linux", "amd64", &CacheConfig{
|
|
KeyPrefix: " demo ",
|
|
})
|
|
if !stdlibAssertEqual("demo-"+base, key) {
|
|
t.Fatalf("want %v, got %v", "demo-"+base, key)
|
|
}
|
|
|
|
}
|
|
|
|
func TestCache_CacheRestoreKeys_Good(t *testing.T) {
|
|
keys := CacheRestoreKeys(&CacheConfig{
|
|
KeyPrefix: "demo",
|
|
RestoreKeys: []string{"go-", "core-"},
|
|
})
|
|
if !stdlibAssertEqual([]string{"demo", "go-", "core-"}, keys) {
|
|
t.Fatalf("want %v, got %v", []string{"demo", "go-", "core-"}, keys)
|
|
}
|
|
|
|
}
|
|
|
|
func TestCache_CacheRestoreKeys_Bad(t *testing.T) {
|
|
t.Run("nil config returns nil", func(t *testing.T) {
|
|
if !stdlibAssertNil(CacheRestoreKeys(nil)) {
|
|
t.Fatalf("expected nil, got %v", CacheRestoreKeys(nil))
|
|
}
|
|
|
|
})
|
|
|
|
t.Run("blank prefix is ignored", func(t *testing.T) {
|
|
keys := CacheRestoreKeys(&CacheConfig{
|
|
RestoreKeys: []string{"go-"},
|
|
})
|
|
if !stdlibAssertEqual([]string{"go-"}, keys) {
|
|
t.Fatalf("want %v, got %v", []string{"go-"}, keys)
|
|
}
|
|
|
|
})
|
|
}
|
|
|
|
func TestCache_CacheRestoreKeys_Ugly(t *testing.T) {
|
|
keys := CacheRestoreKeys(&CacheConfig{
|
|
KeyPrefix: "demo",
|
|
RestoreKeys: []string{"go-", "", "core-", "go-", "core-"},
|
|
})
|
|
if !stdlibAssertEqual([]string{"demo", "go-", "core-"}, keys) {
|
|
t.Fatalf("want %v, got %v", []string{"demo", "go-", "core-"}, keys)
|
|
}
|
|
|
|
}
|