[ax] Migrate filepath.* to core.Path*, add usage-example comments #4

New issue

Open

opened 2026-03-22 16:39:14 +00:00 by Virgil · 2 comments

Virgil commented

2026-03-22 16:39:14 +00:00

Member

AX sweep findings:

HIGH — filepath. usage in production code (8 hits)*

cache.go:47 filepath.Join
cache.go:69 filepath.Join
cache.go:72 filepath.Abs
cache.go:76 filepath.Abs
cache.go:81 filepath.Separator
cache.go:130 filepath.Dir
cache.go:206 filepath.Join
cache.go:211 filepath.Join

MEDIUM — strings. usage*

cache.go:81 strings.HasPrefix → core.HasPrefix

MEDIUM — Documentation uses filepath/strings

docs/architecture.md:165 filepath.Join
docs/architecture.md:169 filepath.Join
docs/architecture.md:181 strings.HasPrefix

MEDIUM — Missing usage-example comments on all 11 exported identifiers

Cache, Entry, New, Path, Get, Set, Delete, Clear, Age, GitHubReposKey, GitHubRepoKey

No os.Getenv, fmt.Sprintf, errors.New, or fmt.Errorf found. No UK spelling issues.

AX sweep findings: **HIGH — filepath.* usage in production code (8 hits)** - cache.go:47 filepath.Join - cache.go:69 filepath.Join - cache.go:72 filepath.Abs - cache.go:76 filepath.Abs - cache.go:81 filepath.Separator - cache.go:130 filepath.Dir - cache.go:206 filepath.Join - cache.go:211 filepath.Join **MEDIUM — strings.* usage** - cache.go:81 strings.HasPrefix → core.HasPrefix **MEDIUM — Documentation uses filepath/strings** - docs/architecture.md:165 filepath.Join - docs/architecture.md:169 filepath.Join - docs/architecture.md:181 strings.HasPrefix **MEDIUM — Missing usage-example comments on all 11 exported identifiers** - Cache, Entry, New, Path, Get, Set, Delete, Clear, Age, GitHubReposKey, GitHubRepoKey No os.Getenv, fmt.Sprintf, errors.New, or fmt.Errorf found. No UK spelling issues.

Virgil referenced this issue

2026-03-23 07:35:54 +00:00

[agent/codex] Fix ALL findings from issue #4. Read CLAUDE.md first. AX: fi... #9

Virgil referenced this issue from a commit

2026-03-23 07:35:56 +00:00

Merge pull request '[agent/codex] Fix ALL findings from issue #4. Read CLAUDE.md first. AX: fi...' (#9) from agent/fix-all-findings-from-issue--4--read-cla into dev

Virgil commented

2026-03-23 07:36:11 +00:00

Author

Member

Fix Applied

Commit cabb7b1: fix(cache): resolve issue 4 findings

filepath.* → core.JoinPath/PathAbs/PathDir throughout cache.go
strings.HasPrefix → core.HasPrefix
Usage-example comments added to exported identifiers
SPDX headers added
100 additions across 5 files

## Fix Applied Commit cabb7b1: fix(cache): resolve issue 4 findings - filepath.* → core.JoinPath/PathAbs/PathDir throughout cache.go - strings.HasPrefix → core.HasPrefix - Usage-example comments added to exported identifiers - SPDX headers added - 100 additions across 5 files

Virgil commented

2026-03-23 08:58:24 +00:00

Author

Member