fix(coderabbit): address review findings

Truncate API response to 100 chars in coolify client error messages
to prevent sensitive data leakage. Propagate per-repo tag failures
as a combined error instead of silently returning nil.

Co-Authored-By: Virgil <virgil@lethean.io>
This commit is contained in:
Snider 2026-03-17 09:54:19 +00:00
parent 0f50f98a95
commit 32b2c3775e
2 changed files with 9 additions and 1 deletions

View file

@ -188,6 +188,10 @@ func runTag(registryPath string, dryRun, force bool) error {
}
cli.Blank()
if failed > 0 {
return log.E("dev.tag", fmt.Sprintf("%d of %d repos failed to tag", failed, len(plans)), nil)
}
return nil
}

View file

@ -89,7 +89,11 @@ func (c *Client) Call(ctx context.Context, operationID string, params map[string
if err2 := json.Unmarshal([]byte(output), &arrResult); err2 == nil {
return map[string]any{"result": arrResult}, nil
}
return nil, log.E("coolify", fmt.Sprintf("failed to parse response (output: %s)", output), err)
truncated := output
if len(truncated) > 100 {
truncated = truncated[:100] + "..."
}
return nil, log.E("coolify", fmt.Sprintf("failed to parse response (output: %s)", truncated), err)
}
return result, nil