From 87584f84bd43bcf4c66a17dcf820e269cb66def1 Mon Sep 17 00:00:00 2001
From: Snider <snider@host.uk.com>
Date: Mon, 9 Mar 2026 15:10:49 +0000
Subject: [PATCH] fix: deterministic snapshot tests, add nil manifest +
 permissions coverage

Co-Authored-By: Virgil <virgil@lethean.io>
---
 snapshot/snapshot_test.go | 29 ++++++++++++++++++++++++++---
 1 file changed, 26 insertions(+), 3 deletions(-)

diff --git a/snapshot/snapshot_test.go b/snapshot/snapshot_test.go
index 1468115..d31b477 100644
--- a/snapshot/snapshot_test.go
+++ b/snapshot/snapshot_test.go
@@ -3,25 +3,33 @@ package snapshot
 import (
 	"encoding/json"
 	"testing"
+	"time"
 
 	"forge.lthn.ai/core/go-scm/manifest"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 )
 
+var fixedTime = time.Date(2026, 3, 9, 15, 0, 0, 0, time.UTC)
+
 func TestGenerate_Good(t *testing.T) {
 	m := &manifest.Manifest{
 		Code:        "test-app",
 		Name:        "Test App",
 		Version:     "1.0.0",
 		Description: "A test application",
+		Layout:      "HLCRF",
+		Slots:       map[string]string{"C": "main-content"},
 		Daemons: map[string]manifest.DaemonSpec{
 			"serve": {Binary: "core-php", Args: []string{"php", "serve"}, Default: true},
 		},
+		Permissions: manifest.Permissions{
+			Read: []string{"./photos/"},
+		},
 		Modules: []string{"core/media"},
 	}
 
-	data, err := Generate(m, "abc123def456", "v1.0.0")
+	data, err := GenerateAt(m, "abc123def456", "v1.0.0", fixedTime)
 	require.NoError(t, err)
 
 	var snap Snapshot
@@ -29,12 +37,19 @@ func TestGenerate_Good(t *testing.T) {
 
 	assert.Equal(t, 1, snap.Schema)
 	assert.Equal(t, "test-app", snap.Code)
+	assert.Equal(t, "Test App", snap.Name)
 	assert.Equal(t, "1.0.0", snap.Version)
+	assert.Equal(t, "A test application", snap.Description)
 	assert.Equal(t, "abc123def456", snap.Commit)
 	assert.Equal(t, "v1.0.0", snap.Tag)
-	assert.NotEmpty(t, snap.Built)
+	assert.Equal(t, "2026-03-09T15:00:00Z", snap.Built)
+	assert.Equal(t, "HLCRF", snap.Layout)
+	assert.Equal(t, "main-content", snap.Slots["C"])
 	assert.Len(t, snap.Daemons, 1)
 	assert.Equal(t, "core-php", snap.Daemons["serve"].Binary)
+	require.NotNil(t, snap.Permissions)
+	assert.Equal(t, []string{"./photos/"}, snap.Permissions.Read)
+	assert.Equal(t, []string{"core/media"}, snap.Modules)
 }
 
 func TestGenerate_Good_NoDaemons(t *testing.T) {
@@ -44,12 +59,20 @@ func TestGenerate_Good_NoDaemons(t *testing.T) {
 		Version: "0.1.0",
 	}
 
-	data, err := Generate(m, "abc123", "v0.1.0")
+	data, err := GenerateAt(m, "abc123", "v0.1.0", fixedTime)
 	require.NoError(t, err)
 
 	var snap Snapshot
 	require.NoError(t, json.Unmarshal(data, &snap))
 
+	assert.Equal(t, 1, snap.Schema)
 	assert.Equal(t, "simple", snap.Code)
 	assert.Nil(t, snap.Daemons)
+	assert.Nil(t, snap.Permissions)
+}
+
+func TestGenerate_Bad_NilManifest(t *testing.T) {
+	_, err := Generate(nil, "abc123", "v1.0.0")
+	assert.Error(t, err)
+	assert.Contains(t, err.Error(), "manifest is nil")
 }