907c5fa64c
15+ findings dispositioned. AX-6-conformant — no testify reintroduced.
Code fixes:
- cmd/dev/service.go: no-op now returns OK:true, unchecked prompt type assertion guarded
- cmd/workspace/config.go: relative parent traversal blocked + regression test, fmt.Errorf wrapping
- cmd/dev/cmd_issues.go + cmd_reviews.go: import ordering
- tests/cli/devops/main.go: raw WalkDir errors wrapped
- tests/cli/devops/Taskfile.yaml: strict shell flags
- cmd/vanity-import/Dockerfile + docs/development.md: Go 1.26 alignment
- locales/embed.go: missing dappco.re/go/i18n checksum
Test infra:
- New local test helpers in cmd/dev, cmd/setup, devkit, snapshot
- All testify usages already absent — local stdlib helpers preferred
per AX-6 ban
- Test naming aligned (Test{Filename}_{Function}_{Good,Bad,Ugly} per AX-10)
Disposition replies (RESOLVED-COMMENT, no testify added):
- cmd/dev/cmd_apply_test.go, cmd/setup/cmd_ci_test.go, snapshot_test.go,
devkit/coverage_test.go: CodeRabbit testify suggestions get reasoning
reply per AX-6 ban; local helpers are convention.
- SonarCloud/GHAS: no PR checks/annotations found; code-scanning API
returned no analysis, secret scanning disabled.
Verification: gofmt clean, git diff --check clean, no testify imports.
Targeted go vet + go test pass for cmd/workspace + devkit + snapshot.
Full go vet ./... blocked by pre-existing dappco.re/go/scm
codeberg.org/forgejo/go-sdk auth/replacement issue (out of scope).
Closes findings on https://github.com/dAppCore/go-devops/pull/2
Co-authored-by: Codex <noreply@openai.com>
39 lines
1,019 B
Go
39 lines
1,019 B
Go
package dev
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"dappco.re/go/cli/pkg/cli"
|
|
)
|
|
|
|
func TestAddFileSyncCommand_Good(t *testing.T) {
|
|
root := &cli.Command{Use: "core"}
|
|
|
|
AddDevCommands(root)
|
|
|
|
syncCmd, _, err := root.Find([]string{"dev", "sync"})
|
|
mustNoError(t, err)
|
|
mustNotNil(t, syncCmd)
|
|
|
|
yesFlag := syncCmd.Flags().Lookup("yes")
|
|
mustNotNil(t, yesFlag)
|
|
mustEqual(t, "y", yesFlag.Shorthand)
|
|
|
|
mustNotNil(t, syncCmd.Flags().Lookup("dry-run"))
|
|
mustNotNil(t, syncCmd.Flags().Lookup("push"))
|
|
}
|
|
|
|
func TestSplitPatterns_Good(t *testing.T) {
|
|
patterns := splitPatterns("packages/core-*, apps/* ,services/*,")
|
|
want := []string{"packages/core-*", "apps/*", "services/*"}
|
|
mustDeepEqual(t, want, patterns)
|
|
}
|
|
|
|
func TestMatchGlob_Good(t *testing.T) {
|
|
mustTrue(t, matchGlob("packages/core-xyz", "packages/core-*"))
|
|
mustTrue(t, matchGlob("packages/core-xyz", "*/core-*"))
|
|
mustTrue(t, matchGlob("a-b", "a?b"))
|
|
mustTrue(t, matchGlob("foo", "foo"))
|
|
mustFalse(t, matchGlob("core-other", "packages/*"))
|
|
mustFalse(t, matchGlob("abc", "[]"))
|
|
}
|