907c5fa64c
15+ findings dispositioned. AX-6-conformant — no testify reintroduced.
Code fixes:
- cmd/dev/service.go: no-op now returns OK:true, unchecked prompt type assertion guarded
- cmd/workspace/config.go: relative parent traversal blocked + regression test, fmt.Errorf wrapping
- cmd/dev/cmd_issues.go + cmd_reviews.go: import ordering
- tests/cli/devops/main.go: raw WalkDir errors wrapped
- tests/cli/devops/Taskfile.yaml: strict shell flags
- cmd/vanity-import/Dockerfile + docs/development.md: Go 1.26 alignment
- locales/embed.go: missing dappco.re/go/i18n checksum
Test infra:
- New local test helpers in cmd/dev, cmd/setup, devkit, snapshot
- All testify usages already absent — local stdlib helpers preferred
per AX-6 ban
- Test naming aligned (Test{Filename}_{Function}_{Good,Bad,Ugly} per AX-10)
Disposition replies (RESOLVED-COMMENT, no testify added):
- cmd/dev/cmd_apply_test.go, cmd/setup/cmd_ci_test.go, snapshot_test.go,
devkit/coverage_test.go: CodeRabbit testify suggestions get reasoning
reply per AX-6 ban; local helpers are convention.
- SonarCloud/GHAS: no PR checks/annotations found; code-scanning API
returned no analysis, secret scanning disabled.
Verification: gofmt clean, git diff --check clean, no testify imports.
Targeted go vet + go test pass for cmd/workspace + devkit + snapshot.
Full go vet ./... blocked by pre-existing dappco.re/go/scm
codeberg.org/forgejo/go-sdk auth/replacement issue (out of scope).
Closes findings on https://github.com/dAppCore/go-devops/pull/2
Co-authored-by: Codex <noreply@openai.com>
80 lines
1.4 KiB
Go
80 lines
1.4 KiB
Go
package dev
|
|
|
|
import (
|
|
"reflect"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func mustNoError(t *testing.T, err error) {
|
|
t.Helper()
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
}
|
|
|
|
func mustEqual[T comparable](t *testing.T, want, got T) {
|
|
t.Helper()
|
|
if want != got {
|
|
t.Fatalf("want %v, got %v", want, got)
|
|
}
|
|
}
|
|
|
|
func mustDeepEqual(t *testing.T, want, got any) {
|
|
t.Helper()
|
|
if !reflect.DeepEqual(want, got) {
|
|
t.Fatalf("want %v, got %v", want, got)
|
|
}
|
|
}
|
|
|
|
func mustContains(t *testing.T, s, sub string) {
|
|
t.Helper()
|
|
if !strings.Contains(s, sub) {
|
|
t.Fatalf("expected %q to contain %q", s, sub)
|
|
}
|
|
}
|
|
|
|
func mustContainsString(t *testing.T, haystack []string, needle string) {
|
|
t.Helper()
|
|
for _, s := range haystack {
|
|
if s == needle {
|
|
return
|
|
}
|
|
}
|
|
t.Fatalf("expected %v to contain %q", haystack, needle)
|
|
}
|
|
|
|
func mustNotContains(t *testing.T, s, sub string) {
|
|
t.Helper()
|
|
if strings.Contains(s, sub) {
|
|
t.Fatalf("expected %q to not contain %q", s, sub)
|
|
}
|
|
}
|
|
|
|
func mustTrue(t *testing.T, cond bool) {
|
|
t.Helper()
|
|
if !cond {
|
|
t.Fatal("expected true")
|
|
}
|
|
}
|
|
|
|
func mustFalse(t *testing.T, cond bool) {
|
|
t.Helper()
|
|
if cond {
|
|
t.Fatal("expected false")
|
|
}
|
|
}
|
|
|
|
func mustLen[T any](t *testing.T, got []T, want int) {
|
|
t.Helper()
|
|
if len(got) != want {
|
|
t.Fatalf("want length %d, got %d", want, len(got))
|
|
}
|
|
}
|
|
|
|
func mustNotNil(t *testing.T, v any) {
|
|
t.Helper()
|
|
if v == nil {
|
|
t.Fatal("expected non-nil")
|
|
}
|
|
}
|