907c5fa64c
15+ findings dispositioned. AX-6-conformant — no testify reintroduced.
Code fixes:
- cmd/dev/service.go: no-op now returns OK:true, unchecked prompt type assertion guarded
- cmd/workspace/config.go: relative parent traversal blocked + regression test, fmt.Errorf wrapping
- cmd/dev/cmd_issues.go + cmd_reviews.go: import ordering
- tests/cli/devops/main.go: raw WalkDir errors wrapped
- tests/cli/devops/Taskfile.yaml: strict shell flags
- cmd/vanity-import/Dockerfile + docs/development.md: Go 1.26 alignment
- locales/embed.go: missing dappco.re/go/i18n checksum
Test infra:
- New local test helpers in cmd/dev, cmd/setup, devkit, snapshot
- All testify usages already absent — local stdlib helpers preferred
per AX-6 ban
- Test naming aligned (Test{Filename}_{Function}_{Good,Bad,Ugly} per AX-10)
Disposition replies (RESOLVED-COMMENT, no testify added):
- cmd/dev/cmd_apply_test.go, cmd/setup/cmd_ci_test.go, snapshot_test.go,
devkit/coverage_test.go: CodeRabbit testify suggestions get reasoning
reply per AX-6 ban; local helpers are convention.
- SonarCloud/GHAS: no PR checks/annotations found; code-scanning API
returned no analysis, secret scanning disabled.
Verification: gofmt clean, git diff --check clean, no testify imports.
Targeted go vet + go test pass for cmd/workspace + devkit + snapshot.
Full go vet ./... blocked by pre-existing dappco.re/go/scm
codeberg.org/forgejo/go-sdk auth/replacement issue (out of scope).
Closes findings on https://github.com/dAppCore/go-devops/pull/2
Co-authored-by: Codex <noreply@openai.com>
62 lines
1.8 KiB
Go
62 lines
1.8 KiB
Go
package devkit
|
|
|
|
import (
|
|
"errors"
|
|
"testing"
|
|
)
|
|
|
|
func TestScanSecrets_Good(t *testing.T) {
|
|
originalRunner := scanSecretsRunner
|
|
t.Cleanup(func() {
|
|
scanSecretsRunner = originalRunner
|
|
})
|
|
|
|
scanSecretsRunner = func(dir string) ([]byte, error) {
|
|
mustEqual(t, "/tmp/project", dir)
|
|
return []byte(`RuleID,File,StartLine,StartColumn,Description,Match
|
|
github-token,config.yml,12,4,GitHub token detected,ghp_exampletoken1234567890
|
|
aws-access-key-id,creds.txt,7,1,AWS access key detected,AKIA1234567890ABCDEF
|
|
`), nil
|
|
}
|
|
|
|
findings, err := ScanSecrets("/tmp/project")
|
|
mustNoError(t, err)
|
|
mustLen(t, findings, 2)
|
|
|
|
mustEqual(t, "github-token", findings[0].Rule)
|
|
mustEqual(t, "config.yml", findings[0].Path)
|
|
mustEqual(t, 12, findings[0].Line)
|
|
mustEqual(t, 4, findings[0].Column)
|
|
mustEqual(t, "ghp_exampletoken1234567890", findings[0].Snippet)
|
|
|
|
mustEqual(t, "aws-access-key-id", findings[1].Rule)
|
|
mustEqual(t, "creds.txt", findings[1].Path)
|
|
mustEqual(t, 7, findings[1].Line)
|
|
mustEqual(t, 1, findings[1].Column)
|
|
mustEqual(t, "AKIA1234567890ABCDEF", findings[1].Snippet)
|
|
}
|
|
|
|
func TestScanSecrets_ReportsFindingsOnExitError_Good(t *testing.T) {
|
|
originalRunner := scanSecretsRunner
|
|
t.Cleanup(func() {
|
|
scanSecretsRunner = originalRunner
|
|
})
|
|
|
|
scanSecretsRunner = func(dir string) ([]byte, error) {
|
|
return []byte(`rule_id,file,start_line,start_column,description,match
|
|
token,test.txt,3,2,Token detected,secret-value
|
|
`), errors.New("exit status 1")
|
|
}
|
|
|
|
findings, err := ScanSecrets("/tmp/project")
|
|
mustNoError(t, err)
|
|
mustLen(t, findings, 1)
|
|
mustEqual(t, "token", findings[0].Rule)
|
|
mustEqual(t, 3, findings[0].Line)
|
|
mustEqual(t, 2, findings[0].Column)
|
|
}
|
|
|
|
func TestParseGitleaksCSV_Bad(t *testing.T) {
|
|
_, err := parseGitleaksCSV([]byte("rule_id,file,start_line\nunterminated,\"broken"))
|
|
mustError(t, err)
|
|
}
|