907c5fa64c
15+ findings dispositioned. AX-6-conformant — no testify reintroduced.
Code fixes:
- cmd/dev/service.go: no-op now returns OK:true, unchecked prompt type assertion guarded
- cmd/workspace/config.go: relative parent traversal blocked + regression test, fmt.Errorf wrapping
- cmd/dev/cmd_issues.go + cmd_reviews.go: import ordering
- tests/cli/devops/main.go: raw WalkDir errors wrapped
- tests/cli/devops/Taskfile.yaml: strict shell flags
- cmd/vanity-import/Dockerfile + docs/development.md: Go 1.26 alignment
- locales/embed.go: missing dappco.re/go/i18n checksum
Test infra:
- New local test helpers in cmd/dev, cmd/setup, devkit, snapshot
- All testify usages already absent — local stdlib helpers preferred
per AX-6 ban
- Test naming aligned (Test{Filename}_{Function}_{Good,Bad,Ugly} per AX-10)
Disposition replies (RESOLVED-COMMENT, no testify added):
- cmd/dev/cmd_apply_test.go, cmd/setup/cmd_ci_test.go, snapshot_test.go,
devkit/coverage_test.go: CodeRabbit testify suggestions get reasoning
reply per AX-6 ban; local helpers are convention.
- SonarCloud/GHAS: no PR checks/annotations found; code-scanning API
returned no analysis, secret scanning disabled.
Verification: gofmt clean, git diff --check clean, no testify imports.
Targeted go vet + go test pass for cmd/workspace + devkit + snapshot.
Full go vet ./... blocked by pre-existing dappco.re/go/scm
codeberg.org/forgejo/go-sdk auth/replacement issue (out of scope).
Closes findings on https://github.com/dAppCore/go-devops/pull/2
Co-authored-by: Codex <noreply@openai.com>
89 lines
2 KiB
Go
89 lines
2 KiB
Go
// AX-10 CLI driver for go-devops.
|
|
//
|
|
// task -d tests/cli/devops
|
|
// go run ./tests/cli/devops dev --help
|
|
package main
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
|
|
"dappco.re/go/cli/pkg/cli"
|
|
deploycmd "dappco.re/go/devops/cmd/deploy"
|
|
devcmd "dappco.re/go/devops/cmd/dev"
|
|
docscmd "dappco.re/go/devops/cmd/docs"
|
|
gitcmd "dappco.re/go/devops/cmd/gitcmd"
|
|
setupcmd "dappco.re/go/devops/cmd/setup"
|
|
|
|
"gopkg.in/yaml.v3"
|
|
)
|
|
|
|
func main() {
|
|
root := cli.NewGroup("devops", "DevOps CLI artifact test driver", "")
|
|
devcmd.AddDevCommands(root)
|
|
deploycmd.AddDeployCommands(root)
|
|
docscmd.AddDocsCommands(root)
|
|
gitcmd.AddGitCommands(root)
|
|
setupcmd.AddSetupCommands(root)
|
|
root.AddCommand(playbookSmokeCommand())
|
|
root.SetArgs(os.Args[1:])
|
|
|
|
if err := root.Execute(); err != nil {
|
|
fmt.Fprintln(os.Stderr, err)
|
|
os.Exit(1)
|
|
}
|
|
}
|
|
|
|
func playbookSmokeCommand() *cli.Command {
|
|
return &cli.Command{
|
|
Use: "playbook-smoke [dir]",
|
|
Short: "Validate bundled playbook YAML can be decoded",
|
|
Args: cli.RangeArgs(0, 1),
|
|
RunE: runPlaybookSmoke,
|
|
}
|
|
}
|
|
|
|
func runPlaybookSmoke(cmd *cli.Command, args []string) error {
|
|
dir := "playbooks"
|
|
if len(args) > 0 {
|
|
dir = args[0]
|
|
}
|
|
|
|
count := 0
|
|
err := filepath.WalkDir(dir, func(path string, entry os.DirEntry, err error) error {
|
|
if err != nil {
|
|
return fmt.Errorf("%s: %w", path, err)
|
|
}
|
|
if entry.IsDir() || !isYAML(path) {
|
|
return nil
|
|
}
|
|
|
|
raw, err := os.ReadFile(path)
|
|
if err != nil {
|
|
return fmt.Errorf("%s: %w", path, err)
|
|
}
|
|
|
|
var document any
|
|
if err := yaml.Unmarshal(raw, &document); err != nil {
|
|
return fmt.Errorf("%s: %w", path, err)
|
|
}
|
|
count++
|
|
return nil
|
|
})
|
|
if err != nil {
|
|
return fmt.Errorf("walk %s: %w", dir, err)
|
|
}
|
|
if count == 0 {
|
|
return fmt.Errorf("no playbook YAML files found in %s", dir)
|
|
}
|
|
|
|
fmt.Fprintf(cmd.OutOrStdout(), "playbook smoke passed: %d YAML files decoded\n", count)
|
|
return nil
|
|
}
|
|
|
|
func isYAML(path string) bool {
|
|
ext := strings.ToLower(filepath.Ext(path))
|
|
return ext == ".yaml" || ext == ".yml"
|
|
}
|