9f6fa7ec17
Round 2 follow-up to 907c5fa. Closes residual CodeRabbit findings.
Test infra:
- Replaced must* test helpers across cmd_apply_test, cmd_file_sync_test,
cmd_vm_test, cmd_ci_test, cmd_repo_test, cmd_wizard_test,
cmd_api_testgen_test, cmd_workflow_test, secret_test, coverage_test,
scan_secrets_test, snapshot_test with stdlib checks.
- Deleted stale package-level test_helpers_test.go files that only
supported the old must* pattern.
- AX-6 maintained: no testify Go imports / go.mod requires. Remaining
go.sum testify entries are transitive checksums after go mod tidy.
Module graph:
- CLI imports switched back to Cobra-compatible
dappco.re/go/core/cli/pkg/cli module + replacements for private
vanity modules. GOWORK=off resolves cleanly under isolated cache.
- locales/embed.go / go.sum: i18n checksum + go mod tidy clean.
Verified-but-already-correct (no code change needed):
- cmd/dev/service.go: no-op core.Result{OK:true} + prompt type assertion
- cmd/workspace/config.go: filepath.Abs normalisation + fmt.Errorf
wrapping
- tests/cli/devops/main.go: raw walk/read errors wrapped
- tests/cli/devops/Taskfile.yaml: strict shell flags
- cmd/dev/cmd_issues.go + cmd_reviews.go: import grouping (after CLI
module correction)
Verification: gofmt clean, GOWORK=off go vet + go test -count=1 ./...
pass with explicit cache paths.
Closes residual findings on https://github.com/dAppCore/go-devops/pull/2
Co-authored-by: Codex <noreply@openai.com>
112 lines
2.4 KiB
Go
112 lines
2.4 KiB
Go
package dev
|
|
|
|
import (
|
|
"bytes"
|
|
"path/filepath"
|
|
"text/template"
|
|
|
|
"dappco.re/go/core/cli/pkg/cli"
|
|
"dappco.re/go/i18n"
|
|
coreio "dappco.re/go/io"
|
|
)
|
|
|
|
func addTestGenCommand(parent *cli.Command) {
|
|
testGenCmd := &cli.Command{
|
|
Use: "test-gen",
|
|
Short: i18n.T("cmd.dev.api.test_gen.short"),
|
|
Long: i18n.T("cmd.dev.api.test_gen.long"),
|
|
RunE: func(cmd *cli.Command, args []string) error {
|
|
if err := runTestGen(); err != nil {
|
|
return cli.Wrap(err, i18n.Label("error"))
|
|
}
|
|
cli.Text(i18n.T("i18n.done.sync", "public API tests"))
|
|
return nil
|
|
},
|
|
}
|
|
|
|
parent.AddCommand(testGenCmd)
|
|
}
|
|
|
|
func runTestGen() error {
|
|
pkgDir := "pkg"
|
|
internalDirs, err := coreio.Local.List(pkgDir)
|
|
if err != nil {
|
|
return cli.Wrap(err, "failed to read pkg directory")
|
|
}
|
|
|
|
for _, dir := range internalDirs {
|
|
if !dir.IsDir() || dir.Name() == "core" {
|
|
continue
|
|
}
|
|
|
|
serviceName := dir.Name()
|
|
internalDir := filepath.Join(pkgDir, serviceName)
|
|
publicDir := serviceName
|
|
publicTestFile := filepath.Join(publicDir, serviceName+"_test.go")
|
|
|
|
if !coreio.Local.Exists(internalDir) {
|
|
continue
|
|
}
|
|
|
|
symbols, err := getExportedSymbols(internalDir)
|
|
if err != nil {
|
|
return cli.Wrap(err, cli.Sprintf("error getting symbols for service '%s'", serviceName))
|
|
}
|
|
|
|
if len(symbols) == 0 {
|
|
continue
|
|
}
|
|
|
|
if err := generatePublicAPITestFile(publicDir, publicTestFile, serviceName, symbols); err != nil {
|
|
return cli.Wrap(err, cli.Sprintf("error generating public API test file for service '%s'", serviceName))
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
const publicAPITestTemplate = `// Code generated by "core dev api test-gen"; DO NOT EDIT.
|
|
package {{.ServiceName}}
|
|
|
|
import (
|
|
impl "dappco.re/go/cli/{{.ServiceName}}"
|
|
)
|
|
|
|
{{range .Symbols}}
|
|
{{- if eq .Kind "type"}}
|
|
type _ = impl.{{.Name}}
|
|
{{- else if eq .Kind "const"}}
|
|
const _ = impl.{{.Name}}
|
|
{{- else if eq .Kind "var"}}
|
|
var _ = impl.{{.Name}}
|
|
{{- else if eq .Kind "func"}}
|
|
var _ = impl.{{.Name}}
|
|
{{- end}}
|
|
{{end}}
|
|
`
|
|
|
|
func generatePublicAPITestFile(dir, path, serviceName string, symbols []symbolInfo) error {
|
|
if err := coreio.Local.EnsureDir(dir); err != nil {
|
|
return err
|
|
}
|
|
|
|
tmpl, err := template.New("publicAPITest").Parse(publicAPITestTemplate)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
data := struct {
|
|
ServiceName string
|
|
Symbols []symbolInfo
|
|
}{
|
|
ServiceName: serviceName,
|
|
Symbols: symbols,
|
|
}
|
|
|
|
var buf bytes.Buffer
|
|
if err := tmpl.Execute(&buf, data); err != nil {
|
|
return err
|
|
}
|
|
|
|
return coreio.Local.Write(path, buf.String())
|
|
}
|