Round 2 follow-up to 907c5fa. Closes residual CodeRabbit findings.
Test infra:
- Replaced must* test helpers across cmd_apply_test, cmd_file_sync_test,
cmd_vm_test, cmd_ci_test, cmd_repo_test, cmd_wizard_test,
cmd_api_testgen_test, cmd_workflow_test, secret_test, coverage_test,
scan_secrets_test, snapshot_test with stdlib checks.
- Deleted stale package-level test_helpers_test.go files that only
supported the old must* pattern.
- AX-6 maintained: no testify Go imports / go.mod requires. Remaining
go.sum testify entries are transitive checksums after go mod tidy.
Module graph:
- CLI imports switched back to Cobra-compatible
dappco.re/go/core/cli/pkg/cli module + replacements for private
vanity modules. GOWORK=off resolves cleanly under isolated cache.
- locales/embed.go / go.sum: i18n checksum + go mod tidy clean.
Verified-but-already-correct (no code change needed):
- cmd/dev/service.go: no-op core.Result{OK:true} + prompt type assertion
- cmd/workspace/config.go: filepath.Abs normalisation + fmt.Errorf
wrapping
- tests/cli/devops/main.go: raw walk/read errors wrapped
- tests/cli/devops/Taskfile.yaml: strict shell flags
- cmd/dev/cmd_issues.go + cmd_reviews.go: import grouping (after CLI
module correction)
Verification: gofmt clean, GOWORK=off go vet + go test -count=1 ./...
pass with explicit cache paths.
Closes residual findings on https://github.com/dAppCore/go-devops/pull/2
Co-authored-by: Codex <noreply@openai.com>
147 lines
3.4 KiB
Go
147 lines
3.4 KiB
Go
package dev
|
|
|
|
import (
|
|
"path/filepath"
|
|
"slices"
|
|
"strings"
|
|
"testing"
|
|
|
|
"dappco.re/go/io"
|
|
)
|
|
|
|
func TestRunTestGen_Good(t *testing.T) {
|
|
tmpDir := t.TempDir()
|
|
t.Setenv("CORE_WORKING_DIRECTORY", tmpDir)
|
|
|
|
serviceDir := filepath.Join(tmpDir, "pkg", "demo")
|
|
if err := io.Local.EnsureDir(serviceDir); err != nil {
|
|
t.Fatalf("create service dir: %v", err)
|
|
}
|
|
if err := io.Local.Write(filepath.Join(serviceDir, "demo.go"), `package demo
|
|
|
|
type Example struct{}
|
|
|
|
const Answer = 42
|
|
|
|
var Value = Example{}
|
|
|
|
func Run() {}
|
|
`); err != nil {
|
|
t.Fatalf("write demo.go: %v", err)
|
|
}
|
|
if err := io.Local.Write(filepath.Join(serviceDir, "extra.go"), `package demo
|
|
|
|
type Another struct{}
|
|
|
|
func Extra() {}
|
|
`); err != nil {
|
|
t.Fatalf("write extra.go: %v", err)
|
|
}
|
|
if err := io.Local.Write(filepath.Join(serviceDir, "demo_test.go"), `package demo
|
|
|
|
func Ignored() {}
|
|
`); err != nil {
|
|
t.Fatalf("write demo_test.go: %v", err)
|
|
}
|
|
|
|
if err := runTestGen(); err != nil {
|
|
t.Fatalf("run test generator: %v", err)
|
|
}
|
|
|
|
generatedPath := filepath.Join(tmpDir, "demo", "demo_test.go")
|
|
content, err := io.Local.Read(generatedPath)
|
|
if err != nil {
|
|
t.Fatalf("read generated file: %v", err)
|
|
}
|
|
|
|
for _, want := range []string{
|
|
`// Code generated by "core dev api test-gen"; DO NOT EDIT.`,
|
|
`package demo`,
|
|
`impl "dappco.re/go/cli/demo"`,
|
|
`type _ = impl.Example`,
|
|
`type _ = impl.Another`,
|
|
`const _ = impl.Answer`,
|
|
`var _ = impl.Value`,
|
|
`var _ = impl.Run`,
|
|
`var _ = impl.Extra`,
|
|
} {
|
|
if !strings.Contains(content, want) {
|
|
t.Fatalf("generated content missing %q", want)
|
|
}
|
|
}
|
|
if strings.Contains(content, `Ignored`) {
|
|
t.Fatal("generated content includes ignored symbol")
|
|
}
|
|
}
|
|
|
|
func TestGeneratePublicAPITestFile_Good(t *testing.T) {
|
|
tmpDir := t.TempDir()
|
|
|
|
if err := generatePublicAPITestFile(
|
|
filepath.Join(tmpDir, "demo"),
|
|
filepath.Join(tmpDir, "demo", "demo_test.go"),
|
|
"demo",
|
|
[]symbolInfo{
|
|
{Name: "Example", Kind: "type"},
|
|
{Name: "Answer", Kind: "const"},
|
|
},
|
|
); err != nil {
|
|
t.Fatalf("generate public API test file: %v", err)
|
|
}
|
|
|
|
content, err := io.Local.Read(filepath.Join(tmpDir, "demo", "demo_test.go"))
|
|
if err != nil {
|
|
t.Fatalf("read generated public API test file: %v", err)
|
|
}
|
|
|
|
for _, want := range []string{`type _ = impl.Example`, `const _ = impl.Answer`} {
|
|
if !strings.Contains(content, want) {
|
|
t.Fatalf("generated content missing %q", want)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestGetExportedSymbols_MultiFile_Good(t *testing.T) {
|
|
tmpDir := t.TempDir()
|
|
|
|
serviceDir := filepath.Join(tmpDir, "demo")
|
|
if err := io.Local.EnsureDir(serviceDir); err != nil {
|
|
t.Fatalf("create service dir: %v", err)
|
|
}
|
|
if err := io.Local.Write(filepath.Join(serviceDir, "demo.go"), `package demo
|
|
|
|
type Example struct{}
|
|
|
|
const Answer = 42
|
|
`); err != nil {
|
|
t.Fatalf("write demo.go: %v", err)
|
|
}
|
|
if err := io.Local.Write(filepath.Join(serviceDir, "extra.go"), `package demo
|
|
|
|
var Value = Example{}
|
|
|
|
func Run() {}
|
|
`); err != nil {
|
|
t.Fatalf("write extra.go: %v", err)
|
|
}
|
|
if err := io.Local.Write(filepath.Join(serviceDir, "demo_test.go"), `package demo
|
|
|
|
type Ignored struct{}
|
|
`); err != nil {
|
|
t.Fatalf("write demo_test.go: %v", err)
|
|
}
|
|
|
|
symbols, err := getExportedSymbols(serviceDir)
|
|
if err != nil {
|
|
t.Fatalf("get exported symbols: %v", err)
|
|
}
|
|
want := []symbolInfo{
|
|
{Name: "Answer", Kind: "const"},
|
|
{Name: "Example", Kind: "type"},
|
|
{Name: "Run", Kind: "func"},
|
|
{Name: "Value", Kind: "var"},
|
|
}
|
|
if !slices.Equal(symbols, want) {
|
|
t.Fatalf("symbols = %v, want %v", symbols, want)
|
|
}
|
|
}
|