9f6fa7ec17
Round 2 follow-up to 907c5fa. Closes residual CodeRabbit findings.
Test infra:
- Replaced must* test helpers across cmd_apply_test, cmd_file_sync_test,
cmd_vm_test, cmd_ci_test, cmd_repo_test, cmd_wizard_test,
cmd_api_testgen_test, cmd_workflow_test, secret_test, coverage_test,
scan_secrets_test, snapshot_test with stdlib checks.
- Deleted stale package-level test_helpers_test.go files that only
supported the old must* pattern.
- AX-6 maintained: no testify Go imports / go.mod requires. Remaining
go.sum testify entries are transitive checksums after go mod tidy.
Module graph:
- CLI imports switched back to Cobra-compatible
dappco.re/go/core/cli/pkg/cli module + replacements for private
vanity modules. GOWORK=off resolves cleanly under isolated cache.
- locales/embed.go / go.sum: i18n checksum + go mod tidy clean.
Verified-but-already-correct (no code change needed):
- cmd/dev/service.go: no-op core.Result{OK:true} + prompt type assertion
- cmd/workspace/config.go: filepath.Abs normalisation + fmt.Errorf
wrapping
- tests/cli/devops/main.go: raw walk/read errors wrapped
- tests/cli/devops/Taskfile.yaml: strict shell flags
- cmd/dev/cmd_issues.go + cmd_reviews.go: import grouping (after CLI
module correction)
Verification: gofmt clean, GOWORK=off go vet + go test -count=1 ./...
pass with explicit cache paths.
Closes residual findings on https://github.com/dAppCore/go-devops/pull/2
Co-authored-by: Codex <noreply@openai.com>
50 lines
1.4 KiB
Go
50 lines
1.4 KiB
Go
package dev
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"dappco.re/go/scm/repos"
|
|
)
|
|
|
|
func TestFilterTargetRepos_Good(t *testing.T) {
|
|
registry := &repos.Registry{
|
|
Repos: map[string]*repos.Repo{
|
|
"core-api": &repos.Repo{Name: "core-api", Path: "packages/core-api"},
|
|
"core-web": &repos.Repo{Name: "core-web", Path: "packages/core-web"},
|
|
"docs-site": &repos.Repo{Name: "docs-site", Path: "sites/docs"},
|
|
},
|
|
}
|
|
|
|
t.Run("exact names", func(t *testing.T) {
|
|
matched := filterTargetRepos(registry, "core-api,docs-site")
|
|
if len(matched) != 2 {
|
|
t.Fatalf("matched length = %d, want 2", len(matched))
|
|
}
|
|
if matched[0].Name != "core-api" {
|
|
t.Fatalf("matched[0].Name = %q, want %q", matched[0].Name, "core-api")
|
|
}
|
|
if matched[1].Name != "docs-site" {
|
|
t.Fatalf("matched[1].Name = %q, want %q", matched[1].Name, "docs-site")
|
|
}
|
|
})
|
|
|
|
t.Run("glob patterns", func(t *testing.T) {
|
|
matched := filterTargetRepos(registry, "core-*,sites/*")
|
|
if len(matched) != 3 {
|
|
t.Fatalf("matched length = %d, want 3", len(matched))
|
|
}
|
|
wantNames := []string{"core-api", "core-web", "docs-site"}
|
|
for i, want := range wantNames {
|
|
if matched[i].Name != want {
|
|
t.Fatalf("matched[%d].Name = %q, want %q", i, matched[i].Name, want)
|
|
}
|
|
}
|
|
})
|
|
|
|
t.Run("all repos when empty", func(t *testing.T) {
|
|
matched := filterTargetRepos(registry, "")
|
|
if len(matched) != 3 {
|
|
t.Fatalf("matched length = %d, want 3", len(matched))
|
|
}
|
|
})
|
|
}
|