9f6fa7ec17
Round 2 follow-up to 907c5fa. Closes residual CodeRabbit findings.
Test infra:
- Replaced must* test helpers across cmd_apply_test, cmd_file_sync_test,
cmd_vm_test, cmd_ci_test, cmd_repo_test, cmd_wizard_test,
cmd_api_testgen_test, cmd_workflow_test, secret_test, coverage_test,
scan_secrets_test, snapshot_test with stdlib checks.
- Deleted stale package-level test_helpers_test.go files that only
supported the old must* pattern.
- AX-6 maintained: no testify Go imports / go.mod requires. Remaining
go.sum testify entries are transitive checksums after go mod tidy.
Module graph:
- CLI imports switched back to Cobra-compatible
dappco.re/go/core/cli/pkg/cli module + replacements for private
vanity modules. GOWORK=off resolves cleanly under isolated cache.
- locales/embed.go / go.sum: i18n checksum + go mod tidy clean.
Verified-but-already-correct (no code change needed):
- cmd/dev/service.go: no-op core.Result{OK:true} + prompt type assertion
- cmd/workspace/config.go: filepath.Abs normalisation + fmt.Errorf
wrapping
- tests/cli/devops/main.go: raw walk/read errors wrapped
- tests/cli/devops/Taskfile.yaml: strict shell flags
- cmd/dev/cmd_issues.go + cmd_reviews.go: import grouping (after CLI
module correction)
Verification: gofmt clean, GOWORK=off go vet + go test -count=1 ./...
pass with explicit cache paths.
Closes residual findings on https://github.com/dAppCore/go-devops/pull/2
Co-authored-by: Codex <noreply@openai.com>
75 lines
1.7 KiB
Go
75 lines
1.7 KiB
Go
package dev
|
|
|
|
import (
|
|
"slices"
|
|
"testing"
|
|
|
|
"dappco.re/go/core/cli/pkg/cli"
|
|
)
|
|
|
|
func TestAddFileSyncCommand_Good(t *testing.T) {
|
|
root := &cli.Command{Use: "core"}
|
|
|
|
AddDevCommands(root)
|
|
|
|
syncCmd, _, err := root.Find([]string{"dev", "sync"})
|
|
if err != nil {
|
|
t.Fatalf("find sync command: %v", err)
|
|
}
|
|
if syncCmd == nil {
|
|
t.Fatal("expected sync command")
|
|
}
|
|
|
|
yesFlag := syncCmd.Flags().Lookup("yes")
|
|
if yesFlag == nil {
|
|
t.Fatal("expected yes flag")
|
|
}
|
|
if yesFlag.Shorthand != "y" {
|
|
t.Fatalf("yes shorthand = %q, want %q", yesFlag.Shorthand, "y")
|
|
}
|
|
|
|
if syncCmd.Flags().Lookup("dry-run") == nil {
|
|
t.Fatal("expected dry-run flag")
|
|
}
|
|
if syncCmd.Flags().Lookup("push") == nil {
|
|
t.Fatal("expected push flag")
|
|
}
|
|
}
|
|
|
|
func TestSplitPatterns_Good(t *testing.T) {
|
|
patterns := splitPatterns("packages/core-*, apps/* ,services/*,")
|
|
want := []string{"packages/core-*", "apps/*", "services/*"}
|
|
if !slices.Equal(patterns, want) {
|
|
t.Fatalf("patterns = %v, want %v", patterns, want)
|
|
}
|
|
}
|
|
|
|
func TestMatchGlob_Good(t *testing.T) {
|
|
trueCases := []struct {
|
|
name string
|
|
pattern string
|
|
}{
|
|
{name: "packages/core-xyz", pattern: "packages/core-*"},
|
|
{name: "packages/core-xyz", pattern: "*/core-*"},
|
|
{name: "a-b", pattern: "a?b"},
|
|
{name: "foo", pattern: "foo"},
|
|
}
|
|
for _, tc := range trueCases {
|
|
if !matchGlob(tc.name, tc.pattern) {
|
|
t.Fatalf("matchGlob(%q, %q) = false, want true", tc.name, tc.pattern)
|
|
}
|
|
}
|
|
|
|
falseCases := []struct {
|
|
name string
|
|
pattern string
|
|
}{
|
|
{name: "core-other", pattern: "packages/*"},
|
|
{name: "abc", pattern: "[]"},
|
|
}
|
|
for _, tc := range falseCases {
|
|
if matchGlob(tc.name, tc.pattern) {
|
|
t.Fatalf("matchGlob(%q, %q) = true, want false", tc.name, tc.pattern)
|
|
}
|
|
}
|
|
}
|