feat(dns): include wildcard names in reverse lookup
Co-Authored-By: Virgil <virgil@lethean.io>
This commit is contained in:
parent
c41756c2df
commit
93f22e6942
2 changed files with 3 additions and 7 deletions
|
|
@ -1375,10 +1375,6 @@ func collectReverseName(namesByIP *cache.Cache, name string, ips []string, expir
|
|||
return
|
||||
}
|
||||
|
||||
if strings.HasPrefix(normalizeName(name), "*.") {
|
||||
return
|
||||
}
|
||||
|
||||
for _, ip := range ips {
|
||||
normalized := normalizeIP(ip)
|
||||
if normalized == "" {
|
||||
|
|
|
|||
|
|
@ -396,7 +396,7 @@ func TestServiceResolveReverseNamesReturnsNamedField(t *testing.T) {
|
|||
}
|
||||
}
|
||||
|
||||
func TestServiceResolveReverseIgnoresWildcardTemplateNames(t *testing.T) {
|
||||
func TestServiceResolveReverseIncludesWildcardTemplateNames(t *testing.T) {
|
||||
service := NewService(ServiceOptions{
|
||||
Records: map[string]NameRecords{
|
||||
"*.charon.lthn": {
|
||||
|
|
@ -412,8 +412,8 @@ func TestServiceResolveReverseIgnoresWildcardTemplateNames(t *testing.T) {
|
|||
if !ok {
|
||||
t.Fatal("expected reverse lookup to resolve")
|
||||
}
|
||||
if len(names) != 1 || names[0] != "gateway.charon.lthn" {
|
||||
t.Fatalf("expected reverse lookup to omit wildcard names, got %#v", names)
|
||||
if len(names) != 2 || names[0] != "*.charon.lthn" || names[1] != "gateway.charon.lthn" {
|
||||
t.Fatalf("expected reverse lookup to include wildcard names, got %#v", names)
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Reference in a new issue