From 4c73a6b1794576d366fa1917ccbfd15fba08e2cb Mon Sep 17 00:00:00 2001
From: Virgil <virgil@lethean.io>
Date: Fri, 3 Apr 2026 21:58:21 +0000
Subject: [PATCH] Improve DNS AX naming and docs

---
 serve.go   | 14 +++++++-------
 service.go |  8 ++++++--
 2 files changed, 13 insertions(+), 9 deletions(-)

diff --git a/serve.go b/serve.go
index 2621d65..c7de944 100644
--- a/serve.go
+++ b/serve.go
@@ -112,14 +112,14 @@ func (service *Service) Serve(bind string, port int) (*DNSServer, error) {
 		return nil, err
 	}
 
-	handler := &dnsRequestHandler{service: service}
-	mux := dnsprotocol.NewServeMux()
-	mux.HandleFunc(".", handler.ServeDNS)
+	requestHandler := &dnsRequestHandler{service: service}
+	serveMux := dnsprotocol.NewServeMux()
+	serveMux.HandleFunc(".", requestHandler.ServeDNS)
 
-	udpServer := &dnsprotocol.Server{Net: "udp", PacketConn: udpListener, Handler: mux}
-	tcpServer := &dnsprotocol.Server{Net: "tcp", Listener: tcpListener, Handler: mux}
+	udpServer := &dnsprotocol.Server{Net: "udp", PacketConn: udpListener, Handler: serveMux}
+	tcpServer := &dnsprotocol.Server{Net: "tcp", Listener: tcpListener, Handler: serveMux}
 
-	run := &DNSServer{
+	dnsServer := &DNSServer{
 		udpListener: udpListener,
 		tcpListener: tcpListener,
 		udpServer:   udpServer,
@@ -133,7 +133,7 @@ func (service *Service) Serve(bind string, port int) (*DNSServer, error) {
 		_ = tcpServer.ActivateAndServe()
 	}()
 
-	return run, nil
+	return dnsServer, nil
 }
 
 // ServeAll starts DNS and health together.
diff --git a/service.go b/service.go
index 99f6d08..3874dd8 100644
--- a/service.go
+++ b/service.go
@@ -672,9 +672,12 @@ func (service *Service) ResolveReverse(ip string) ([]string, bool) {
 }
 
 // ResolveAll returns the full record set for a name, including synthesized apex NS data.
-// Missing names still return empty arrays so the action payload stays stable.
 //
 //	result, ok := service.ResolveAll("charon.lthn")
+//	// result = dns.ResolveAllResult{A: nil, AAAA: nil, TXT: nil, NS: []string{"ns.charon.lthn"}}
+//	// ok = true
+//
+// Missing names still return empty arrays so the action payload stays stable.
 func (service *Service) ResolveAll(name string) (ResolveAllResult, bool) {
 	record, ok := service.findRecord(name)
 	if !ok {
@@ -703,7 +706,7 @@ func (service *Service) ResolveAll(name string) (ResolveAllResult, bool) {
 // Health reports the live cache size and tree root.
 //
 //	health := service.Health()
-//	fmt.Println(health.TreeRoot)
+//	fmt.Println(health.Status, health.NamesCached, health.TreeRoot)
 func (service *Service) Health() HealthResult {
 	service.mu.RLock()
 	defer service.mu.RUnlock()
@@ -723,6 +726,7 @@ func (service *Service) Health() HealthResult {
 // ZoneApex returns the computed apex for the current record set.
 //
 //	apex := service.ZoneApex()
+//	// "charon.lthn"
 func (service *Service) ZoneApex() string {
 	service.mu.RLock()
 	defer service.mu.RUnlock()
-- 
2.45.3