From 67aad89cc42bc119a2714dec329f091c8f54d3cb Mon Sep 17 00:00:00 2001 From: Virgil Date: Wed, 1 Apr 2026 22:56:54 +0000 Subject: [PATCH] feat: expose repository pull reviewers Co-Authored-By: Virgil --- pulls.go | 12 +++++++++ pulls_test.go | 71 +++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 83 insertions(+) diff --git a/pulls.go b/pulls.go index e9d52ee..879b15c 100644 --- a/pulls.go +++ b/pulls.go @@ -50,6 +50,18 @@ func (s *PullService) IterReviews(ctx context.Context, owner, repo string, index return ListIter[types.PullReview](ctx, s.client, path, nil) } +// ListReviewers returns all users who can be requested to review a pull request. +func (s *PullService) ListReviewers(ctx context.Context, owner, repo string) ([]types.User, error) { + path := ResolvePath("/api/v1/repos/{owner}/{repo}/reviewers", pathParams("owner", owner, "repo", repo)) + return ListAll[types.User](ctx, s.client, path, nil) +} + +// IterReviewers returns an iterator over all users who can be requested to review a pull request. +func (s *PullService) IterReviewers(ctx context.Context, owner, repo string) iter.Seq2[types.User, error] { + path := ResolvePath("/api/v1/repos/{owner}/{repo}/reviewers", pathParams("owner", owner, "repo", repo)) + return ListIter[types.User](ctx, s.client, path, nil) +} + // SubmitReview creates a new review on a pull request. func (s *PullService) SubmitReview(ctx context.Context, owner, repo string, index int64, review map[string]any) (*types.PullReview, error) { path := ResolvePath("/api/v1/repos/{owner}/{repo}/pulls/{index}/reviews", pathParams("owner", owner, "repo", repo, "index", int64String(index))) diff --git a/pulls_test.go b/pulls_test.go index 6249eb0..230c5d7 100644 --- a/pulls_test.go +++ b/pulls_test.go @@ -94,6 +94,77 @@ func TestPullService_Create_Good(t *testing.T) { } } +func TestPullService_ListReviewers_Good(t *testing.T) { + srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { + if r.Method != http.MethodGet { + t.Errorf("expected GET, got %s", r.Method) + } + if r.URL.Path != "/api/v1/repos/core/go-forge/reviewers" { + t.Errorf("wrong path: %s", r.URL.Path) + http.NotFound(w, r) + return + } + json.NewEncoder(w).Encode([]types.User{ + {UserName: "alice"}, + {UserName: "bob"}, + }) + })) + defer srv.Close() + + f := NewForge(srv.URL, "tok") + reviewers, err := f.Pulls.ListReviewers(context.Background(), "core", "go-forge") + if err != nil { + t.Fatal(err) + } + if len(reviewers) != 2 || reviewers[0].UserName != "alice" || reviewers[1].UserName != "bob" { + t.Fatalf("got %#v", reviewers) + } +} + +func TestPullService_IterReviewers_Good(t *testing.T) { + requests := 0 + srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { + requests++ + if r.Method != http.MethodGet { + t.Errorf("expected GET, got %s", r.Method) + } + if r.URL.Path != "/api/v1/repos/core/go-forge/reviewers" { + t.Errorf("wrong path: %s", r.URL.Path) + http.NotFound(w, r) + return + } + switch requests { + case 1: + if got := r.URL.Query().Get("page"); got != "1" { + t.Errorf("got page=%q, want %q", got, "1") + } + w.Header().Set("X-Total-Count", "2") + json.NewEncoder(w).Encode([]types.User{{UserName: "alice"}}) + case 2: + if got := r.URL.Query().Get("page"); got != "2" { + t.Errorf("got page=%q, want %q", got, "2") + } + w.Header().Set("X-Total-Count", "2") + json.NewEncoder(w).Encode([]types.User{{UserName: "bob"}}) + default: + t.Fatalf("unexpected request %d", requests) + } + })) + defer srv.Close() + + f := NewForge(srv.URL, "tok") + var got []string + for reviewer, err := range f.Pulls.IterReviewers(context.Background(), "core", "go-forge") { + if err != nil { + t.Fatal(err) + } + got = append(got, reviewer.UserName) + } + if len(got) != 2 || got[0] != "alice" || got[1] != "bob" { + t.Fatalf("got %#v", got) + } +} + func TestPullService_Merge_Good(t *testing.T) { srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { if r.Method != http.MethodPost {