From 870d143f7889a5c2f3929f31a9e2437f5460827b Mon Sep 17 00:00:00 2001 From: Virgil Date: Thu, 2 Apr 2026 06:45:54 +0000 Subject: [PATCH] chore(forge): centralise default pagination limit Co-Authored-By: Virgil --- notifications.go | 6 +++--- pagination.go | 8 +++++--- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/notifications.go b/notifications.go index 77166a0..720a727 100644 --- a/notifications.go +++ b/notifications.go @@ -187,7 +187,7 @@ func (s *NotificationService) listAll(ctx context.Context, path string, filters page := 1 for { - result, err := s.listPage(ctx, path, ListOptions{Page: page, Limit: 50}, filters...) + result, err := s.listPage(ctx, path, ListOptions{Page: page, Limit: defaultPageLimit}, filters...) if err != nil { return nil, err } @@ -205,7 +205,7 @@ func (s *NotificationService) listIter(ctx context.Context, path string, filters return func(yield func(types.NotificationThread, error) bool) { page := 1 for { - result, err := s.listPage(ctx, path, ListOptions{Page: page, Limit: 50}, filters...) + result, err := s.listPage(ctx, path, ListOptions{Page: page, Limit: defaultPageLimit}, filters...) if err != nil { yield(*new(types.NotificationThread), err) return @@ -228,7 +228,7 @@ func (s *NotificationService) listPage(ctx context.Context, path string, opts Li opts.Page = 1 } if opts.Limit < 1 { - opts.Limit = 50 + opts.Limit = defaultPageLimit } u, err := url.Parse(path) diff --git a/pagination.go b/pagination.go index 3c2c468..77b8b22 100644 --- a/pagination.go +++ b/pagination.go @@ -10,6 +10,8 @@ import ( core "dappco.re/go/core" ) +const defaultPageLimit = 50 + // ListOptions controls pagination. // // Usage: @@ -54,7 +56,7 @@ func ListPage[T any](ctx context.Context, c *Client, path string, query map[stri opts.Page = 1 } if opts.Limit < 1 { - opts.Limit = 50 + opts.Limit = defaultPageLimit } u, err := url.Parse(path) @@ -100,7 +102,7 @@ func ListAll[T any](ctx context.Context, c *Client, path string, query map[strin page := 1 for { - result, err := ListPage[T](ctx, c, path, query, ListOptions{Page: page, Limit: 50}) + result, err := ListPage[T](ctx, c, path, query, ListOptions{Page: page, Limit: defaultPageLimit}) if err != nil { return nil, err } @@ -125,7 +127,7 @@ func ListIter[T any](ctx context.Context, c *Client, path string, query map[stri return func(yield func(T, error) bool) { page := 1 for { - result, err := ListPage[T](ctx, c, path, query, ListOptions{Page: page, Limit: 50}) + result, err := ListPage[T](ctx, c, path, query, ListOptions{Page: page, Limit: defaultPageLimit}) if err != nil { yield(*new(T), err) return