From ef44e7ada2498b5fdbc1ffa8dc152482c8dcf5fc Mon Sep 17 00:00:00 2001 From: Virgil Date: Wed, 1 Apr 2026 05:37:02 +0000 Subject: [PATCH] Add milestone edit and delete APIs Co-Authored-By: Virgil --- milestones.go | 16 ++++++++++++++ milestones_test.go | 53 ++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 69 insertions(+) diff --git a/milestones.go b/milestones.go index 84c3365..d46ea3e 100644 --- a/milestones.go +++ b/milestones.go @@ -45,3 +45,19 @@ func (s *MilestoneService) Create(ctx context.Context, owner, repo string, opts } return &out, nil } + +// Edit updates an existing milestone. +func (s *MilestoneService) Edit(ctx context.Context, owner, repo string, id int64, opts *types.EditMilestoneOption) (*types.Milestone, error) { + path := ResolvePath("/api/v1/repos/{owner}/{repo}/milestones/{id}", pathParams("owner", owner, "repo", repo, "id", int64String(id))) + var out types.Milestone + if err := s.client.Patch(ctx, path, opts, &out); err != nil { + return nil, err + } + return &out, nil +} + +// Delete removes a milestone. +func (s *MilestoneService) Delete(ctx context.Context, owner, repo string, id int64) error { + path := ResolvePath("/api/v1/repos/{owner}/{repo}/milestones/{id}", pathParams("owner", owner, "repo", repo, "id", int64String(id))) + return s.client.Delete(ctx, path) +} diff --git a/milestones_test.go b/milestones_test.go index f5e5a21..04f0b9e 100644 --- a/milestones_test.go +++ b/milestones_test.go @@ -97,3 +97,56 @@ func TestMilestoneService_Create_Good(t *testing.T) { t.Errorf("got title=%q, want %q", milestone.Title, "v1.0") } } + +func TestMilestoneService_Edit_Good(t *testing.T) { + srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { + if r.Method != http.MethodPatch { + t.Errorf("expected PATCH, got %s", r.Method) + } + if r.URL.Path != "/api/v1/repos/core/go-forge/milestones/3" { + t.Errorf("wrong path: %s", r.URL.Path) + } + var opts types.EditMilestoneOption + if err := json.NewDecoder(r.Body).Decode(&opts); err != nil { + t.Fatal(err) + } + if opts.Title != "v1.1" { + t.Errorf("got title=%q, want %q", opts.Title, "v1.1") + } + + json.NewEncoder(w).Encode(types.Milestone{ID: 3, Title: opts.Title}) + })) + defer srv.Close() + + f := NewForge(srv.URL, "tok") + milestone, err := f.Milestones.Edit(context.Background(), "core", "go-forge", 3, &types.EditMilestoneOption{ + Title: "v1.1", + }) + if err != nil { + t.Fatal(err) + } + if milestone.ID != 3 { + t.Errorf("got id=%d, want 3", milestone.ID) + } + if milestone.Title != "v1.1" { + t.Errorf("got title=%q, want %q", milestone.Title, "v1.1") + } +} + +func TestMilestoneService_Delete_Good(t *testing.T) { + srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { + if r.Method != http.MethodDelete { + t.Errorf("expected DELETE, got %s", r.Method) + } + if r.URL.Path != "/api/v1/repos/core/go-forge/milestones/3" { + t.Errorf("wrong path: %s", r.URL.Path) + } + w.WriteHeader(http.StatusNoContent) + })) + defer srv.Close() + + f := NewForge(srv.URL, "tok") + if err := f.Milestones.Delete(context.Background(), "core", "go-forge", 3); err != nil { + t.Fatal(err) + } +}