206749eb8a
Bug: Resource.Create was POSTing to item path (/issues/{index})
instead of collection path (/issues). Same class as the List fix.
Tests: path validation on all service methods, Update tests for
issues/repos, CreateComment test, ListComments test, PR merge
error case (conflict handling).
227 lines of test coverage added by Codex agent.
Co-Authored-By: Virgil <virgil@lethean.io>
78 lines
2.8 KiB
Go
78 lines
2.8 KiB
Go
package forge
|
|
|
|
import (
|
|
"context"
|
|
"iter"
|
|
"strings"
|
|
)
|
|
|
|
// Resource provides generic CRUD operations for a Forgejo API resource.
|
|
// T is the resource type, C is the create options type, U is the update options type.
|
|
type Resource[T any, C any, U any] struct {
|
|
client *Client
|
|
path string // item path: /api/v1/repos/{owner}/{repo}/issues/{index}
|
|
collection string // collection path: /api/v1/repos/{owner}/{repo}/issues
|
|
}
|
|
|
|
// NewResource creates a new Resource for the given path pattern.
|
|
// The path should be the item path (e.g., /repos/{owner}/{repo}/issues/{index}).
|
|
// The collection path is derived by stripping the last /{placeholder} segment.
|
|
func NewResource[T any, C any, U any](c *Client, path string) *Resource[T, C, U] {
|
|
collection := path
|
|
// Strip last segment if it's a pure placeholder like /{index}
|
|
// Don't strip if mixed like /repos or /{org}/repos
|
|
if i := strings.LastIndex(path, "/"); i >= 0 {
|
|
lastSeg := path[i+1:]
|
|
if strings.HasPrefix(lastSeg, "{") && strings.HasSuffix(lastSeg, "}") {
|
|
collection = path[:i]
|
|
}
|
|
}
|
|
return &Resource[T, C, U]{client: c, path: path, collection: collection}
|
|
}
|
|
|
|
// List returns a single page of resources.
|
|
func (r *Resource[T, C, U]) List(ctx context.Context, params Params, opts ListOptions) (*PagedResult[T], error) {
|
|
return ListPage[T](ctx, r.client, ResolvePath(r.collection, params), nil, opts)
|
|
}
|
|
|
|
// ListAll returns all resources across all pages.
|
|
func (r *Resource[T, C, U]) ListAll(ctx context.Context, params Params) ([]T, error) {
|
|
return ListAll[T](ctx, r.client, ResolvePath(r.collection, params), nil)
|
|
}
|
|
|
|
// Iter returns an iterator over all resources across all pages.
|
|
func (r *Resource[T, C, U]) Iter(ctx context.Context, params Params) iter.Seq2[T, error] {
|
|
return ListIter[T](ctx, r.client, ResolvePath(r.collection, params), nil)
|
|
}
|
|
|
|
// Get returns a single resource by appending id to the path.
|
|
func (r *Resource[T, C, U]) Get(ctx context.Context, params Params) (*T, error) {
|
|
var out T
|
|
if err := r.client.Get(ctx, ResolvePath(r.path, params), &out); err != nil {
|
|
return nil, err
|
|
}
|
|
return &out, nil
|
|
}
|
|
|
|
// Create creates a new resource.
|
|
func (r *Resource[T, C, U]) Create(ctx context.Context, params Params, body *C) (*T, error) {
|
|
var out T
|
|
if err := r.client.Post(ctx, ResolvePath(r.collection, params), body, &out); err != nil {
|
|
return nil, err
|
|
}
|
|
return &out, nil
|
|
}
|
|
|
|
// Update modifies an existing resource.
|
|
func (r *Resource[T, C, U]) Update(ctx context.Context, params Params, body *U) (*T, error) {
|
|
var out T
|
|
if err := r.client.Patch(ctx, ResolvePath(r.path, params), body, &out); err != nil {
|
|
return nil, err
|
|
}
|
|
return &out, nil
|
|
}
|
|
|
|
// Delete removes a resource.
|
|
func (r *Resource[T, C, U]) Delete(ctx context.Context, params Params) error {
|
|
return r.client.Delete(ctx, ResolvePath(r.path, params))
|
|
}
|