core/go-html
8
0
Fork 0
Code Issues 4 Pull requests Projects Releases Packages Wiki Activity Actions

fix(html): omit aria-hidden when visible
Some checks are pending
Security Scan / security (push) Waiting to run
Details
Test / test (push) Waiting to run
Details

Browse source 
Co-Authored-By: Virgil <virgil@lethean.io>
This commit is contained in:
Virgil 2026-04-03 17:39:54 +00:00
parent 9721c23202
commit 4d767fa0bd
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
node.go
View file

@ -220,7 +220,7 @@ func AriaHidden(n Node, hidden bool) Node {
if hidden {
return Attr(n, "aria-hidden", "true")
}
return Attr(n, "aria-hidden", "false")
return n
}
// node.go: TabIndex sets the tabindex attribute on an element node.

4
node_test.go
View file

@ -303,8 +303,8 @@ func TestAriaHiddenHelper(t *testing.T) {
visible := AriaHidden(El("span", Raw("decorative")), false)
gotVisible := visible.Render(ctx)
if !strings.Contains(gotVisible, `aria-hidden="false"`) {
t.Errorf("AriaHidden(false) = %q, want aria-hidden=\"false\"", gotVisible)
if strings.Contains(gotVisible, `aria-hidden=`) {
t.Errorf("AriaHidden(false) = %q, want no aria-hidden attribute", gotVisible)
}
}