diff --git a/docs/development.md b/docs/development.md index d060e40..d23b72d 100644 --- a/docs/development.md +++ b/docs/development.md @@ -105,10 +105,10 @@ func TestMyFeature(t *testing.T) { } ``` -For tests that need a real but ephemeral filesystem, use `local.New` with `t.TempDir()`: +For tests that need a temporary filesystem, use `local.New` with `t.TempDir()`: ```go -func TestWithRealFS(t *testing.T) { +func TestLocalMedium_RoundTrip_Good(t *testing.T) { localMedium, err := local.New(t.TempDir()) require.NoError(t, err) @@ -121,7 +121,7 @@ func TestWithRealFS(t *testing.T) { For SQLite-backed tests, use `:memory:`: ```go -func TestWithSQLite(t *testing.T) { +func TestSqliteMedium_RoundTrip_Good(t *testing.T) { sqliteMedium, err := sqlite.New(sqlite.Options{Path: ":memory:"}) require.NoError(t, err) defer sqliteMedium.Close() diff --git a/s3/s3_test.go b/s3/s3_test.go index 0ce8e06..7cfc42e 100644 --- a/s3/s3_test.go +++ b/s3/s3_test.go @@ -199,7 +199,7 @@ func (m *mockS3) CopyObject(_ context.Context, params *awss3.CopyObjectInput, _ return &awss3.CopyObjectOutput{}, nil } -func newTestMedium(t *testing.T) (*Medium, *mockS3) { +func newS3Medium(t *testing.T) (*Medium, *mockS3) { t.Helper() mock := newMockS3() m, err := New(Options{Bucket: "test-bucket", Client: mock}) @@ -239,7 +239,7 @@ func TestS3_New_Options_Good(t *testing.T) { } func TestS3_ReadWrite_Good(t *testing.T) { - m, _ := newTestMedium(t) + m, _ := newS3Medium(t) err := m.Write("hello.txt", "world") require.NoError(t, err) @@ -250,14 +250,14 @@ func TestS3_ReadWrite_Good(t *testing.T) { } func TestS3_ReadWrite_NotFound_Bad(t *testing.T) { - m, _ := newTestMedium(t) + m, _ := newS3Medium(t) _, err := m.Read("nonexistent.txt") assert.Error(t, err) } func TestS3_ReadWrite_EmptyPath_Bad(t *testing.T) { - m, _ := newTestMedium(t) + m, _ := newS3Medium(t) _, err := m.Read("") assert.Error(t, err) @@ -283,13 +283,13 @@ func TestS3_ReadWrite_Prefix_Good(t *testing.T) { } func TestS3_EnsureDir_Good(t *testing.T) { - medium, _ := newTestMedium(t) + medium, _ := newS3Medium(t) err := medium.EnsureDir("any/path") assert.NoError(t, err) } func TestS3_IsFile_Good(t *testing.T) { - m, _ := newTestMedium(t) + m, _ := newS3Medium(t) err := m.Write("file.txt", "content") require.NoError(t, err) @@ -300,7 +300,7 @@ func TestS3_IsFile_Good(t *testing.T) { } func TestS3_Delete_Good(t *testing.T) { - m, _ := newTestMedium(t) + m, _ := newS3Medium(t) err := m.Write("to-delete.txt", "content") require.NoError(t, err) @@ -312,13 +312,13 @@ func TestS3_Delete_Good(t *testing.T) { } func TestS3_Delete_EmptyPath_Bad(t *testing.T) { - m, _ := newTestMedium(t) + m, _ := newS3Medium(t) err := m.Delete("") assert.Error(t, err) } func TestS3_DeleteAll_Good(t *testing.T) { - m, _ := newTestMedium(t) + m, _ := newS3Medium(t) require.NoError(t, m.Write("dir/file1.txt", "a")) require.NoError(t, m.Write("dir/sub/file2.txt", "b")) @@ -333,13 +333,13 @@ func TestS3_DeleteAll_Good(t *testing.T) { } func TestS3_DeleteAll_EmptyPath_Bad(t *testing.T) { - m, _ := newTestMedium(t) + m, _ := newS3Medium(t) err := m.DeleteAll("") assert.Error(t, err) } func TestS3_DeleteAll_DeleteObjectError_Bad(t *testing.T) { - m, mock := newTestMedium(t) + m, mock := newS3Medium(t) mock.deleteObjectErrors["dir"] = core.NewError("boom") err := m.DeleteAll("dir") @@ -348,7 +348,7 @@ func TestS3_DeleteAll_DeleteObjectError_Bad(t *testing.T) { } func TestS3_DeleteAll_PartialDelete_Bad(t *testing.T) { - m, mock := newTestMedium(t) + m, mock := newS3Medium(t) require.NoError(t, m.Write("dir/file1.txt", "a")) require.NoError(t, m.Write("dir/file2.txt", "b")) @@ -367,7 +367,7 @@ func TestS3_DeleteAll_PartialDelete_Bad(t *testing.T) { } func TestS3_Rename_Good(t *testing.T) { - m, _ := newTestMedium(t) + m, _ := newS3Medium(t) require.NoError(t, m.Write("old.txt", "content")) assert.True(t, m.IsFile("old.txt")) @@ -384,7 +384,7 @@ func TestS3_Rename_Good(t *testing.T) { } func TestS3_Rename_EmptyPath_Bad(t *testing.T) { - m, _ := newTestMedium(t) + m, _ := newS3Medium(t) err := m.Rename("", "new.txt") assert.Error(t, err) @@ -393,13 +393,13 @@ func TestS3_Rename_EmptyPath_Bad(t *testing.T) { } func TestS3_Rename_SourceNotFound_Bad(t *testing.T) { - m, _ := newTestMedium(t) + m, _ := newS3Medium(t) err := m.Rename("nonexistent.txt", "new.txt") assert.Error(t, err) } func TestS3_List_Good(t *testing.T) { - m, _ := newTestMedium(t) + m, _ := newS3Medium(t) require.NoError(t, m.Write("dir/file1.txt", "a")) require.NoError(t, m.Write("dir/file2.txt", "b")) @@ -429,7 +429,7 @@ func TestS3_List_Good(t *testing.T) { } func TestS3_List_Root_Good(t *testing.T) { - m, _ := newTestMedium(t) + m, _ := newS3Medium(t) require.NoError(t, m.Write("root.txt", "content")) require.NoError(t, m.Write("dir/nested.txt", "nested")) @@ -447,7 +447,7 @@ func TestS3_List_Root_Good(t *testing.T) { } func TestS3_Stat_Good(t *testing.T) { - m, _ := newTestMedium(t) + m, _ := newS3Medium(t) require.NoError(t, m.Write("file.txt", "hello world")) @@ -459,20 +459,20 @@ func TestS3_Stat_Good(t *testing.T) { } func TestS3_Stat_NotFound_Bad(t *testing.T) { - m, _ := newTestMedium(t) + m, _ := newS3Medium(t) _, err := m.Stat("nonexistent.txt") assert.Error(t, err) } func TestS3_Stat_EmptyPath_Bad(t *testing.T) { - m, _ := newTestMedium(t) + m, _ := newS3Medium(t) _, err := m.Stat("") assert.Error(t, err) } func TestS3_Open_Good(t *testing.T) { - m, _ := newTestMedium(t) + m, _ := newS3Medium(t) require.NoError(t, m.Write("file.txt", "open me")) @@ -490,14 +490,14 @@ func TestS3_Open_Good(t *testing.T) { } func TestS3_Open_NotFound_Bad(t *testing.T) { - m, _ := newTestMedium(t) + m, _ := newS3Medium(t) _, err := m.Open("nonexistent.txt") assert.Error(t, err) } func TestS3_Create_Good(t *testing.T) { - m, _ := newTestMedium(t) + m, _ := newS3Medium(t) w, err := m.Create("new.txt") require.NoError(t, err) @@ -515,7 +515,7 @@ func TestS3_Create_Good(t *testing.T) { } func TestS3_Append_Good(t *testing.T) { - m, _ := newTestMedium(t) + m, _ := newS3Medium(t) require.NoError(t, m.Write("append.txt", "hello")) @@ -533,7 +533,7 @@ func TestS3_Append_Good(t *testing.T) { } func TestS3_Append_NewFile_Good(t *testing.T) { - m, _ := newTestMedium(t) + m, _ := newS3Medium(t) w, err := m.Append("new.txt") require.NoError(t, err) @@ -549,7 +549,7 @@ func TestS3_Append_NewFile_Good(t *testing.T) { } func TestS3_ReadStream_Good(t *testing.T) { - m, _ := newTestMedium(t) + m, _ := newS3Medium(t) require.NoError(t, m.Write("stream.txt", "streaming content")) @@ -563,13 +563,13 @@ func TestS3_ReadStream_Good(t *testing.T) { } func TestS3_ReadStream_NotFound_Bad(t *testing.T) { - m, _ := newTestMedium(t) + m, _ := newS3Medium(t) _, err := m.ReadStream("nonexistent.txt") assert.Error(t, err) } func TestS3_WriteStream_Good(t *testing.T) { - m, _ := newTestMedium(t) + m, _ := newS3Medium(t) writer, err := m.WriteStream("output.txt") require.NoError(t, err) @@ -585,7 +585,7 @@ func TestS3_WriteStream_Good(t *testing.T) { } func TestS3_Exists_Good(t *testing.T) { - m, _ := newTestMedium(t) + m, _ := newS3Medium(t) assert.False(t, m.Exists("nonexistent.txt")) @@ -594,14 +594,14 @@ func TestS3_Exists_Good(t *testing.T) { } func TestS3_Exists_DirectoryPrefix_Good(t *testing.T) { - m, _ := newTestMedium(t) + m, _ := newS3Medium(t) require.NoError(t, m.Write("dir/file.txt", "content")) assert.True(t, m.Exists("dir")) } func TestS3_IsDir_Good(t *testing.T) { - m, _ := newTestMedium(t) + m, _ := newS3Medium(t) require.NoError(t, m.Write("dir/file.txt", "content")) diff --git a/sqlite/sqlite_test.go b/sqlite/sqlite_test.go index ab90121..e0f1bc8 100644 --- a/sqlite/sqlite_test.go +++ b/sqlite/sqlite_test.go @@ -10,7 +10,7 @@ import ( "github.com/stretchr/testify/require" ) -func newTestSqliteMedium(t *testing.T) *Medium { +func newSqliteMedium(t *testing.T) *Medium { t.Helper() sqliteMedium, err := New(Options{Path: ":memory:"}) require.NoError(t, err) @@ -39,7 +39,7 @@ func TestSqlite_New_EmptyPath_Bad(t *testing.T) { } func TestSqlite_ReadWrite_Good(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) err := sqliteMedium.Write("hello.txt", "world") require.NoError(t, err) @@ -50,7 +50,7 @@ func TestSqlite_ReadWrite_Good(t *testing.T) { } func TestSqlite_ReadWrite_Overwrite_Good(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) require.NoError(t, sqliteMedium.Write("file.txt", "first")) require.NoError(t, sqliteMedium.Write("file.txt", "second")) @@ -61,7 +61,7 @@ func TestSqlite_ReadWrite_Overwrite_Good(t *testing.T) { } func TestSqlite_ReadWrite_NestedPath_Good(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) err := sqliteMedium.Write("a/b/c.txt", "nested") require.NoError(t, err) @@ -72,28 +72,28 @@ func TestSqlite_ReadWrite_NestedPath_Good(t *testing.T) { } func TestSqlite_Read_NotFound_Bad(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) _, err := sqliteMedium.Read("nonexistent.txt") assert.Error(t, err) } func TestSqlite_Read_EmptyPath_Bad(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) _, err := sqliteMedium.Read("") assert.Error(t, err) } func TestSqlite_Write_EmptyPath_Bad(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) err := sqliteMedium.Write("", "content") assert.Error(t, err) } func TestSqlite_Read_IsDirectory_Bad(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) require.NoError(t, sqliteMedium.EnsureDir("mydir")) _, err := sqliteMedium.Read("mydir") @@ -101,7 +101,7 @@ func TestSqlite_Read_IsDirectory_Bad(t *testing.T) { } func TestSqlite_EnsureDir_Good(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) err := sqliteMedium.EnsureDir("mydir") require.NoError(t, err) @@ -109,13 +109,13 @@ func TestSqlite_EnsureDir_Good(t *testing.T) { } func TestSqlite_EnsureDir_EmptyPath_Good(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) err := sqliteMedium.EnsureDir("") assert.NoError(t, err) } func TestSqlite_EnsureDir_Idempotent_Good(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) require.NoError(t, sqliteMedium.EnsureDir("mydir")) require.NoError(t, sqliteMedium.EnsureDir("mydir")) @@ -123,7 +123,7 @@ func TestSqlite_EnsureDir_Idempotent_Good(t *testing.T) { } func TestSqlite_IsFile_Good(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) require.NoError(t, sqliteMedium.Write("file.txt", "content")) require.NoError(t, sqliteMedium.EnsureDir("mydir")) @@ -135,7 +135,7 @@ func TestSqlite_IsFile_Good(t *testing.T) { } func TestSqlite_Delete_Good(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) require.NoError(t, sqliteMedium.Write("to-delete.txt", "content")) assert.True(t, sqliteMedium.Exists("to-delete.txt")) @@ -146,7 +146,7 @@ func TestSqlite_Delete_Good(t *testing.T) { } func TestSqlite_Delete_EmptyDir_Good(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) require.NoError(t, sqliteMedium.EnsureDir("emptydir")) assert.True(t, sqliteMedium.IsDir("emptydir")) @@ -157,21 +157,21 @@ func TestSqlite_Delete_EmptyDir_Good(t *testing.T) { } func TestSqlite_Delete_NotFound_Bad(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) err := sqliteMedium.Delete("nonexistent") assert.Error(t, err) } func TestSqlite_Delete_EmptyPath_Bad(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) err := sqliteMedium.Delete("") assert.Error(t, err) } func TestSqlite_Delete_NotEmpty_Bad(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) require.NoError(t, sqliteMedium.EnsureDir("mydir")) require.NoError(t, sqliteMedium.Write("mydir/file.txt", "content")) @@ -181,7 +181,7 @@ func TestSqlite_Delete_NotEmpty_Bad(t *testing.T) { } func TestSqlite_DeleteAll_Good(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) require.NoError(t, sqliteMedium.Write("dir/file1.txt", "a")) require.NoError(t, sqliteMedium.Write("dir/sub/file2.txt", "b")) @@ -196,7 +196,7 @@ func TestSqlite_DeleteAll_Good(t *testing.T) { } func TestSqlite_DeleteAll_SingleFile_Good(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) require.NoError(t, sqliteMedium.Write("file.txt", "content")) @@ -206,21 +206,21 @@ func TestSqlite_DeleteAll_SingleFile_Good(t *testing.T) { } func TestSqlite_DeleteAll_NotFound_Bad(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) err := sqliteMedium.DeleteAll("nonexistent") assert.Error(t, err) } func TestSqlite_DeleteAll_EmptyPath_Bad(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) err := sqliteMedium.DeleteAll("") assert.Error(t, err) } func TestSqlite_Rename_Good(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) require.NoError(t, sqliteMedium.Write("old.txt", "content")) @@ -236,7 +236,7 @@ func TestSqlite_Rename_Good(t *testing.T) { } func TestSqlite_Rename_Directory_Good(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) require.NoError(t, sqliteMedium.EnsureDir("olddir")) require.NoError(t, sqliteMedium.Write("olddir/file.txt", "content")) @@ -255,14 +255,14 @@ func TestSqlite_Rename_Directory_Good(t *testing.T) { } func TestSqlite_Rename_SourceNotFound_Bad(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) err := sqliteMedium.Rename("nonexistent", "new") assert.Error(t, err) } func TestSqlite_Rename_EmptyPath_Bad(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) err := sqliteMedium.Rename("", "new") assert.Error(t, err) @@ -272,7 +272,7 @@ func TestSqlite_Rename_EmptyPath_Bad(t *testing.T) { } func TestSqlite_List_Good(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) require.NoError(t, sqliteMedium.Write("dir/file1.txt", "a")) require.NoError(t, sqliteMedium.Write("dir/file2.txt", "b")) @@ -293,7 +293,7 @@ func TestSqlite_List_Good(t *testing.T) { } func TestSqlite_List_Root_Good(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) require.NoError(t, sqliteMedium.Write("root.txt", "content")) require.NoError(t, sqliteMedium.Write("dir/nested.txt", "nested")) @@ -311,7 +311,7 @@ func TestSqlite_List_Root_Good(t *testing.T) { } func TestSqlite_List_DirectoryEntry_Good(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) require.NoError(t, sqliteMedium.Write("dir/sub/file.txt", "content")) @@ -328,7 +328,7 @@ func TestSqlite_List_DirectoryEntry_Good(t *testing.T) { } func TestSqlite_Stat_Good(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) require.NoError(t, sqliteMedium.Write("file.txt", "hello world")) @@ -340,7 +340,7 @@ func TestSqlite_Stat_Good(t *testing.T) { } func TestSqlite_Stat_Directory_Good(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) require.NoError(t, sqliteMedium.EnsureDir("mydir")) @@ -351,21 +351,21 @@ func TestSqlite_Stat_Directory_Good(t *testing.T) { } func TestSqlite_Stat_NotFound_Bad(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) _, err := sqliteMedium.Stat("nonexistent") assert.Error(t, err) } func TestSqlite_Stat_EmptyPath_Bad(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) _, err := sqliteMedium.Stat("") assert.Error(t, err) } func TestSqlite_Open_Good(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) require.NoError(t, sqliteMedium.Write("file.txt", "open me")) @@ -383,14 +383,14 @@ func TestSqlite_Open_Good(t *testing.T) { } func TestSqlite_Open_NotFound_Bad(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) _, err := sqliteMedium.Open("nonexistent.txt") assert.Error(t, err) } func TestSqlite_Open_IsDirectory_Bad(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) require.NoError(t, sqliteMedium.EnsureDir("mydir")) _, err := sqliteMedium.Open("mydir") @@ -398,7 +398,7 @@ func TestSqlite_Open_IsDirectory_Bad(t *testing.T) { } func TestSqlite_Create_Good(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) w, err := sqliteMedium.Create("new.txt") require.NoError(t, err) @@ -416,7 +416,7 @@ func TestSqlite_Create_Good(t *testing.T) { } func TestSqlite_Create_Overwrite_Good(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) require.NoError(t, sqliteMedium.Write("file.txt", "old content")) @@ -432,14 +432,14 @@ func TestSqlite_Create_Overwrite_Good(t *testing.T) { } func TestSqlite_Create_EmptyPath_Bad(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) _, err := sqliteMedium.Create("") assert.Error(t, err) } func TestSqlite_Append_Good(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) require.NoError(t, sqliteMedium.Write("append.txt", "hello")) @@ -456,7 +456,7 @@ func TestSqlite_Append_Good(t *testing.T) { } func TestSqlite_Append_NewFile_Good(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) w, err := sqliteMedium.Append("new.txt") require.NoError(t, err) @@ -471,14 +471,14 @@ func TestSqlite_Append_NewFile_Good(t *testing.T) { } func TestSqlite_Append_EmptyPath_Bad(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) _, err := sqliteMedium.Append("") assert.Error(t, err) } func TestSqlite_ReadStream_Good(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) require.NoError(t, sqliteMedium.Write("stream.txt", "streaming content")) @@ -492,14 +492,14 @@ func TestSqlite_ReadStream_Good(t *testing.T) { } func TestSqlite_ReadStream_NotFound_Bad(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) _, err := sqliteMedium.ReadStream("nonexistent.txt") assert.Error(t, err) } func TestSqlite_ReadStream_IsDirectory_Bad(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) require.NoError(t, sqliteMedium.EnsureDir("mydir")) _, err := sqliteMedium.ReadStream("mydir") @@ -507,7 +507,7 @@ func TestSqlite_ReadStream_IsDirectory_Bad(t *testing.T) { } func TestSqlite_WriteStream_Good(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) writer, err := sqliteMedium.WriteStream("output.txt") require.NoError(t, err) @@ -522,7 +522,7 @@ func TestSqlite_WriteStream_Good(t *testing.T) { } func TestSqlite_Exists_Good(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) assert.False(t, sqliteMedium.Exists("nonexistent")) @@ -534,12 +534,12 @@ func TestSqlite_Exists_Good(t *testing.T) { } func TestSqlite_Exists_EmptyPath_Good(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) assert.True(t, sqliteMedium.Exists("")) } func TestSqlite_IsDir_Good(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) require.NoError(t, sqliteMedium.Write("file.txt", "content")) require.NoError(t, sqliteMedium.EnsureDir("mydir")) @@ -562,7 +562,7 @@ func TestSqlite_NormaliseEntryPath_Good(t *testing.T) { } func TestSqlite_InterfaceCompliance_Good(t *testing.T) { - sqliteMedium := newTestSqliteMedium(t) + sqliteMedium := newSqliteMedium(t) var _ interface { Read(string) (string, error) diff --git a/store/medium_test.go b/store/medium_test.go index 07e6f5d..2e433f3 100644 --- a/store/medium_test.go +++ b/store/medium_test.go @@ -9,7 +9,7 @@ import ( "github.com/stretchr/testify/require" ) -func newTestKeyValueMedium(t *testing.T) *Medium { +func newKeyValueMedium(t *testing.T) *Medium { t.Helper() keyValueMedium, err := NewMedium(Options{Path: ":memory:"}) require.NoError(t, err) @@ -18,7 +18,7 @@ func newTestKeyValueMedium(t *testing.T) *Medium { } func TestKeyValueMedium_ReadWrite_Good(t *testing.T) { - keyValueMedium := newTestKeyValueMedium(t) + keyValueMedium := newKeyValueMedium(t) err := keyValueMedium.Write("config/theme", "dark") require.NoError(t, err) @@ -29,19 +29,19 @@ func TestKeyValueMedium_ReadWrite_Good(t *testing.T) { } func TestKeyValueMedium_Read_NoKey_Bad(t *testing.T) { - keyValueMedium := newTestKeyValueMedium(t) + keyValueMedium := newKeyValueMedium(t) _, err := keyValueMedium.Read("config") assert.Error(t, err) } func TestKeyValueMedium_Read_NotFound_Bad(t *testing.T) { - keyValueMedium := newTestKeyValueMedium(t) + keyValueMedium := newKeyValueMedium(t) _, err := keyValueMedium.Read("config/missing") assert.Error(t, err) } func TestKeyValueMedium_IsFile_Good(t *testing.T) { - keyValueMedium := newTestKeyValueMedium(t) + keyValueMedium := newKeyValueMedium(t) _ = keyValueMedium.Write("group/key", "val") assert.True(t, keyValueMedium.IsFile("group/key")) @@ -50,7 +50,7 @@ func TestKeyValueMedium_IsFile_Good(t *testing.T) { } func TestKeyValueMedium_Delete_Good(t *testing.T) { - keyValueMedium := newTestKeyValueMedium(t) + keyValueMedium := newKeyValueMedium(t) _ = keyValueMedium.Write("group/key", "val") err := keyValueMedium.Delete("group/key") @@ -59,7 +59,7 @@ func TestKeyValueMedium_Delete_Good(t *testing.T) { } func TestKeyValueMedium_Delete_NonEmptyGroup_Bad(t *testing.T) { - keyValueMedium := newTestKeyValueMedium(t) + keyValueMedium := newKeyValueMedium(t) _ = keyValueMedium.Write("group/key", "val") err := keyValueMedium.Delete("group") @@ -67,7 +67,7 @@ func TestKeyValueMedium_Delete_NonEmptyGroup_Bad(t *testing.T) { } func TestKeyValueMedium_DeleteAll_Good(t *testing.T) { - keyValueMedium := newTestKeyValueMedium(t) + keyValueMedium := newKeyValueMedium(t) _ = keyValueMedium.Write("group/a", "1") _ = keyValueMedium.Write("group/b", "2") @@ -77,7 +77,7 @@ func TestKeyValueMedium_DeleteAll_Good(t *testing.T) { } func TestKeyValueMedium_Rename_Good(t *testing.T) { - keyValueMedium := newTestKeyValueMedium(t) + keyValueMedium := newKeyValueMedium(t) _ = keyValueMedium.Write("old/key", "val") err := keyValueMedium.Rename("old/key", "new/key") @@ -90,7 +90,7 @@ func TestKeyValueMedium_Rename_Good(t *testing.T) { } func TestKeyValueMedium_List_Groups_Good(t *testing.T) { - keyValueMedium := newTestKeyValueMedium(t) + keyValueMedium := newKeyValueMedium(t) _ = keyValueMedium.Write("alpha/a", "1") _ = keyValueMedium.Write("beta/b", "2") @@ -108,7 +108,7 @@ func TestKeyValueMedium_List_Groups_Good(t *testing.T) { } func TestKeyValueMedium_List_Keys_Good(t *testing.T) { - keyValueMedium := newTestKeyValueMedium(t) + keyValueMedium := newKeyValueMedium(t) _ = keyValueMedium.Write("group/a", "1") _ = keyValueMedium.Write("group/b", "22") @@ -118,7 +118,7 @@ func TestKeyValueMedium_List_Keys_Good(t *testing.T) { } func TestKeyValueMedium_Stat_Good(t *testing.T) { - keyValueMedium := newTestKeyValueMedium(t) + keyValueMedium := newKeyValueMedium(t) _ = keyValueMedium.Write("group/key", "hello") info, err := keyValueMedium.Stat("group") @@ -132,7 +132,7 @@ func TestKeyValueMedium_Stat_Good(t *testing.T) { } func TestKeyValueMedium_Exists_IsDir_Good(t *testing.T) { - keyValueMedium := newTestKeyValueMedium(t) + keyValueMedium := newKeyValueMedium(t) _ = keyValueMedium.Write("group/key", "val") assert.True(t, keyValueMedium.Exists("group")) @@ -143,7 +143,7 @@ func TestKeyValueMedium_Exists_IsDir_Good(t *testing.T) { } func TestKeyValueMedium_Open_Read_Good(t *testing.T) { - keyValueMedium := newTestKeyValueMedium(t) + keyValueMedium := newKeyValueMedium(t) _ = keyValueMedium.Write("group/key", "hello world") f, err := keyValueMedium.Open("group/key") @@ -156,7 +156,7 @@ func TestKeyValueMedium_Open_Read_Good(t *testing.T) { } func TestKeyValueMedium_CreateClose_Good(t *testing.T) { - keyValueMedium := newTestKeyValueMedium(t) + keyValueMedium := newKeyValueMedium(t) w, err := keyValueMedium.Create("group/key") require.NoError(t, err) @@ -169,7 +169,7 @@ func TestKeyValueMedium_CreateClose_Good(t *testing.T) { } func TestKeyValueMedium_Append_Good(t *testing.T) { - keyValueMedium := newTestKeyValueMedium(t) + keyValueMedium := newKeyValueMedium(t) _ = keyValueMedium.Write("group/key", "hello") w, err := keyValueMedium.Append("group/key") @@ -183,7 +183,7 @@ func TestKeyValueMedium_Append_Good(t *testing.T) { } func TestKeyValueMedium_AsMedium_Good(t *testing.T) { - keyValueStore := newTestKeyValueStore(t) + keyValueStore := newKeyValueStore(t) keyValueMedium := keyValueStore.AsMedium() require.NoError(t, keyValueMedium.Write("group/key", "val")) @@ -198,14 +198,14 @@ func TestKeyValueMedium_AsMedium_Good(t *testing.T) { } func TestKeyValueMedium_KeyValueStore_Good(t *testing.T) { - keyValueMedium := newTestKeyValueMedium(t) + keyValueMedium := newKeyValueMedium(t) assert.NotNil(t, keyValueMedium.KeyValueStore()) assert.Same(t, keyValueMedium.KeyValueStore(), keyValueMedium.KeyValueStore()) } func TestKeyValueMedium_EnsureDir_ReadWrite_Good(t *testing.T) { - keyValueMedium := newTestKeyValueMedium(t) + keyValueMedium := newKeyValueMedium(t) require.NoError(t, keyValueMedium.EnsureDir("ignored")) require.NoError(t, keyValueMedium.Write("group/key", "value")) @@ -216,7 +216,7 @@ func TestKeyValueMedium_EnsureDir_ReadWrite_Good(t *testing.T) { } func TestKeyValueMedium_StreamHelpers_Good(t *testing.T) { - keyValueMedium := newTestKeyValueMedium(t) + keyValueMedium := newKeyValueMedium(t) writer, err := keyValueMedium.WriteStream("group/key") require.NoError(t, err) diff --git a/store/store_test.go b/store/store_test.go index 3f4c2a9..9768a31 100644 --- a/store/store_test.go +++ b/store/store_test.go @@ -7,7 +7,7 @@ import ( "github.com/stretchr/testify/require" ) -func newTestKeyValueStore(t *testing.T) *KeyValueStore { +func newKeyValueStore(t *testing.T) *KeyValueStore { t.Helper() keyValueStore, err := New(Options{Path: ":memory:"}) @@ -19,7 +19,7 @@ func newTestKeyValueStore(t *testing.T) *KeyValueStore { } func TestKeyValueStore_New_Options_Good(t *testing.T) { - keyValueStore := newTestKeyValueStore(t) + keyValueStore := newKeyValueStore(t) assert.NotNil(t, keyValueStore) } @@ -29,7 +29,7 @@ func TestKeyValueStore_New_Options_Bad(t *testing.T) { } func TestKeyValueStore_SetGet_Good(t *testing.T) { - keyValueStore := newTestKeyValueStore(t) + keyValueStore := newKeyValueStore(t) err := keyValueStore.Set("config", "theme", "dark") require.NoError(t, err) @@ -40,14 +40,14 @@ func TestKeyValueStore_SetGet_Good(t *testing.T) { } func TestKeyValueStore_Get_NotFound_Bad(t *testing.T) { - keyValueStore := newTestKeyValueStore(t) + keyValueStore := newKeyValueStore(t) _, err := keyValueStore.Get("config", "missing") assert.ErrorIs(t, err, NotFoundError) } func TestKeyValueStore_Delete_Good(t *testing.T) { - keyValueStore := newTestKeyValueStore(t) + keyValueStore := newKeyValueStore(t) _ = keyValueStore.Set("config", "key", "val") err := keyValueStore.Delete("config", "key") @@ -58,7 +58,7 @@ func TestKeyValueStore_Delete_Good(t *testing.T) { } func TestKeyValueStore_Count_Good(t *testing.T) { - keyValueStore := newTestKeyValueStore(t) + keyValueStore := newKeyValueStore(t) _ = keyValueStore.Set("group", "a", "1") _ = keyValueStore.Set("group", "b", "2") @@ -70,7 +70,7 @@ func TestKeyValueStore_Count_Good(t *testing.T) { } func TestKeyValueStore_DeleteGroup_Good(t *testing.T) { - keyValueStore := newTestKeyValueStore(t) + keyValueStore := newKeyValueStore(t) _ = keyValueStore.Set("group", "a", "1") _ = keyValueStore.Set("group", "b", "2") @@ -82,7 +82,7 @@ func TestKeyValueStore_DeleteGroup_Good(t *testing.T) { } func TestKeyValueStore_GetAll_Good(t *testing.T) { - keyValueStore := newTestKeyValueStore(t) + keyValueStore := newKeyValueStore(t) _ = keyValueStore.Set("group", "a", "1") _ = keyValueStore.Set("group", "b", "2") @@ -94,7 +94,7 @@ func TestKeyValueStore_GetAll_Good(t *testing.T) { } func TestKeyValueStore_GetAll_Empty_Good(t *testing.T) { - keyValueStore := newTestKeyValueStore(t) + keyValueStore := newKeyValueStore(t) all, err := keyValueStore.GetAll("empty") require.NoError(t, err) @@ -102,7 +102,7 @@ func TestKeyValueStore_GetAll_Empty_Good(t *testing.T) { } func TestKeyValueStore_Render_Good(t *testing.T) { - keyValueStore := newTestKeyValueStore(t) + keyValueStore := newKeyValueStore(t) _ = keyValueStore.Set("user", "pool", "pool.lthn.io:3333") _ = keyValueStore.Set("user", "wallet", "iz...") diff --git a/workspace/service_test.go b/workspace/service_test.go index 081d2a4..70590a3 100644 --- a/workspace/service_test.go +++ b/workspace/service_test.go @@ -22,7 +22,7 @@ func (provider stubKeyPairProvider) CreateKeyPair(_, _ string) (string, error) { return provider.privateKey, nil } -func newTestService(t *testing.T) (*Service, string) { +func newWorkspaceService(t *testing.T) (*Service, string) { t.Helper() tempHome := t.TempDir() @@ -62,7 +62,7 @@ func TestService_New_CustomRootPathAndMedium_Good(t *testing.T) { } func TestService_WorkspaceFileRoundTrip_Good(t *testing.T) { - service, tempHome := newTestService(t) + service, tempHome := newWorkspaceService(t) workspaceID, err := service.CreateWorkspace("test-user", "pass123") require.NoError(t, err) @@ -86,7 +86,7 @@ func TestService_WorkspaceFileRoundTrip_Good(t *testing.T) { } func TestService_SwitchWorkspace_TraversalBlocked_Bad(t *testing.T) { - service, tempHome := newTestService(t) + service, tempHome := newWorkspaceService(t) outside := core.Path(tempHome, ".core", "escaped") require.NoError(t, service.medium.EnsureDir(outside)) @@ -97,7 +97,7 @@ func TestService_SwitchWorkspace_TraversalBlocked_Bad(t *testing.T) { } func TestService_WriteWorkspaceFile_TraversalBlocked_Bad(t *testing.T) { - service, tempHome := newTestService(t) + service, tempHome := newWorkspaceService(t) workspaceID, err := service.CreateWorkspace("test-user", "pass123") require.NoError(t, err) @@ -128,7 +128,7 @@ func TestService_JoinPathWithinRoot_DefaultSeparator_Good(t *testing.T) { } func TestService_HandleWorkspaceMessage_Command_Good(t *testing.T) { - service, _ := newTestService(t) + service, _ := newWorkspaceService(t) create := service.HandleWorkspaceMessage(core.New(), WorkspaceCommand{ Action: WorkspaceCreateAction,