[ax] Migrate os.Getenv, fmt.Sprintf, strings.* to core primitives #2

New issue

Open

opened 2026-03-22 16:39:15 +00:00 by Virgil · 1 comment

Virgil commented

2026-03-22 16:39:15 +00:00

Member

AX sweep findings:

HIGH — os.Getenv used directly (2 hits)

log.go:289 os.Getenv("USER")
log.go:292 os.Getenv("USERNAME")

HIGH — fmt.Sprintf used directly (7 hits)

errors.go:32, :34, :37, :39
log.go:228, :235, :237

HIGH — strings. used directly (18 hits)*

errors.go:215
log_test.go:72, :75, :78, :93, :96, :112, :115, :119, :130, :134, :182, :185, :188, :215, :216, :217, :234

Replace with core.Env(), core.Sprintf(), core.* equivalents.

AX sweep findings: **HIGH — os.Getenv used directly (2 hits)** - log.go:289 os.Getenv("USER") - log.go:292 os.Getenv("USERNAME") **HIGH — fmt.Sprintf used directly (7 hits)** - errors.go:32, :34, :37, :39 - log.go:228, :235, :237 **HIGH — strings.* used directly (18 hits)** - errors.go:215 - log_test.go:72, :75, :78, :93, :96, :112, :115, :119, :130, :134, :182, :185, :188, :215, :216, :217, :234 Replace with core.Env(), core.Sprintf(), core.* equivalents.

Virgil referenced this issue

2026-03-23 07:38:52 +00:00

[agent/codex] Fix ALL findings from issue #2. Read CLAUDE.md first. os.Get... #3

Virgil referenced this issue from a commit

2026-03-23 07:38:54 +00:00

Merge pull request '[agent/codex] Fix ALL findings from issue #2. Read CLAUDE.md first. os.Get...' (#3) from agent/fix-all-findings-from-issue--2--read-cla into dev

Virgil commented

2026-03-23 07:39:10 +00:00

Author

Member

Fix Applied

Commit 426b164: fix: replace stdlib helpers with core

os.Getenv(USER/USERNAME) → core.Env
fmt.Sprintf → core.Sprintf in errors.go and log.go
strings.* → core.* in tests
47 additions across 6 files

## Fix Applied Commit 426b164: fix: replace stdlib helpers with core - os.Getenv(USER/USERNAME) → core.Env - fmt.Sprintf → core.Sprintf in errors.go and log.go - strings.* → core.* in tests - 47 additions across 6 files