[agent/claude:opus] DX audit and fix. 1) Review CLAUDE.md — update any outdate... #3

Merged

Snider merged 2 commits from agent/dx-audit-and-fix--1--review-claude-md into dev

2026-03-23 18:52:07 +00:00

Virgil commented

2026-03-17 08:48:27 +00:00

Member

Task

DX audit and fix. 1) Review CLAUDE.md — update any outdated commands. 2) Run go test -cover ./... — report coverage, add tests for untested critical paths. 3) Check error handling: all errors must use coreerr.E() from go-log, not fmt.Errorf. Fix violations. 4) Check file I/O uses go-io not os.ReadFile/os.WriteFile. Fix violations. 5) Run tests to confirm. Commit fixes.

Agent: claude:opus
Commits: 1
Branch: agent/dx-audit-and-fix--1--review-claude-md

Auto-created by core-agent dispatch system.
Co-Authored-By: Virgil virgil@lethean.io

## Task DX audit and fix. 1) Review CLAUDE.md — update any outdated commands. 2) Run `go test -cover ./...` — report coverage, add tests for untested critical paths. 3) Check error handling: all errors must use coreerr.E() from go-log, not fmt.Errorf. Fix violations. 4) Check file I/O uses go-io not os.ReadFile/os.WriteFile. Fix violations. 5) Run tests to confirm. Commit fixes. **Agent:** claude:opus **Commits:** 1 **Branch:** `agent/dx-audit-and-fix--1--review-claude-md` --- Auto-created by core-agent dispatch system. Co-Authored-By: Virgil <virgil@lethean.io>

Virgil added 1 commit

2026-03-17 08:48:28 +00:00

refactor(dx): replace os.* with go-io, add nomlx build tags, add tests

Security Scan / security (pull_request) Successful in 8s

Details

Test / test (pull_request) Successful in 2m17s

Details

efaf19848a

- Replace all os.Open/Create/Stat/ReadFile/WriteFile/RemoveAll calls with
  coreio.Local equivalents across 25 production and test files
- Add !nomlx guard to all darwin/arm64 build constraints so tests and
  builds work without the native MLX library installed
- Update serve_backend_default.go constraint to match (|| nomlx)
- Add 17 new tests in export_test.go and io_test.go covering
  ValidatePercentages, FilterResponses, SplitData, WriteTrainingJSONL,
  ReadResponses, WriteScores/ReadScorerOutput, and ComputeAverages
- Fix CLAUDE.md GOFLAGS syntax documentation

Co-Authored-By: Virgil <virgil@lethean.io>

Virgil commented

2026-03-17 08:48:30 +00:00

Author

Member

Verification Failed

Command: go test ./...

# forge.lthn.ai/core/go-ml/cmd
cmd/cmd_chat.go:112:30: undefined: os
# forge.lthn.ai/core/go-ml.test
/opt/homebrew/opt/go/libexec/pkg/tool/darwin_arm64/link: running c++ failed: exit status 1
/usr/bin/c++ -arch arm64 -Wl,-S -Wl,-x -o $WORK/b351/go-ml.test -Qunused-arguments /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/go.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000000.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000001.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000002.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000003.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000004.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000005.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000006.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000007.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000008.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000009.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000010.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000011.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000012.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000013.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000014.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000015.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000016.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000017.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000018.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000019.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000020.o /var/folders/k6/c05lqf4j1nz248lbk_n...

Exit code: 1

PR will not be auto-merged.

## Verification Failed **Command:** `go test ./...` ``` # forge.lthn.ai/core/go-ml/cmd cmd/cmd_chat.go:112:30: undefined: os # forge.lthn.ai/core/go-ml.test /opt/homebrew/opt/go/libexec/pkg/tool/darwin_arm64/link: running c++ failed: exit status 1 /usr/bin/c++ -arch arm64 -Wl,-S -Wl,-x -o $WORK/b351/go-ml.test -Qunused-arguments /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/go.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000000.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000001.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000002.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000003.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000004.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000005.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000006.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000007.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000008.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000009.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000010.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000011.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000012.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000013.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000014.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000015.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000016.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000017.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000018.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000019.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2011066324/000020.o /var/folders/k6/c05lqf4j1nz248lbk_n... ``` **Exit code:** 1 PR will not be auto-merged.